Re: [f2fs-dev] Symlink not persisted even after fsync

2018-04-15 Thread Theodore Y. Ts'o
On Sun, Apr 15, 2018 at 07:10:52PM -0500, Vijay Chidambaram wrote: > > I don't think this is what the paper's ext3-fast does. All the paper > says is if you have a file system where the fsync of a file persisted > only data related to that file, it would increase performance. > ext3-fast is the na

Re: [f2fs-dev] Symlink not persisted even after fsync

2018-04-15 Thread Amir Goldstein
On Mon, Apr 16, 2018 at 3:10 AM, Vijay Chidambaram wrote: [...] > Consider the following workload: > > creat foo > link (foo, A/bar) > fsync(foo) > crash > > In this case, after the file system recovers, do we expect foo's link > count to be 2 or 1? I would say 2, but POSIX is silent on this,

Re: [f2fs-dev] [PATCH] mkfs.f2fs: use an array to manage features

2018-04-15 Thread Chao Yu
On 2018/4/15 22:36, Junling Zheng wrote: > From: Junling Zheng > > Use an array to manage features and their masks for mkfs. > > Signed-off-by: Junling Zheng Reviewed-by: Chao Yu Thanks, -- Check out the vibrant te

Re: [f2fs-dev] [PATCH] f2fs: clear PageError on writepage

2018-04-15 Thread Chao Yu
On 2018/4/13 9:07, Jaegeuk Kim wrote: > This patch clears PageError in some pages tagged by read path, but when we > write the pages with valid contents, writepage should clear the bit likewise > ext4. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, --

Re: [f2fs-dev] [PATCH] fs: f2fs: Adding new return type vm_fault_t

2018-04-15 Thread Chao Yu
On 2018/4/15 4:10, Souptick Joarder wrote: > Use new return type vm_fault_t for page_mkwrite > and fault handler. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox Acked-by: Chao Yu Thanks, > --- > fs/f2fs/file.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletion

Re: [f2fs-dev] Symlink not persisted even after fsync

2018-04-15 Thread Vijay Chidambaram
Hi Ted, On Sun, Apr 15, 2018 at 9:13 AM, Theodore Y. Ts'o wrote: > On Sat, Apr 14, 2018 at 08:35:45PM -0500, Vijaychidambaram Velayudhan Pillai > wrote: >> I was one of the authors on that paper, and I didn't know until today you >> didn't like that work :) The paper did *not* suggest we support

Re: [f2fs-dev] Symlink not persisted even after fsync

2018-04-15 Thread Theodore Y. Ts'o
On Sat, Apr 14, 2018 at 08:35:45PM -0500, Vijaychidambaram Velayudhan Pillai wrote: > I was one of the authors on that paper, and I didn't know until today you > didn't like that work :) The paper did *not* suggest we support invented > guarantees without considering the performance impact. I had