[f2fs-dev] [PATCH 3/5] f2fs: sanity check on sit entry

syzbot hit the following crash on upstream commit 87ef12027b9b1dd0e0b12cf311fbcb19f9d92539 (Wed Apr 18 19:48:17 2018 +) Merge tag 'ceph-for-4.17-rc2' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=83699adeb2d13579c31e C reproducer: https://

[f2fs-dev] [PATCH 5/5] f2fs: enforce fsync_mode=strict for renamed directory

This is to give a option for user to be able to recover B/foo in the below case. mkdir A sync() rename(A, B) creat (B/foo) fsync (B/foo) ---crash--- Sugessted-by: Velayudhan Pillai Signed-off-by: Jaegeuk Kim --- fs/f2fs/namei.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --

[f2fs-dev] [PATCH 4/5] f2fs: sanity check for total valid blocks

This patch enhances sanity check for SIT entries. syzbot hit the following crash on upstream commit 83beed7b2b26f232d782127792dd0cd4362fdc41 (Fri Apr 20 17:56:32 2018 +) Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal syzbot dashboard link: ht

[f2fs-dev] [PATCH 2/5] f2fs: avoid bug_on on corrupted inode

syzbot has tested the proposed patch but the reproducer still triggered crash: kernel BUG at fs/f2fs/inode.c:LINE! F2FS-fs (loop1): invalid crc value F2FS-fs (loop5): Magic Mismatch, valid(0xf2f52010) - read(0x0) F2FS-fs (loop5): Can't find valid F2FS filesystem in 1th superblock F2FS-fs (loop5):

[f2fs-dev] [PATCH 1/5] f2fs: give message and set need_fsck given broken node id

syzbot hit the following crash on upstream commit 83beed7b2b26f232d782127792dd0cd4362fdc41 (Fri Apr 20 17:56:32 2018 +) Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=d154ec99402c6

Re: [f2fs-dev] Lack of strictly ordered metadata crash recovery in f2fs

Hi, On 04/24, Jayashree Mohan wrote: > Hi, > > While testing filesystems for crash consistency, we came across a > workload that could demonstrate that f2fs lacks strictly ordered > metadata behavior. > > Workload: > > mkdir A > sync() > rename(A, B) > creat (B/foo) > fsync (B/foo) > ---crash--

[f2fs-dev] Lack of strictly ordered metadata crash recovery in f2fs

Hi, While testing filesystems for crash consistency, we came across a workload that could demonstrate that f2fs lacks strictly ordered metadata behavior. Workload: mkdir A sync() rename(A, B) creat (B/foo) fsync (B/foo) ---crash--- For a strictly ordered metadata filesystem, if we fsync a file,

[f2fs-dev] [PATCH] f2fs: build free nid bitmap during flush nat entries

This patch introduce free nid bitmap build during flush nat entries in order to reduce synchronous read in the process of build free nids. Signed-off-by: Yunlei He --- fs/f2fs/node.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index

[f2fs-dev] [PATCH] f2fs: avoid bug_on on corrupted inode

syzbot has tested the proposed patch but the reproducer still triggered crash: kernel BUG at fs/f2fs/inode.c:LINE! F2FS-fs (loop1): invalid crc value F2FS-fs (loop5): Magic Mismatch, valid(0xf2f52010) - read(0x0) F2FS-fs (loop5): Can't find valid F2FS filesystem in 1th superblock F2FS-fs (loop5):

Re: [f2fs-dev] kernel BUG at fs/f2fs/node.c:LINE!

On 04/24, Dmitry Vyukov wrote: > On Tue, Apr 24, 2018 at 8:42 AM, syzbot > wrote: > > Hello, > > > > syzbot tried to test the proposed patch but build/boot failed: > > > > failed to create VM pool: failed to create GCE image: failed to get create > > image operation operation-1524552040215-56a926e

Re: [f2fs-dev] kernel BUG at fs/f2fs/node.c:LINE!

Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: kernel BUG at fs/f2fs/inode.c:LINE! F2FS-fs (loop5): invalid crc value F2FS-fs (loop0): Magic Mismatch, valid(0xf2f52010) - read(0x0) F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock F2FS-

Re: [f2fs-dev] kernel BUG at fs/f2fs/node.c:LINE!

On Tue, Apr 24, 2018 at 8:42 AM, syzbot wrote: > Hello, > > syzbot tried to test the proposed patch but build/boot failed: > > failed to create VM pool: failed to create GCE image: failed to get create > image operation operation-1524552040215-56a926ecc71d9-3edfeb8b-8abca81c: > googleapi: Error 40

[f2fs-dev] [PATCH v3] f2fs: move mnt_want_write_file after range check

This patch move mnt_want_write_file after range check, it's needless to check arguments with it. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 16dad2b..6b79b8a 100644 --- a/fs/f2fs/fi

Re: [f2fs-dev] [PATCH v2] f2fs: move mnt_want_write_file after range check

On 2018/4/24 11:40, Yunlei He wrote: > This patch move mnt_want_write_file after range check, > it's needless to check arguments with it. > > Signed-off-by: Yunlei He Reviewed-by: Chao Yu Thanks, -- Check out the vib

Re: [f2fs-dev] [PATCH v2] f2fs: fix missing clear FI_NO_PREALLOC in some error case

On 2018/4/24 11:40, Yunlei He wrote: > This patch fix missing clear FI_NO_PREALLOC in some error case > > Signed-off-by: Yunlei He Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on one of the wo

Re: [f2fs-dev] [PATCH] f2fs: fix features filename in sysfs documentation

On 2018/4/24 1:26, Eric Biggers wrote: > From: Eric Biggers > > The file is called "features", not "feature". > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on

Re: [f2fs-dev] [PATCH] f2fs: clear page_error for all the writebacking pages

Hi Jaegeuk, On 2018/4/24 6:49, Jaegeuk Kim wrote: > This patch clear page_error bit, if the page is going to be writebacked. This patch is similar to previous patch ("f2fs: clear PageError on writepage"), only coverage is different, could you merge them? Thanks, > > Signed-off-by: Jaegeuk Kim