Re: [f2fs-dev] [PATCH 2/2] resize.f2fs: fix wrong nat_bits migration

2018-06-19 Thread Chao Yu
On 2018/6/18 8:39, Jaegeuk Kim wrote: > When wring the last nat_bits in new checkpoint, we call write_nat_bits() > to recover the nat_bits. But, we didn't update nm_i->nat_bitmap which we can > get the up-to-date nat blocks. After sit migration, old checkpoint has no > longer valid nat blocks, resu

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

2018-06-19 Thread Matthew Wilcox
On Tue, Jun 19, 2018 at 10:40:37AM -0600, Ross Zwisler wrote: > On Tue, Jun 19, 2018 at 02:22:30AM -0700, Matthew Wilcox wrote: > > On Mon, Jun 18, 2018 at 09:12:57PM -0600, Ross Zwisler wrote: > > > Hit another deadlock. This one reproduces 100% of the time in my setup > > > with > > > XFS + DAX

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

2018-06-19 Thread Ross Zwisler
On Tue, Jun 19, 2018 at 02:22:30AM -0700, Matthew Wilcox wrote: > On Mon, Jun 18, 2018 at 09:12:57PM -0600, Ross Zwisler wrote: > > Hit another deadlock. This one reproduces 100% of the time in my setup with > > XFS + DAX + generic/340. It doesn't reproduce for me at all with > > next-20180615.

Re: [f2fs-dev] [PATCH 1/2] fsck.f2fs: add sanity check nat_bits

2018-06-19 Thread Chao Yu
On 2018/6/18 8:39, Jaegeuk Kim wrote: > This patch adds to check nat_bits is valid or not. If not, it writes correct > nat_bits. > > Signed-off-by: Jaegeuk Kim > --- > fsck/mount.c | 95 > 1 file changed, 74 insertions(+), 21 deletions(-) > >

Re: [f2fs-dev] [PATCH] f2fs-tools: calculate inode checksum and writeback

2018-06-19 Thread Chao Yu
On 2018/6/14 11:10, Liu Xue wrote: > Calculate inode checksum and writeback when processing > sload or resize. > > Signed-off-by: Xue Liu Thanks for the fix. I just look around dev_write_block caller, it looks there are more similar issues should be fixed. Could you double check that? Thanks,

Re: [f2fs-dev] [PATCH] configure: uclinux is also linux

2018-06-19 Thread Chao Yu
On 2018/6/14 1:48, Baruch Siach wrote: > Linux systems on no-MMU platforms identify as uclinux. They are > otherwise identical to plain Linux. > > Signed-off-by: Baruch Siach Reviewed-by: Chao Yu Thanks, -- Check out

Re: [f2fs-dev] [PATCH] f2fs-tools: do not count free_segs in flush_sit_entries

2018-06-19 Thread Chao Yu
On 2018/6/13 18:13, Sheng Yong wrote: > flush_sit_entries() is always called before write_checkpoint(). Since > free_segs is counted in write_checkpoint, there is no need to do that > in flush_sit_entries. Besides, the value of free_segs may be not > correct if we skip uptodate seg_entries. > > Si

Re: [f2fs-dev] [RFC PATCH 2/2] fsck.f2fs: introduce fsck_chk_curseg_info

2018-06-19 Thread Chao Yu
On 2018/6/13 9:51, Sheng Yong wrote: > If curseg is an empty segment, it will not be checked. This patch > introduces fsck_chk_curseg_info() to check SIT/SSA type of cursegs > to avoid curseg corruption. > > Signed-off-by: Sheng Yong > --- > fsck/fsck.c | 34 ++ >

Re: [f2fs-dev] [PATCH 1/2] sload.f2fs: update sit entries of cursegs

2018-06-19 Thread Chao Yu
On 2018/6/13 9:51, Sheng Yong wrote: > move_curseg_info->reset_curseg changes cursegs, however, new segment > entries are not set as dirty. As a result, flush_sit_entries will not > update entries in SIT, especially when an empty segment is selected > as the new curseg, its seg_entry->type is lost.

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

2018-06-19 Thread Matthew Wilcox
On Mon, Jun 18, 2018 at 09:12:57PM -0600, Ross Zwisler wrote: > Hit another deadlock. This one reproduces 100% of the time in my setup with > XFS + DAX + generic/340. It doesn't reproduce for me at all with > next-20180615. Here's the output from "echo w > /proc/sysrq-trigger": *sigh*. I wonde