Re: [f2fs-dev] [PATCH] f2fs-tools: fix compile errors on AOSP

2018-06-20 Thread Chao Yu
On 2018/6/20 21:06, Junling Zheng wrote: > Include needed header files directly to fix compile errors on AOSP. > > Signed-off-by: Junling Zheng Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on

Re: [f2fs-dev] [PATCH v2] fsck.f2fs: introduce fsck_chk_curseg_info

2018-06-20 Thread Chao Yu
On 2018/6/20 19:12, Sheng Yong wrote: > If curseg is an empty segment, it will not be checked. This patch > introduces fsck_chk_curseg_info() to check SIT/SSA type of cursegs > to avoid curseg corruption. > > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: Fix uninitialized return in f2fs_ioc_shutdown()

2018-06-20 Thread Chao Yu
On 2018/6/20 18:39, Dan Carpenter wrote: > "ret" can be uninitialized on the success path when "in == > F2FS_GOING_DOWN_FULLSYNC". > > Fixes: 60b2b4ee2bc0 ("f2fs: Fix deadlock in shutdown ioctl") > Signed-off-by: Dan Carpenter Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: use timespec64 for inode timestamps

2018-06-20 Thread Chao Yu
On 2018/6/20 16:02, Arnd Bergmann wrote: > The on-disk representation and the vfs both use 64-bit tv_sec values, > so let's change the last missing piece in the middle. > > Signed-off-by: Arnd Bergmann Reviewed-by: Chao Yu Thanks, -

[f2fs-dev] [PATCH] f2fs: disable f2fs_check_rb_tree_consistence

2018-06-20 Thread Chao Yu
If there is millions of discard entries cached in rb tree, each sanity check of it can cause very long latency as held cmd_lock blocking other lock grabbers. In other aspect, we have enabled the check very long time, as we see, there is no such inconsistent condition caused by bugs. But still we

[f2fs-dev] [PATCH] fsck.f2fs: show missing large_nat_bitmap flag in print_ckpt_info

2018-06-20 Thread Chao Yu
Previously, we forget to print large_nat_bitmap according to CP flag, fix it. Signed-off-by: Chao Yu --- fsck/mount.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fsck/mount.c b/fsck/mount.c index f830e9b1f72a..b4911506cddb 100644 --- a/fsck/mount.c +++ b/fsck/mount.c @@ -405,6 +405,8 @

[f2fs-dev] [PATCH] f2fs-tools: fix compile errors on AOSP

2018-06-20 Thread Junling Zheng
Include needed header files directly to fix compile errors on AOSP. Signed-off-by: Junling Zheng --- include/f2fs_fs.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index 49ecee9..0a1ed84 100644 --- a/include/f2fs_fs.h +++ b/

[f2fs-dev] [PATCH v2] fsck.f2fs: introduce fsck_chk_curseg_info

2018-06-20 Thread Sheng Yong
If curseg is an empty segment, it will not be checked. This patch introduces fsck_chk_curseg_info() to check SIT/SSA type of cursegs to avoid curseg corruption. Signed-off-by: Sheng Yong --- v2: check c.fix_on and c.preen_mode before updating se->type fsck/fsck.c | 39 ++

[f2fs-dev] [PATCH] f2fs: Fix uninitialized return in f2fs_ioc_shutdown()

2018-06-20 Thread Dan Carpenter
"ret" can be uninitialized on the success path when "in == F2FS_GOING_DOWN_FULLSYNC". Fixes: 60b2b4ee2bc0 ("f2fs: Fix deadlock in shutdown ioctl") Signed-off-by: Dan Carpenter diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 6880c6f78d58..73c875c81ed6 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/

[f2fs-dev] [PATCH] f2fs: use timespec64 for inode timestamps

2018-06-20 Thread Arnd Bergmann
The on-disk representation and the vfs both use 64-bit tv_sec values, so let's change the last missing piece in the middle. Signed-off-by: Arnd Bergmann --- fs/f2fs/f2fs.h | 16 ++-- fs/f2fs/inode.c | 12 ++-- fs/f2fs/namei.c | 2 +- 3 files changed, 13 insertions(+), 17 de