Re: [f2fs-dev] [PATCH v3 1/2] f2fs: fix to avoid broken of dnode block list

2018-07-13 Thread Jaegeuk Kim
On 07/08, Chao Yu wrote: > From: Chao Yu > > f2fs recovery flow is relying on dnode block link list, it means fsynced > file recovery depends on previous dnode's persistence in the list, so > during fsync() we should wait on all regular inode's dnode writebacked > before issuing flush. > > By th

Re: [f2fs-dev] [PATCH] [RESEND] f2fs: use timespec64 for inode timestamps

2018-07-13 Thread Arnd Bergmann
On Fri, Jul 13, 2018 at 6:10 PM, Jaegeuk Kim wrote: > Hi Arnd, > > I queued in the testing branch, since I'm trying to fix another issue in > -next. > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=2cdbbf025aac9f3dd54b9dec0a6603839a3171d3 > > Allow me to

Re: [f2fs-dev] [PATCH] [RESEND] f2fs: use timespec64 for inode timestamps

2018-07-13 Thread Jaegeuk Kim
Hi Arnd, I queued in the testing branch, since I'm trying to fix another issue in -next. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=2cdbbf025aac9f3dd54b9dec0a6603839a3171d3 Allow me to merge it in -next sooner or later. Thanks, On 07/13, Arnd Bergman

[f2fs-dev] [PATCH] [RESEND] f2fs: use timespec64 for inode timestamps

2018-07-13 Thread Arnd Bergmann
The on-disk representation and the vfs both use 64-bit tv_sec values, so let's change the last missing piece in the middle. Reviewed-by: Chao Yu Signed-off-by: Arnd Bergmann --- I sent this on Jun 20 and got an Ack, but nobody picked up the patch into linux-next. Could you merge this for 4.19?

Re: [f2fs-dev] [f2fs-dev v2] [PATCH 2/4] f2fs: allow wrong configure dio to buffered write

2018-07-13 Thread Chao Yu
On 2018/7/13 1:59, Jaegeuk Kim wrote: > This fixes to support dio having unaligned buffers as buffered writes. > > xfs_io -f -d -c "pwrite 0 512" $testfile > -> okay > > xfs_io -f -d -c "pwrite 1 512" $testfile > -> EINVAL > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, --

Re: [f2fs-dev] [PATCH] f2fs: hide unused procfs helpers

2018-07-13 Thread YueHaibing
On 2018/7/13 17:02, Chao Yu wrote: > Hello, > > On 2018/7/13 11:53, YueHaibing wrote: >> When CONFIG_PROC_FS isn't set, gcc warning this: >> >> fs/f2fs/sysfs.c:519:12: warning: ‘segment_info_seq_show’ defined but not >> used [-Wunused-function] >> static int segment_info_seq_show(struct seq_fi

Re: [f2fs-dev] [PATCH] f2fs: hide unused procfs helpers

2018-07-13 Thread Chao Yu
Hello, On 2018/7/13 11:53, YueHaibing wrote: > When CONFIG_PROC_FS isn't set, gcc warning this: > > fs/f2fs/sysfs.c:519:12: warning: ‘segment_info_seq_show’ defined but not used > [-Wunused-function] > static int segment_info_seq_show(struct seq_file *seq, void *offset) > ^ > fs/f2f

Re: [f2fs-dev] [PATCH 2/5] f2fs: clear the remaining prefree_map of the section

2018-07-13 Thread Chao Yu
On 2018/7/13 11:51, Yunlong Song wrote: > Because in f2fs_clear_prefree_segments, the codes: > ... > while (1) { > int i; > start = find_next_bit(prefree_map, MAIN_SEGS(sbi), end + 1); > if (start >= MAIN_SEGS(sbi)) > break; > end = find_next_ze