Re: [f2fs-dev] [PATCH 3/3] f2fs: quota: fix incorrect error message and comments

2018-07-25 Thread Sheng Yong
On 2018/7/25 23:44, Chao Yu wrote: On 2018/7/24 20:17, Sheng Yong wrote: Signed-off-by: Sheng Yong --- fs/f2fs/checkpoint.c | 5 - fs/f2fs/recovery.c | 2 +- fs/f2fs/super.c | 5 + 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2

Re: [f2fs-dev] [PATCH RESEND] f2fs: fix to restrict mount condition when without CONFIG_QUOTA

2018-07-25 Thread Chao Yu
On 2018/7/26 9:41, Sheng Yong wrote: > Hi, Chao > > On 2018/7/26 7:19, Chao Yu wrote: >> From: Chao Yu >> >> Like quota_ino feature, we need to reject mounting RDWR with image >> which enables project_quota feature when there is no CONFIG_QUOTA >> be set in kernel. >> >> Signed-off-by: Chao Yu >

Re: [f2fs-dev] [PATCH RESEND] f2fs: fix to restrict mount condition when without CONFIG_QUOTA

2018-07-25 Thread Sheng Yong
Hi, Chao On 2018/7/26 7:19, Chao Yu wrote: From: Chao Yu Like quota_ino feature, we need to reject mounting RDWR with image which enables project_quota feature when there is no CONFIG_QUOTA be set in kernel. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 6 ++ 1 file changed, 6 insertio

[f2fs-dev] [PATCH v2] f2fs: checkpoint disabling

2018-07-25 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds a lightweight non-persistent snapshotting scheme to f2fs. To use, mount with the option checkpoint=disable, and to return to normal operation, remount with checkpoint=enable. If the filesystem is shut down before remounting with checkpoint=enable, it will revert back to its apparent stat

[f2fs-dev] [PATCH RESEND] f2fs: fix to restrict mount condition when without CONFIG_QUOTA

2018-07-25 Thread Chao Yu
From: Chao Yu Like quota_ino feature, we need to reject mounting RDWR with image which enables project_quota feature when there is no CONFIG_QUOTA be set in kernel. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/su

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

2018-07-25 Thread Ross Zwisler
On Wed, Jul 25, 2018 at 02:03:23PM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > > > I think I see a bug. No

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

2018-07-25 Thread Matthew Wilcox
On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > > I think I see a bug. No idea if it's the one you're hitting ;-) > > > > > > I had been intendin

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

2018-07-25 Thread Arnd Bergmann
On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu wrote: > On 2018/7/24 17:34, Arnd Bergmann wrote: >> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu >> causes a warning: >> >> fs/f2fs/inode.c: In function 'sanity_check_inode': >> fs/f2fs/inode.c:247:4: error: format '%lu' expects

Re: [f2fs-dev] [PATCH] f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc

2018-07-25 Thread Chao Yu
On 2018/7/25 11:22, Jaegeuk Kim wrote: > The f2fs_gc() called by f2fs_balance_fs() requires to be called outside of > fi->i_gc_rwsem[WRITE], since f2fs_gc() can try to grab it in a loop. It seems there are other paths having the same issue, how about fixing all of them in this patch? Thanks, >

Re: [f2fs-dev] [PATCH 2/5] f2fs: add cur_victim_sec for BG_GC to avoid skipping BG_GC victim

2018-07-25 Thread Chao Yu
On 2018/7/24 23:19, Yunlong Song wrote: > > > On 2018/7/24 22:17, Chao Yu wrote: >> On 2018/7/24 21:39, Yunlong Song wrote: >>> >>> On 2018/7/24 21:11, Chao Yu wrote: On 2018/7/23 22:10, Yunlong Song wrote: > If f2fs aborts BG_GC, then the section bit of victim_secmap will be set, >

Re: [f2fs-dev] [PATCH 3/3] f2fs: quota: fix incorrect error message and comments

2018-07-25 Thread Chao Yu
On 2018/7/24 20:17, Sheng Yong wrote: > Signed-off-by: Sheng Yong > --- > fs/f2fs/checkpoint.c | 5 - > fs/f2fs/recovery.c | 2 +- > fs/f2fs/super.c | 5 + > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 9c295

Re: [f2fs-dev] [PATCH 2/3] f2fs: quota: decrease the lock granularity of statfs_project

2018-07-25 Thread Chao Yu
On 2018/7/24 20:17, Sheng Yong wrote: > According to fs/quota/dquot.c, `dq_data_lock' protects mem_dqinfo > structures and modifications of dquot pointers in the inode, and > `dquot->dq_dqb_lock' protects data from dq_dqb. > > We should use dquot->dq_dqb_lock in statfs_project instead of > dq_dat_

[f2fs-dev] [PATCH] f2fs: fix to restrict mount condition when without CONFIG_QUOTA

2018-07-25 Thread Chao Yu
From: Chao Yu Like quota_ino feature, we need to reject mounting RDWR with image which enables project_quota feature when there is no CONFIG_QUOTA be set in kernel. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/su

Re: [f2fs-dev] [PATCH 1/3] f2fs: quota: do not mount as RDWR without QUOTA if quota feature enabled

2018-07-25 Thread Chao Yu
On 2018/7/24 20:17, Sheng Yong wrote: > If quota feature is enabled, quota is on by default. However, if > CONFIG_QUOTA is not built in kernel, dquot entries will not get updated, > which leads to quota inconsistency. > > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

2018-07-25 Thread Chao Yu
On 2018/7/24 17:34, Arnd Bergmann wrote: > On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu > causes a warning: > > fs/f2fs/inode.c: In function 'sanity_check_inode': > fs/f2fs/inode.c:247:4: error: format '%lu' expects argument of type 'long > unsigned int', but argument

Re: [f2fs-dev] [PATCH] f2fs: add a new mount option "errors_mode"

2018-07-25 Thread Chao Yu
On 2018/7/24 15:51, Yunlei He wrote: > This patch add a new mount option "errors_mode" to adjust > fs disposing cp error policy. Now supports "panic", > "remount-ro", and "continue". > > Signed-off-by: Yunlei He > --- > Documentation/filesystems/f2fs.txt | 2 ++ > fs/f2fs/checkpoint.c

Re: [f2fs-dev] [PATCH] mkfs.f2fs: Fix the checkpoint version written to the footer of the root inode

2018-07-25 Thread Chao Yu
Hello, Could you please make patch with git format-patch instead of git diff? On 2018/7/24 10:28, Sotirios-Efstathios Maneas wrote: > Dear all, > > The following patch fixes the checkpoint version written to the footer of the > inode associated with the root directory, while creating > the file

[f2fs-dev] [PATCH v4 2/2] f2fs: let checkpoint flush dnode page of regular

2018-07-25 Thread Chao Yu
Fsyncer will wait on all dnode pages of regular writeback before flushing, if there are async dnode pages blocked by IO scheduler, it may decrease fsync's performance. In this patch, we choose to let f2fs_balance_fs_bg() to trigger checkpoint to flush these dnode pages of regular, so async IO of d

[f2fs-dev] [PATCH v4 1/2] f2fs: fix to avoid broken of dnode block list

2018-07-25 Thread Chao Yu
f2fs recovery flow is relying on dnode block link list, it means fsynced file recovery depends on previous dnode's persistence in the list, so during fsync() we should wait on all regular inode's dnode writebacked before issuing flush. By this way, we can avoid dnode block list being broken by out