Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-08-20 Thread Chao Yu
On 2018/8/21 10:38, Jaegeuk Kim wrote: > On 08/20, Chao Yu wrote: >> On 2018/8/18 23:16, Jaegeuk Kim wrote: >>> On 08/17, Chao Yu wrote: generic/019 reports below error: __quota_error: 1160 callbacks suppressed Quota error (device zram1): write_blk: dquota write failed Q

Re: [f2fs-dev] [PATCH v5] f2fs: fix performance issue observed with multi-thread sequential read

2018-08-20 Thread Chao Yu
On 2018/8/21 10:36, Jaegeuk Kim wrote: > This reverts the commit - "b93f771 - f2fs: remove writepages lock" > to fix the drop in sequential read throughput. > > Test: ./tiotest -t 32 -d /data/tio_tmp -f 32 -b 524288 -k 1 -k 3 -L > device: UFS > > Before - > read throughput: 185 MB/s > total read

Re: [f2fs-dev] [PATCH v4] f2fs: fix performance issue observed with multi-thread sequential read

2018-08-20 Thread Chao Yu
On 2018/8/21 10:28, Jaegeuk Kim wrote: > On 08/20, Chao Yu wrote: >> On 2018/8/18 2:29, Jaegeuk Kim wrote: >>> This reverts the commit - "b93f771 - f2fs: remove writepages lock" >>> to fix the drop in sequential read throughput. >>> >>> Test: ./tiotest -t 32 -d /data/tio_tmp -f 32 -b 524288 -k 1 -k

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-08-20 Thread Jaegeuk Kim
On 08/20, Chao Yu wrote: > On 2018/8/18 23:16, Jaegeuk Kim wrote: > > On 08/17, Chao Yu wrote: > >> generic/019 reports below error: > >> > >> __quota_error: 1160 callbacks suppressed > >> Quota error (device zram1): write_blk: dquota write failed > >> Quota error (device zram1): qtree_write_dqu

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-08-20 Thread Jaegeuk Kim
On 08/20, guoweichao wrote: > Hi Jaegeuk, > > Is your test using a kernel include some unstable patches like "f2fs: > guarantee journalled quota data by checkpoint"? > I am planing to reproduce the problem with dev branch. Is that OK? Any hints > for reproducing? I actually removed such the pat

Re: [f2fs-dev] [PATCH v5] f2fs: fix performance issue observed with multi-thread sequential read

2018-08-20 Thread Jaegeuk Kim
This reverts the commit - "b93f771 - f2fs: remove writepages lock" to fix the drop in sequential read throughput. Test: ./tiotest -t 32 -d /data/tio_tmp -f 32 -b 524288 -k 1 -k 3 -L device: UFS Before - read throughput: 185 MB/s total read requests: 85177 (of these ~8 are 4KB size requests).

Re: [f2fs-dev] [PATCH v4] f2fs: fix performance issue observed with multi-thread sequential read

2018-08-20 Thread Jaegeuk Kim
On 08/20, Chao Yu wrote: > On 2018/8/18 2:29, Jaegeuk Kim wrote: > > This reverts the commit - "b93f771 - f2fs: remove writepages lock" > > to fix the drop in sequential read throughput. > > > > Test: ./tiotest -t 32 -d /data/tio_tmp -f 32 -b 524288 -k 1 -k 3 -L > > device: UFS > > > > Before - >

[f2fs-dev] [PATCH v4] f2fs: checkpoint disabling

2018-08-20 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds a lightweight non-persistent snapshotting scheme to f2fs. To use, mount with the option checkpoint=disable, and to return to normal operation, remount with checkpoint=enable. If the filesystem is shut down before remounting with checkpoint=enable, it will revert back to its apparent stat

[f2fs-dev] [PATCH] f2fs: fix to flush all dirty inodes during recovery

2018-08-20 Thread Chao Yu
From: Chao Yu generic/417 reported as blow: [ cut here ] kernel BUG at /home/yuchao/git/devf2fs/inode.c:695! invalid opcode: [#1] PREEMPT SMP CPU: 1 PID: 21697 Comm: umount Tainted: GW O 4.18.0-rc2+ #39 Hardware name: innotek GmbH VirtualBox/VirtualBox,

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-08-20 Thread guoweichao
Hi Jaegeuk, Is your test using a kernel include some unstable patches like "f2fs: guarantee journalled quota data by checkpoint"? I am planing to reproduce the problem with dev branch. Is that OK? Any hints for reproducing? Thank, Weichao On 2018/8/18 2:32, Jaegeuk Kim wrote: > Hi Weichao, >

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-08-20 Thread Chao Yu
On 2018/8/18 23:16, Jaegeuk Kim wrote: > On 08/17, Chao Yu wrote: >> generic/019 reports below error: >> >> __quota_error: 1160 callbacks suppressed >> Quota error (device zram1): write_blk: dquota write failed >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while >> creati

Re: [f2fs-dev] [PATCH 2/2] Ask git to ignore the generated sg_write_buffer executable

2018-08-20 Thread Chao Yu
Hi Ted, That has already been fixed in f2fs-utils, you can find the path in below link. :) https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-test&id=5180253fb40c8955e9541a3620264180cbbf280a https://lkml.org/lkml/2018/5/30/71 Thanks, On 2018/8/20 11:04, Theod

Re: [f2fs-dev] [PATCH v3] f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc

2018-08-20 Thread Chao Yu
Hi Jaegeuk, Please add: Reviewed-by: Chao Yu Thanks, On 2018/8/10 9:46, Jaegeuk Kim wrote: > On 08/10, Chao Yu wrote: >> On 2018/8/10 3:59, Jaegeuk Kim wrote: >>> Yup, how about this? >>> >>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >>> index d816c328f02b..cb510fb36523 100644 >>> --- a/fs/f2fs