Re: [f2fs-dev] [PATCH] f2fs: avoid wrong decrypted data from disk

2018-08-30 Thread Sahitya Tummala
On Thu, Aug 30, 2018 at 11:59:03AM +0530, Sahitya Tummala wrote: > On Mon, Aug 27, 2018 at 03:52:26PM -0700, Jaegeuk Kim wrote: > > 1. Create a file in an encrypted directory > > 2. Do GC & drop caches > > 3. Read stale data before its bio for metapage was not issued yet > > > > Signed-off-by: Jae

[f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-30 Thread Chengguang Xu
Add additinal sanity check for irregular case(e.g. corruption). If size of extended attribution is smaller than size of acl header, then return -EINVAL. Signed-off-by: Chengguang Xu --- fs/f2fs/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 11182

[f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
I have run out of space on my 1TB SSD formatted with f2fs, but df shows it is only 35% full. df -i shows 100% of the inodes are in use. What can I do? I don't see any mkfs.f2fs or mount options for increasing the number of inodes. --wpd -

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Chao Yu
Hi Patrick, Can you try -i option? On 2018/8/30 22:44, Patrick Doyle wrote: > I have run out of space on my 1TB SSD formatted with f2fs, but df > shows it is only 35% full. > > df -i shows 100% of the inodes are in use. > > What can I do? I don't see any mkfs.f2fs or mount options for > increa

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
On Thu, Aug 30, 2018 at 11:22 AM Chao Yu wrote: > > Hi Patrick, > > Can you try -i option? > Hello Chao, Thank you for your reply. For which command should I try the -i option? I presume you mean df: $ df -i /home/wpd/src/ Filesystem Inodes IUsed IFree IUse% Mounted on /dev/nvme0n1 97

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
On Thu, Aug 30, 2018 at 11:30 AM Patrick Doyle wrote: \> My f2fs partition is only 33% full, but I can no longer build on it, > as I keep getting "device out of space" errors. > Looking through the man pages (and source code) for mkfs.f2fs, I wonder if I should try (backing up my partition and) re

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Chao Yu
Hi Patrick, On 2018/8/30 23:30, Patrick Doyle wrote: > On Thu, Aug 30, 2018 at 11:22 AM Chao Yu wrote: >> >> Hi Patrick, >> >> Can you try -i option? Sorry, I mean mkfs.f2fs -i /dev/xxx; And you can use stat -f /your_mount_option to see whether largest number of inode support in new image incre

Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-30 Thread Chao Yu
Hi Chengguang, On 2018/8/30 21:33, Chengguang Xu wrote: > Add additinal sanity check for irregular case(e.g. corruption). > If size of extended attribution is smaller than size of acl header, > then return -EINVAL. > > Signed-off-by: Chengguang Xu > --- > fs/f2fs/acl.c | 3 +++ > 1 file changed

Re: [f2fs-dev] [RFC PATCH v3 3/5] f2fs-tools: unify the writeback of superblock

2018-08-30 Thread Chao Yu
On 2018/8/30 11:37, Junling Zheng wrote: > Introduce __write_superblock() to support updating specified one > superblock or both, thus we can wrapper it in update_superblock() and > f2fs_write_super_block to unify all places where sb needs to be updated. > > Signed-off-by: Junling Zheng Reviewed

Re: [f2fs-dev] [PATCH v3] f2fs: avoid wrong decrypted data from disk

2018-08-30 Thread Chao Yu
On 2018/8/30 12:04, Jaegeuk Kim wrote: > 1. Create a file in an encrypted directory > 2. Do GC & drop caches > 3. Read stale data before its bio for metapage was not issued yet > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
On Thu, Aug 30, 2018 at 11:40 AM Chao Yu wrote: > Hi Patrick, > On 2018/8/30 23:30, Patrick Doyle wrote: > > On Thu, Aug 30, 2018 at 11:22 AM Chao Yu wrote: > >> > >> Hi Patrick, > >> > >> Can you try -i option? > > Sorry, I mean mkfs.f2fs -i /dev/xxx; -i isn't an allowable option to mkfs.f2fs: U

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Chao Yu
On 2018/8/30 23:45, Patrick Doyle wrote: > On Thu, Aug 30, 2018 at 11:40 AM Chao Yu wrote: >> Hi Patrick, >> On 2018/8/30 23:30, Patrick Doyle wrote: >>> On Thu, Aug 30, 2018 at 11:22 AM Chao Yu wrote: Hi Patrick, Can you try -i option? >> >> Sorry, I mean mkfs.f2fs -i /dev/xx

Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-30 Thread cgxu519
On 08/30/2018 11:41 PM, Chao Yu wrote: Hi Chengguang, On 2018/8/30 21:33, Chengguang Xu wrote: Add additinal sanity check for irregular case(e.g. corruption). If size of extended attribution is smaller than size of acl header, then return -EINVAL. Signed-off-by: Chengguang Xu --- fs/f2fs/a

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Jaegeuk Kim
On 08/30, Chao Yu wrote: > On 2018/8/30 23:45, Patrick Doyle wrote: > > On Thu, Aug 30, 2018 at 11:40 AM Chao Yu wrote: > >> Hi Patrick, > >> On 2018/8/30 23:30, Patrick Doyle wrote: > >>> On Thu, Aug 30, 2018 at 11:22 AM Chao Yu wrote: > > Hi Patrick, > > Can you try -i optio

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
On Thu, Aug 30, 2018 at 12:58 PM Jaegeuk Kim wrote: > Patrick, > > Please download the latest f2fs-tools from > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/log/ > > Chao, Jaegeuk, Thank you very much. I just cloned that repository and I see that it includes a "-i" optio

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Jaegeuk Kim
Hi, On 08/30, Patrick Doyle wrote: > On Thu, Aug 30, 2018 at 12:58 PM Jaegeuk Kim wrote: > > Patrick, > > > > Please download the latest f2fs-tools from > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/log/ > > > > Chao, > Jaegeuk, > Thank you very much. I just cloned t

Re: [f2fs-dev] Out of inodes on my f2fs partition

2018-08-30 Thread Patrick Doyle
On Thu, Aug 30, 2018 at 1:56 PM Jaegeuk Kim wrote: > Hi, > I expect "-i" should give more # of inodes, since without it, F2FS relied on > relatively small (but enough on smaller capacity) checkpoint blocks to provide > them. With the option, it expands checkpoint space to allow more nids which >