Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-31 Thread Chao Yu
On 2018/8/31 0:19, cgxu519 wrote: > > On 08/30/2018 11:41 PM, Chao Yu wrote: >> Hi Chengguang, >> >> On 2018/8/30 21:33, Chengguang Xu wrote: >>> Add additinal sanity check for irregular case(e.g. corruption). >>> If size of extended attribution is smaller than size of acl header, >>> then return

[f2fs-dev] [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs.

2018-08-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200871 --- Comment #3 from Chao Yu (c...@kernel.org) --- Alright, can you please provider the complete testcase including error injection script for me? I'd like to reproduce in my environment. -- You are receiving this mail because: You are watching t

[f2fs-dev] [Bug 200951] kernel NULL pointer dereference in update_sit_entry

2018-08-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200951 Chao Yu (c...@kernel.org) changed: What|Removed |Added CC||c...@kernel.org --- Comment #

[f2fs-dev] [PATCH] f2fs: fix unnecessary periodic wakeup of discard thread when dev is busy

2018-08-31 Thread Sahitya Tummala
When dev is busy, discard thread wake up timeout can be aligned with the exact time that it needs to wait for dev to come out of busy. This helps to avoid unnecessary periodic wakeups and thus save some power. Signed-off-by: Sahitya Tummala --- fs/f2fs/segment.c | 8 +++- 1 file changed, 7 i

Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-31 Thread Chengguang Xu
On 2018/8/31 at 下午3:02, Chao Yu wrote: > On 2018/8/31 0:19, cgxu519 wrote: > > > > On 08/30/2018 11:41 PM, Chao Yu wrote: > >> Hi Chengguang, > >> > >> On 2018/8/30 21:33, Chengguang Xu wrote: > >>> Add additinal sanity check for irregular case(e.g. corruption). > >>> If size of extended attrib

Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-31 Thread Chao Yu
On 2018/8/31 19:40, Chengguang Xu wrote: > > > On 2018/8/31 at 下午3:02, Chao Yu wrote: > >> On 2018/8/31 0:19, cgxu519 wrote: >>> >>> On 08/30/2018 11:41 PM, Chao Yu wrote: Hi Chengguang, On 2018/8/30 21:33, Chengguang Xu wrote: > Add additinal sanity check for irregular case(e

Re: [f2fs-dev] [PATCH] f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-08-31 Thread Chao Yu
On 2018/8/30 21:33, Chengguang Xu wrote: > Add additinal sanity check for irregular case(e.g. corruption). > If size of extended attribution is smaller than size of acl header, > then return -EINVAL. > > Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Thanks, --

[f2fs-dev] [PATCH v2 3/5] f2fs: cache NULL when both default_acl and acl are NULL

2018-08-31 Thread Chengguang Xu
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to

[f2fs-dev] [PATCH v2 5/5] orangefs: cache NULL when both default_acl and acl are NULL

2018-08-31 Thread Chengguang Xu
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to

[f2fs-dev] [PATCH v2 2/5] ext4: cache NULL when both default_acl and acl are NULL

2018-08-31 Thread Chengguang Xu
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to

[f2fs-dev] [PATCH v2 4/5] jfs: cache NULL when both default_acl and acl are NULL

2018-08-31 Thread Chengguang Xu
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to

[f2fs-dev] [PATCH v2 1/5] ext2: cache NULL when both default_acl and acl are NULL

2018-08-31 Thread Chengguang Xu
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to

Re: [f2fs-dev] [RFC PATCH 00/10] fs-verity: filesystem-level integrity protection

2018-08-31 Thread Jan Lübbe
On Fri, 2018-08-24 at 09:16 -0700, Eric Biggers wrote: [...] > Since fs-verity provides the Merkle tree root hash in constant time and > verifies data blocks on-demand, it is useful for efficiently verifying > the authenticity of, or "appraising", large files of which only a small > portion may be

Re: [f2fs-dev] [RFC PATCH 00/10] fs-verity: filesystem-level integrity protection

2018-08-31 Thread Eric Biggers
Hi Jan, On Fri, Aug 31, 2018 at 10:05:23PM +0200, Jan Lübbe wrote: > On Fri, 2018-08-24 at 09:16 -0700, Eric Biggers wrote: > [...] > > Since fs-verity provides the Merkle tree root hash in constant time and > > verifies data blocks on-demand, it is useful for efficiently verifying > > the authent