Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-09-07 Thread Chao Yu
I can see it in dev, thanks for merging. ;) On 2018/9/8 6:38, Jaegeuk Kim wrote: > I merged as one. Please check dev. :) > > On 09/06, Chao Yu wrote: >> generic/019 reports below error: >> >> __quota_error: 1160 callbacks suppressed >> Quota error (device zram1): write_blk: dquota write failed

Re: [f2fs-dev] [PATCH v6] f2fs: guarantee journalled quota data by checkpoint

2018-09-07 Thread Chao Yu
Jaegeuk, On 2018/9/8 5:45, Jaegeuk Kim wrote: > Chao, > > I was testing the previous patch and removed in the queue due to quota-related > hang during fault injection + shutdown test. Let me try this later. All testcases didn't complain when testing in company, but, now I test them again in home

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to avoid quota inode leak in ->put_super

2018-09-07 Thread Jaegeuk Kim
I merged as one. Please check dev. :) On 09/06, Chao Yu wrote: > generic/019 reports below error: > > __quota_error: 1160 callbacks suppressed > Quota error (device zram1): write_blk: dquota write failed > Quota error (device zram1): qtree_write_dquot: Error -28 occurred while > creating quot

Re: [f2fs-dev] [RFC PATCH v3 3/5] f2fs-tools: unify the writeback of superblock

2018-09-07 Thread Jaegeuk Kim
On 08/30, Junling Zheng wrote: > Introduce __write_superblock() to support updating specified one > superblock or both, thus we can wrapper it in update_superblock() and > f2fs_write_super_block to unify all places where sb needs to be updated. > > Signed-off-by: Junling Zheng > --- > v2 -> v3: >

Re: [f2fs-dev] [PATCH v6] f2fs: guarantee journalled quota data by checkpoint

2018-09-07 Thread Jaegeuk Kim
Chao, I was testing the previous patch and removed in the queue due to quota-related hang during fault injection + shutdown test. Let me try this later. Thanks, On 09/07, Chao Yu wrote: > For journalled quota mode, let checkpoint to flush dquot dirty data > and quota file data to guarntee persis

[f2fs-dev] [PATCH] f2fs: submit bio after shutdown

2018-09-07 Thread Jaegeuk Kim
Sometimes, some merged IOs could get a chance to be submitted, resulting in system hang in shutdown test. This issues IOs all the time after shutdown. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 8c204f8

Re: [f2fs-dev] [PATCH v2 5/5] orangefs: cache NULL when both default_acl and acl are NULL

2018-09-07 Thread Mike Marshall
Thanks... I've added your patch to 4.19-rc2, run it through xfstests, and added it to my linux-next tree... -Mike On Fri, Aug 31, 2018 at 10:35 AM Chengguang Xu wrote: > > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and late

[f2fs-dev] [PATCH v7] f2fs: guarantee journalled quota data by checkpoint

2018-09-07 Thread Chao Yu
From: Chao Yu For journalled quota mode, let checkpoint to flush dquot dirty data and quota file data to guarntee persistence of all quota sysfile in last checkpoint, by this way, we can avoid corrupting quota sysfile when encountering SPO. The implementation is as below: 1. add a global state

[f2fs-dev] [PATCH] f2fs: plug readahead IO in readdir()

2018-09-07 Thread Chao Yu
Add a plug to merge readahead IO in readdir(), expecting it can reduce bio count before submitting to block layer. Signed-off-by: Chao Yu --- fs/f2fs/dir.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index ecc3a4e2be96

Re: [f2fs-dev] [PATCH] f2fs: remove sleep from atomic lock in __try_update_largest_extent

2018-09-07 Thread zhangzhikang
Hi Chao, I send a new patch to fix it. Thanks! Regards, Zhikang > Hi Zhikang, > > On 2018/9/8 1:31, Zhikang Zhang wrote: > > In the call trace below, we might sleep in function dput(). > > > > So we should move f2fs_mark_inode_dirty_sync to the end of > > f2fs_update_extent_tree_range(out of th

Re: [f2fs-dev] [PATCH] f2fs: remove sleep from atomic lock in __try_update_largest_extent

2018-09-07 Thread Chao Yu
Hi Zhikang, On 2018/9/8 1:31, Zhikang Zhang wrote: > In the call trace below, we might sleep in function dput(). > > So we should move f2fs_mark_inode_dirty_sync to the end of > f2fs_update_extent_tree_range(out of the write_lock). I think we need to cover __drop_largest_extent as well, since it

[f2fs-dev] [PATCH v6] f2fs: guarantee journalled quota data by checkpoint

2018-09-07 Thread Chao Yu
For journalled quota mode, let checkpoint to flush dquot dirty data and quota file data to guarntee persistence of all quota sysfile in last checkpoint, by this way, we can avoid corrupting quota sysfile when encountering SPO. The implementation is as below: 1. add a global state SBI_QUOTA_NEED_F

[f2fs-dev] [PATCH] f2fs: remove sleep from atomic lock in __try_update_largest_extent

2018-09-07 Thread Zhikang Zhang
In the call trace below, we might sleep in function dput(). So we should move f2fs_mark_inode_dirty_sync to the end of f2fs_update_extent_tree_range(out of the write_lock). BUG: sleeping function called from invalid context at fs/dcache.c:796 Call trace: dump_backtrace+0x0/0x3f4 s