Re: [f2fs-dev] [RFC PATCH v3 3/5] f2fs-tools: unify the writeback of superblock

2018-09-10 Thread Junling Zheng
Hi, Jaegeuk On 2018/9/11 10:43, Junling Zheng wrote: > On 2018/9/8 6:23, Jaegeuk Kim wrote: >> On 08/30, Junling Zheng wrote: >>> diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h >>> index 38a0da4..df46950 100644 >>> --- a/include/f2fs_fs.h >>> +++ b/include/f2fs_fs.h >>> @@ -1411,4 +1411,39 @@

[f2fs-dev] [Bug 200951] kernel NULL pointer dereference in update_sit_entry

2018-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200951 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] f2fs page flag set with private but page.private pointer is NULL

2018-09-10 Thread Kassey
hi, Jaegeuk: we got some easy reproduced issue when doing reboot test. that the android init is sleep on a page to be writebback. from the ftrace we can confirm wb_workfn got running each 5s. but init has stuck for quite long time because below page can not be writeback done. by

Re: [f2fs-dev] [RFC PATCH v3 3/5] f2fs-tools: unify the writeback of superblock

2018-09-10 Thread Junling Zheng
On 2018/9/8 6:23, Jaegeuk Kim wrote: > On 08/30, Junling Zheng wrote: >> Introduce __write_superblock() to support updating specified one >> superblock or both, thus we can wrapper it in update_superblock() and >> f2fs_write_super_block to unify all places where sb needs to be updated. >> >>

[f2fs-dev] [PATCH v3 2/2] f2fs: fix setattr project check upon fssetxattr ioctl

2018-09-10 Thread Wang Shilong
From: Wang Shilong Currently, project quota could be changed by fssetxattr ioctl, and existed permission check inode_owner_or_capable() is obviously not enough, just think that common users could change project id of file, that could make users to break project quota easily. This patch try to

[f2fs-dev] [PATCH v2] f2fs: surround fault_injection ralted option parsing using CONFIG_F2FS_FAULT_INJECTION

2018-09-10 Thread Chengguang Xu
It's a little bit strange when fault_injection related options fail with -EINVAL which were already disabled from config, so surround all fault_injection related option parsing code using CONFIG_F2FS_FAULT_INJECTION. Meanwhile, slightly change warning message to keep consistency with option

Re: [f2fs-dev] [PATCH] f2fs: surround fault_injection ralted option parsing using CONFIG_F2FS_FAULT_INJECTION

2018-09-10 Thread Chao Yu
On 2018/9/10 23:48, Chengguang Xu wrote: > It's a little bit strange when fault_injection related > options fail with -EINVAL which were already disabled > from config, so surround all fault_injection related option > parsing code using CONFIG_F2FS_FAULT_INJECTION. Meanwhile, > slightly change

Re: [f2fs-dev] [PATCH v2] f2fs: add new idle interval timing for discard and gc paths

2018-09-10 Thread Chao Yu
On 2018/9/10 11:47, Sahitya Tummala wrote: > This helps to control the frequency of submission of discard and > GC requests independently, based on the need. The sleep timing of > GC thread is now aligned with this idle time when the dev is busy, > to avoid unnecessary periodic wakeups. > >

[f2fs-dev] [PATCH] f2fs: surround fault_injection ralted option parsing using CONFIG_F2FS_FAULT_INJECTION

2018-09-10 Thread Chengguang Xu
It's a little bit strange when fault_injection related options fail with -EINVAL which were already disabled from config, so surround all fault_injection related option parsing code using CONFIG_F2FS_FAULT_INJECTION. Meanwhile, slightly change warning message to keep consistency with option

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix setattr project check upon fssetxattr ioctl

2018-09-10 Thread Chao Yu
On 2018/9/9 17:15, Wang Shilong wrote: > From: Wang Shilong > > Currently, project quota could be changed by fssetxattr > ioctl, and existed permission check inode_owner_or_capable() > is obviously not enough, just think that common users could > change project id of file, that could make users

Re: [f2fs-dev] [PATCH v3] f2fs: avoid sleeping under spin_lock

2018-09-10 Thread Chao Yu
On 2018/9/10 16:18, Zhikang Zhang wrote: > In the call trace below, we might sleep in function dput(). > > So in order to avoid sleeping under spin_lock, we remove > f2fs_mark_inode_dirty_sync > from __try_update_largest_extent && __drop_largest_extent. > > BUG: sleeping function called from

Re: [f2fs-dev] [PATCH] f2fs: submit bio after shutdown

2018-09-10 Thread Chao Yu
On 2018/9/8 5:28, Jaegeuk Kim wrote: > Sometimes, some merged IOs could get a chance to be submitted, resulting in > system hang in shutdown test. This issues IOs all the time after shutdown. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/data.c | 2 ++ > 1 file

[f2fs-dev] [PATCH v3] f2fs: avoid sleeping under spin_lock

2018-09-10 Thread Zhikang Zhang
In the call trace below, we might sleep in function dput(). So in order to avoid sleeping under spin_lock, we remove f2fs_mark_inode_dirty_sync from __try_update_largest_extent && __drop_largest_extent. BUG: sleeping function called from invalid context at fs/dcache.c:796 Call trace: