Re: [f2fs-dev] [PATCH v4] f2fs: allow out-place-update for direct IO in LFS mode

2018-09-26 Thread Chao Yu
On 2018/9/27 13:12, Sahitya Tummala wrote: > On Fri, Sep 21, 2018 at 09:12:22PM +0800, Chao Yu wrote: >> From: Chao Yu >> >> Normally, DIO uses in-pllace-update, but in LFS mode, f2fs doesn't >> allow triggering any in-place-update writes, so we fallback direct >> write to buffered write, result i

Re: [f2fs-dev] [PATCH] f2fs: refactor ->page_mkwrite() flow

2018-09-26 Thread Chao Yu
On 2018/9/27 13:05, Jaegeuk Kim wrote: > This makes xfstests/083 stuck. So, I'll drop it for a while. Alright, let me check that case again. Thanks, > > On 09/26, Chao Yu wrote: >> From: Chao Yu >> >> Thread A Thread B >> - f2fs_vm_page_mkwrite >>

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

2018-09-26 Thread Chao Yu
On 2018/9/27 12:58, Jaegeuk Kim wrote: > On 09/27, Chao Yu wrote: >> On 2018/9/27 3:49, Jaegeuk Kim wrote: >>> On 09/26, Chao Yu wrote: On 2018/9/26 9:10, Chao Yu wrote: > On 2018/9/26 8:18, Jaegeuk Kim wrote: >> On 09/21, Chao Yu wrote: >>> On 2018/9/21 5:46, Jaegeuk Kim wrote: >>

[f2fs-dev] [PATCH] fsck.f2fs: support checkpoint=disable

2018-09-26 Thread Jaegeuk Kim
This patch shows checkpoint is disabled and keeps the flag for next mount. Signed-off-by: Jaegeuk Kim --- fsck/fsck.c | 2 ++ fsck/mount.c | 4 include/f2fs_fs.h | 1 + 3 files changed, 7 insertions(+) diff --git a/fsck/fsck.c b/fsck/fsck.c index 19220e2..ca4e74e 100644 --- a/fs

Re: [f2fs-dev] [PATCH v4] f2fs: allow out-place-update for direct IO in LFS mode

2018-09-26 Thread Sahitya Tummala
On Fri, Sep 21, 2018 at 09:12:22PM +0800, Chao Yu wrote: > From: Chao Yu > > Normally, DIO uses in-pllace-update, but in LFS mode, f2fs doesn't > allow triggering any in-place-update writes, so we fallback direct > write to buffered write, result in bad performance of large size > write. > > Thi

Re: [f2fs-dev] [PATCH] f2fs: refactor ->page_mkwrite() flow

2018-09-26 Thread Jaegeuk Kim
This makes xfstests/083 stuck. So, I'll drop it for a while. On 09/26, Chao Yu wrote: > From: Chao Yu > > Thread A Thread B > - f2fs_vm_page_mkwrite > - f2fs_setattr >- down_write(i_mmap_se

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

2018-09-26 Thread Jaegeuk Kim
On 09/27, Chao Yu wrote: > On 2018/9/27 3:49, Jaegeuk Kim wrote: > > On 09/26, Chao Yu wrote: > >> On 2018/9/26 9:10, Chao Yu wrote: > >>> On 2018/9/26 8:18, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: > > On 2018/9/21 5:46, Jaegeuk Kim wrote: > >> On 09/20, Chao Yu wrote: > >>>

Re: [f2fs-dev] [f2fs:dev-test 30/30] fs/f2fs/file.c:99:2: error: implicit declaration of function '__do_map_lock'; did you mean '__cond_lock'?

2018-09-26 Thread Chao Yu
To Jaegeuk, On 2018/9/27 11:25, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > dev-test > head: 008aecc0a7dd2906168196bd016a547704c2b444 > commit: 008aecc0a7dd2906168196bd016a547704c2b444 [30/30] f2fs: refactor > ->page_mkwrite() flow > co

Re: [f2fs-dev] [PATCH 4/5] f2fs-tools: introduce sb checksum

2018-09-26 Thread Junling Zheng
On 2018/9/27 4:27, Jaegeuk Kim wrote: > On 09/26, Junling Zheng wrote: >> Hi, Jaegeuk >> >> On 2018/9/26 9:57, Jaegeuk Kim wrote: >>> On 09/21, Junling Zheng wrote: On 2018/9/21 5:38, Jaegeuk Kim wrote: > On 09/20, Junling Zheng wrote: >> Hi, Jaegeuk >> >> On 2018/9/20 7:35, Ja

Re: [f2fs-dev] [PATCH v4] f2fs: allow out-place-update for direct IO in LFS mode

2018-09-26 Thread Chao Yu
Ping, On 2018/9/21 21:12, Chao Yu wrote: > From: Chao Yu > > Normally, DIO uses in-pllace-update, but in LFS mode, f2fs doesn't > allow triggering any in-place-update writes, so we fallback direct > write to buffered write, result in bad performance of large size > write. > > This patch adds to

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

2018-09-26 Thread Chao Yu
On 2018/9/26 10:09, Jaegeuk Kim wrote: > Oh, yeah. :P > I started to run all my tests with this. Let me see what will happen. Any updates of this test? Thanks ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sour

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

2018-09-26 Thread Chao Yu
On 2018/9/27 3:49, Jaegeuk Kim wrote: > On 09/26, Chao Yu wrote: >> On 2018/9/26 9:10, Chao Yu wrote: >>> On 2018/9/26 8:18, Jaegeuk Kim wrote: On 09/21, Chao Yu wrote: > On 2018/9/21 5:46, Jaegeuk Kim wrote: >> On 09/20, Chao Yu wrote: >>> On 2018/9/19 1:56, Jaegeuk Kim wrote: >>>

Re: [f2fs-dev] [PATCH 4/5] f2fs-tools: introduce sb checksum

2018-09-26 Thread Jaegeuk Kim
On 09/26, Junling Zheng wrote: > Hi, Jaegeuk > > On 2018/9/26 9:57, Jaegeuk Kim wrote: > > On 09/21, Junling Zheng wrote: > >> On 2018/9/21 5:38, Jaegeuk Kim wrote: > >>> On 09/20, Junling Zheng wrote: > Hi, Jaegeuk > > On 2018/9/20 7:35, Jaegeuk Kim wrote: > > On 09/19, Junling

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

2018-09-26 Thread Jaegeuk Kim
On 09/26, Chao Yu wrote: > On 2018/9/26 9:10, Chao Yu wrote: > > On 2018/9/26 8:18, Jaegeuk Kim wrote: > >> On 09/21, Chao Yu wrote: > >>> On 2018/9/21 5:46, Jaegeuk Kim wrote: > On 09/20, Chao Yu wrote: > > On 2018/9/19 1:56, Jaegeuk Kim wrote: > >> This patch avoids BUG_ON when f2fs_

[f2fs-dev] [PATCH] f2fs: checkpoint disabling

2018-09-26 Thread Jaegeuk Kim
From: Daniel Rosenberg Note that, it requires "f2fs: return correct errno in f2fs_gc". This adds a lightweight non-persistent snapshotting scheme to f2fs. To use, mount with the option checkpoint=disable, and to return to normal operation, remount with checkpoint=enable. If the filesystem is sh

[f2fs-dev] [PATCH] f2fs: refactor ->page_mkwrite() flow

2018-09-26 Thread Chao Yu
From: Chao Yu Thread AThread B - f2fs_vm_page_mkwrite - f2fs_setattr - down_write(i_mmap_sem) - truncate_setsize

[f2fs-dev] [PATCH RESEND v2] Revert: "f2fs: check last page index in cached bio to decide submission"

2018-09-26 Thread Chao Yu
From: Chao Yu There is one case that we can leave bio in f2fs, result in hanging page writeback waiter. Thread AThread B - f2fs_write_cache_pages - f2fs_submit_page_write page #0 cached in bio #0 of cold log - f2fs_submit_page_write page #1 cached in bio #1 of

[f2fs-dev] [PATCH v2] Revert: "f2fs: check last page index in cached bio to decide submission"

2018-09-26 Thread Chao Yu
There is one case that we can leave bio in f2fs, result in hanging page writeback waiter. Thread AThread B - f2fs_write_cache_pages - f2fs_submit_page_write page #0 cached in bio #0 of cold log - f2fs_submit_page_write page #1 cached in bio #1 of warm log

[f2fs-dev] [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs.

2018-09-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200871 --- Comment #14 from Chao Yu (c...@kernel.org) --- (In reply to Stathis Maneas from comment #13) > Indeed, I can tell what is the block address in which the updated inode is > going to be stored using both dump.f2fs and the output of the SSA block

[f2fs-dev] [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs.

2018-09-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200871 --- Comment #13 from Stathis Maneas (sman...@cs.toronto.edu) --- Indeed, I can tell what is the block address in which the updated inode is going to be stored using both dump.f2fs and the output of the SSA blocks. Then, the file system gets initi

[f2fs-dev] [PATCH] Revert: "f2fs: check last page index in cached bio to decide submission"

2018-09-26 Thread Chao Yu
There is one case that we can leave bio in f2fs, result in hanging page writeback waiter. Thread AThread B - f2fs_write_cache_pages - f2fs_submit_page_write page #0 cached in bio #0 of cold log - f2fs_submit_page_write page #1 cached in bio #1 of warm log

[f2fs-dev] [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs.

2018-09-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200871 --- Comment #12 from Chao Yu (c...@kernel.org) --- (In reply to Stathis Maneas from comment #7) > - The block number (on disk) that will accommodate the newly updated inode > (after its mode has changed). In my case, this block number is equal to

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

2018-09-26 Thread Chao Yu
On 2018/9/26 9:10, Chao Yu wrote: > On 2018/9/26 8:18, Jaegeuk Kim wrote: >> On 09/21, Chao Yu wrote: >>> On 2018/9/21 5:46, Jaegeuk Kim wrote: On 09/20, Chao Yu wrote: > On 2018/9/19 1:56, Jaegeuk Kim wrote: >> This patch avoids BUG_ON when f2fs_get_meta_page_nofail got EIO during >>>