Re: [f2fs-dev] [bug report] f2fs: use rb_*_cached friends

2018-10-12 Thread Chao Yu
On 2018-10-12 22:18, Dan Carpenter wrote: > On Fri, Oct 12, 2018 at 10:00:20PM +0800, Chao Yu wrote: >> >> So finally, we will initialize leftmost's value here, anyway, I think there >> is Sorry, I mean 'there is no such place...' >> such place we use an uninitialized variable. >> >> BTW, do we

Re: [f2fs-dev] [bug report] f2fs: use rb_*_cached friends

2018-10-12 Thread Dan Carpenter
On Fri, Oct 12, 2018 at 10:00:20PM +0800, Chao Yu wrote: > > So finally, we will initialize leftmost's value here, anyway, I think there is > such place we use an uninitialized variable. > > BTW, do we have any chance to detect such case in smatch? > Thanks for taking a look at this! I think t

Re: [f2fs-dev] [bug report] f2fs: use rb_*_cached friends

2018-10-12 Thread Chao Yu
Hi Dan, Firstly, thanks for the report. :) On 2018-10-11 20:23, Dan Carpenter wrote: > Hello Chao Yu, > > The patch df634f444ee9: "f2fs: use rb_*_cached friends" from Oct 4, > 2018, leads to the following static checker warning: > > fs/f2fs/extent_cache.c:606 f2fs_update_extent_tree_range

[f2fs-dev] [PATCH v2] f2fs: cleanup dirty pages if recover failed

2018-10-12 Thread Sheng Yong
During recover, we will try to create new dentries for inodes with dentry_mark. But if the parent is missing (e.g. killed by fsck), recover will break. But those recovered dirty pages are not cleanup. This will hit f2fs_bug_on: [ 53.519566] F2FS-fs (loop0): Found nat_bits in checkpoint [ 53.53