Re: [f2fs-dev] [PATCH 2/2] f2fs-tools: create sparse file first before stat

2018-11-16 Thread Chao Yu
On 2018-11-16 14:06, Jaegeuk Kim wrote: > We must create a sparse file first before calling stat(). > > Fixes: eb9d8037ed3b ("f2fs-tools: avoid mounting f2fs if tools already open > the device") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH 1/2] f2fs-tools: show versions if exist

2018-11-16 Thread Chao Yu
On 2018-11-16 14:06, Jaegeuk Kim wrote: > If it's not defined, we need to skip to show the definition. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH] f2fs: check memory boundary by insane namelen

2018-11-16 Thread Chao Yu
On 2018-11-15 15:50, Jaegeuk Kim wrote: > If namelen is corrupted to have very long value, fill_dentries can copy > wrong memory area. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list

[f2fs-dev] [PATCH] f2fs: fix m_may_create to make OPU DIO write correctly

2018-11-16 Thread Jia Zhu
Commit 7bc0f46d418a ("f2fs: fix out-place-update DIO write") added a parameter map.m_may_create to replace @create for triggering OPU allocation correctly. But we find it is still in-place-update when used AndroBench to test this feature.In f2fs_map_blocks(), @create has been overwritten by the

Re: [f2fs-dev] [PATCH] f2fs: add bio cache for IPU

2018-11-16 Thread Chao Yu
Hi Jaegeuk, On 2018/11/15 16:32, Chao Yu wrote: > Hi Jaeguek, > > On 2018/11/15 15:52, Jaegeuk Kim wrote: >> Hi Chao, >> >> I suspect this brings a system stuck by missing bio being flushed. Please >> check >> the changes. > > Oh, let me check this patch. I found one corner case below, but