On 2018/11/27 11:52, Jaegeuk Kim wrote:
> On 11/27, Chao Yu wrote:
>> On 2018/11/27 8:04, Jaegeuk Kim wrote:
>>> On 11/26, Chao Yu wrote:
From: Chao Yu
As Michael reported:
after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
took quite a while and o
On 11/27, Chao Yu wrote:
> On 2018/11/27 8:04, Jaegeuk Kim wrote:
> > On 11/26, Chao Yu wrote:
> >> From: Chao Yu
> >>
> >> As Michael reported:
> >>
> >> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
> >> took quite a while and output ten-thousands instances of the follow
On Tue, Nov 27, 2018 at 11:12:40AM +0800, Chao Yu wrote:
> On 2018/11/27 8:22, PanBian wrote:
> > On Mon, Nov 26, 2018 at 07:07:08PM +0800, Chao Yu wrote:
> >> On 2018/11/26 18:28, PanBian wrote:
> >>> On Mon, Nov 26, 2018 at 05:13:53PM +0800, Chao Yu wrote:
> Hi Pan,
>
> On 2018/11/
Ping,
On 2018/11/20 19:58, Chao Yu wrote:
> On 2018-11-20 4:29, Jia Zhu wrote:
>> Previously, we added a parameter @map.m_may_create to trigger OPU
>> allocation and call f2fs_balance_fs() correctly.
>>
>> But in get_more_blocks(), @create has been overwritten by below code.
>> So the function f2f
On 2018/11/27 8:22, PanBian wrote:
> On Mon, Nov 26, 2018 at 07:07:08PM +0800, Chao Yu wrote:
>> On 2018/11/26 18:28, PanBian wrote:
>>> On Mon, Nov 26, 2018 at 05:13:53PM +0800, Chao Yu wrote:
Hi Pan,
On 2018/11/22 18:58, Pan Bian wrote:
> The function truncate_node frees the pa
On 2018/11/27 8:04, Jaegeuk Kim wrote:
> On 11/26, Chao Yu wrote:
>> From: Chao Yu
>>
>> As Michael reported:
>>
>> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
>> took quite a while and output ten-thousands instances of the following
>> line:
>>
>>> [FIX] (fsck_chk_inode
On Monday, November 26, 2018 11:06:15 PM IST Theodore Y. Ts'o wrote:
> On Mon, Nov 19, 2018 at 10:53:22AM +0530, Chandan Rajendra wrote:
> > This commit now uses IS_VERITY() macro to check if fsverity is
> > enabled on an inode.
> >
> > Signed-off-by: Chandan Rajendra
>
> This patch causes a mas
On 2018/11/27 8:30, Jaegeuk Kim wrote:
> On 11/26, Sahitya Tummala wrote:
>> When there is a failure in f2fs_fill_super() after/during
>> the recovery of fsync'd nodes, it frees the current sbi and
>> retries again. This time the mount is successful, but the files
>> that got recovered before retry
Hi Chandan,
On Mon, Nov 19, 2018 at 10:53:24AM +0530, Chandan Rajendra wrote:
> In order to have a common code base for fsverity "post read" processing
> for all filesystems which support per-file verity, this commit removes
> filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY) an
Hi Jia,
On 11/27, Jia Zhu wrote:
> Previously, we allocated a new block address for OPU mode in direct_IO.
>
> But the new address couldn't be assigned to @map->m_pblk correctly.
>
> This patch fix it.
>
> Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO in LFS mode')
I've mark
Hi Chandan,
On Mon, Nov 19, 2018 at 10:53:23AM +0530, Chandan Rajendra wrote:
> This commit now uses IS_VERITY() macro to check if fsverity is
> enabled on an inode.
>
> Signed-off-by: Chandan Rajendra
> ---
> fs/f2fs/file.c | 6 +++---
> fs/f2fs/inode.c | 4 +++-
> 2 files changed, 6 insertio
Hi Chandan,
On Mon, Nov 19, 2018 at 10:53:18AM +0530, Chandan Rajendra wrote:
> @@ -4724,7 +4724,7 @@ static bool ext4_should_use_dax(struct inode *inode)
> return false;
> if (ext4_has_inline_data(inode))
> return false;
> - if (ext4_encrypted_inode(inode))
>
On 11/26, Sahitya Tummala wrote:
> When there is a failure in f2fs_fill_super() after/during
> the recovery of fsync'd nodes, it frees the current sbi and
> retries again. This time the mount is successful, but the files
> that got recovered before retry, still holds the extent tree,
> whose extent
On Mon, Nov 26, 2018 at 12:36:15PM -0500, Theodore Y. Ts'o wrote:
> On Mon, Nov 19, 2018 at 10:53:22AM +0530, Chandan Rajendra wrote:
> > This commit now uses IS_VERITY() macro to check if fsverity is
> > enabled on an inode.
> >
> > Signed-off-by: Chandan Rajendra
>
> This patch causes a massiv
Hi Chandan,
On Mon, Nov 19, 2018 at 10:53:20AM +0530, Chandan Rajendra wrote:
> In order to have a common code base for fscrypt "post read" processing
> for all filesystems which support encryption, this commit removes
> filesystem specific build config option (e.g. CONFIG_EXT4_FS_ENCRYPTION)
> an
Hi Michael,
On 11/26, Michael Laß wrote:
> Hi,
>
> > Am 26.11.2018 um 15:09 schrieb Chao Yu :
> > On 2018-11-26 7:09, Michael Laß wrote:
> >> Hi,
> >>
> >> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
> >> took quite a while and output ten-thousands instances of the fol
Hi Chandan,
On Mon, Nov 19, 2018 at 10:53:21AM +0530, Chandan Rajendra wrote:
> Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds
> S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity
> information associated with it.
>
> Signed-off-by: Chandan Rajendra
> ---
> include/linu
On 11/26, Chao Yu wrote:
> From: Chao Yu
>
> As Michael reported:
>
> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
> took quite a while and output ten-thousands instances of the following
> line:
>
> > [FIX] (fsck_chk_inode_blk: 954) --> Regular: 0xXYZ reset i_gc_fail
Hi Ted,
On 11/26, Theodore Y. Ts'o wrote:
> On Sun, Nov 25, 2018 at 11:00:38PM -0500, Theodore Y. Ts'o wrote:
> >
> > It might be that the simplest way to solve things is to merge the f2fs
> > dev branch up to 79c66e75720c. This will have the net effect of
> > including the five patches listed a
On 11/23, Sheng Yong wrote:
> Hi, Jaegeuk and Chao,
>
> On 2018/11/15 15:50, Jaegeuk Kim wrote:
> > If namelen is corrupted to have very long value, fill_dentries can copy
> > wrong memory area.
> >
> Is there any scenario that could hit this corruption? Or this is triggered
> by fuzzing injectio
On Mon, Nov 19, 2018 at 10:53:22AM +0530, Chandan Rajendra wrote:
> This commit now uses IS_VERITY() macro to check if fsverity is
> enabled on an inode.
>
> Signed-off-by: Chandan Rajendra
This patch causes a massive number of fsverity tests. I suspect it's
due to a mismatch between the ext4's
On Sun, Nov 25, 2018 at 11:00:38PM -0500, Theodore Y. Ts'o wrote:
>
> It might be that the simplest way to solve things is to merge the f2fs
> dev branch up to 79c66e75720c. This will have the net effect of
> including the five patches listed above onto the fscrypt git tree. So
> long you don't
Hi,
> Am 26.11.2018 um 15:09 schrieb Chao Yu :
> On 2018-11-26 7:09, Michael Laß wrote:
>> Hi,
>>
>> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
>> took quite a while and output ten-thousands instances of the following
>> line:
>>
>>> [FIX] (fsck_chk_inode_blk: 954) -
From: Chao Yu
As Michael reported:
after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
took quite a while and output ten-thousands instances of the following
line:
> [FIX] (fsck_chk_inode_blk: 954) --> Regular: 0xXYZ reset i_gc_failures from
> 0x1 to 0x00
In old kernel, we
Hi Michael,
On 2018-11-26 7:09, Michael Laß wrote:
> Hi,
>
> after updating to f2fs-tools 1.12.0, a routine fsck of my file systems
> took quite a while and output ten-thousands instances of the following
> line:
>
>> [FIX] (fsck_chk_inode_blk: 954) --> Regular: 0xXYZ reset i_gc_failures from
Hi Perfect Gentleman,
On 2018-11-26 21:47, Perfect Gentleman wrote:
> Hi Chao
>
> With that patch fsck.f2fs works for RO-partition with -f option.
Thanks for your test. :)
Thanks,
>
> ~ $ sudo mount -o remount,ro /dev/sda1
>
> ~ $ sudo fsck.f2fs -a /dev/sda1
> Info: Fix the reported corru
Hi Chao
With that patch fsck.f2fs works for RO-partition with -f option.
~ $ sudo mount -o remount,ro /dev/sda1
~ $ sudo fsck.f2fs -a /dev/sda1
Info: Fix the reported corruption.
Info: Mounted device!
Info: Check FS only due to RO
Error: Failed to open the device!
~ $ sudo fsck.f2fs
From: Chao Yu
It needs to fix to handle error case of {c,m}alloc().
Signed-off-by: Chao Yu
---
fsck/dump.c | 4
fsck/fsck.c | 2 ++
fsck/mount.c | 13 +
lib/libf2fs.c| 4
lib/libf2fs_io.c | 4
5 files changed, 27 insertions(+)
diff --git a/fsck
Hi Perfect Gentleman,
On 2018-11-26 19:11, Perfect Gentleman wrote:
> Hi Chao
>
> What patch do you mean?
I mean
https://git.kernel.org/pub/scm/linux/kernel/git/chao/f2fs-tools.git/commit/?h=dev-test&id=a6160c3e21f43b89b49802cc4a956d1c4b65ae44
Thanks,
>
> Redards
>
> P.S. It's reply to all
Hi Chao
What patch do you mean?
Redards
P.S. It's reply to all :)
On 11/26/18 5:52 PM, Chao Yu wrote:
Hi Perfect Gentleman,
Thanks for the report.
On 2018/11/25 13:24, Perfect Gentleman wrote:
Hi f2fs-team,
there is bug: fsck.f2fs cannot check read-only filesystem. But 1.11.0
can do that.
On 2018/11/26 18:28, PanBian wrote:
> On Mon, Nov 26, 2018 at 05:13:53PM +0800, Chao Yu wrote:
>> Hi Pan,
>>
>> On 2018/11/22 18:58, Pan Bian wrote:
>>> The function truncate_node frees the page with f2fs_put_page. However,
>>> the page index is read after that. So, the patch reads the index before
To keep line with e2fsprogs, let's allow to fsck mounted image as
readonly w/ -f option.
Reported-by: Perfect Gentleman
Signed-off-by: Chao Yu
---
fsck/main.c | 1 +
include/f2fs_fs.h | 1 +
lib/libf2fs.c | 2 +-
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/fsck/main.
Hi Perfect Gentleman,
Thanks for the report.
On 2018/11/25 13:24, Perfect Gentleman wrote:
> Hi f2fs-team,
>
> there is bug: fsck.f2fs cannot check read-only filesystem. But 1.11.0
> can do that.
>
> fsck |Info: Fix the reported corruption.
> fsck |Info: Mounted devic
On Tue, Nov 27, 2018 at 02:32:32AM +0800, Jia Zhu wrote:
> Previously, we allocated a new block address for OPU mode in direct_IO.
>
> But the new address couldn't be assigned to @map->m_pblk correctly.
>
> This patch fix it.
>
> Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO i
On Mon, Nov 26, 2018 at 05:13:53PM +0800, Chao Yu wrote:
> Hi Pan,
>
> On 2018/11/22 18:58, Pan Bian wrote:
> > The function truncate_node frees the page with f2fs_put_page. However,
> > the page index is read after that. So, the patch reads the index before
> > freeing the page.
>
> I notice tha
Previously, we allocated a new block address for OPU mode in direct_IO.
But the new address couldn't be assigned to @map->m_pblk correctly.
This patch fix it.
Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO in LFS mode')
Signed-off-by: Jia Zhu
---
v2:
- update commit message.
On 2018/11/26 16:01, Sahitya Tummala wrote:
> Adjust the trace print in f2fs_get_victim() to cover GC done by
> F2FS_IOC_GARBAGE_COLLECT_RANGE.
>
> Signed-off-by: Sahitya Tummala
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux
On 2018/11/26 16:01, Sahitya Tummala wrote:
> Allow node type segments also to be GC'd via f2fs ioctl
> F2FS_IOC_GARBAGE_COLLECT_RANGE.
>
> Signed-off-by: Sahitya Tummala
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-de
Hi Pan,
On 2018/11/22 18:58, Pan Bian wrote:
> The function truncate_node frees the page with f2fs_put_page. However,
> the page index is read after that. So, the patch reads the index before
> freeing the page.
I notice that you found another use-after-free bug in ext4, out of
curiosity, I'd lik
Adjust the trace print in f2fs_get_victim() to cover GC done by
F2FS_IOC_GARBAGE_COLLECT_RANGE.
Signed-off-by: Sahitya Tummala
---
fs/f2fs/gc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index d720551..e4689c6 100644
--- a/fs/f2fs/gc.c
++
Allow node type segments also to be GC'd via f2fs ioctl
F2FS_IOC_GARBAGE_COLLECT_RANGE.
Signed-off-by: Sahitya Tummala
---
v3:
seperate the trace print change from this patch
fs/f2fs/gc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index a07
41 matches
Mail list logo
