Re: [f2fs-dev] [PATCH] f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG

2019-02-15 Thread Jaegeuk Kim
On 02/13, Chao Yu wrote: > On 2019/2/12 10:33, Jaegeuk Kim wrote: > > If we met this once, let fsck.f2fs clear this only. > > Note that, this addresses all the subtle fault injection test. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/checkpoint.c | 2 -- > > 1 file changed, 2 deletions

[f2fs-dev] [PATCH v2] vfs: don't decrement i_nlink in d_tmpfile

2019-02-15 Thread Darrick J. Wong
From: Darrick J. Wong d_tmpfile was introduced to instantiate an inode in the dentry cache as a temporary file. This helper decrements the inode's nlink count and dirties the inode, presumably so that filesystems could call new_inode to create a new inode with nlink == 1 and then call d_tmpfile

Re: [f2fs-dev] [RFC PATCH 0/6] Allow setting file birth time with utimensat()

2019-02-15 Thread Hans van Kranenburg
On 2/15/19 6:39 AM, Omar Sandoval wrote: > On Fri, Feb 15, 2019 at 01:57:39AM +, Hans van Kranenburg wrote: >> Hi, >> >> On 2/14/19 11:00 AM, Omar Sandoval wrote: >>> From: Omar Sandoval >>> >>> Since statx was added in 4.11, userspace has had an interface for >>> reading btime (file creation

[f2fs-dev] [Bug 202495] oops in fs/f2fs/checkpoint.c:150 f2fs_is_valid_blkaddr

2019-02-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202495 --- Comment #2 from JWalker (jw7...@gmail.com) --- Hi Chao, The kernal code was taken from the raspberry pi git repo, and then the incremental patches applied. Yes, fsck has been applied. Please see below the output of the both volumes. Please

Re: [f2fs-dev] [PATCH] vfs: don't decrement i_nlink in d_tmpfile

2019-02-15 Thread Darrick J. Wong
On Fri, Feb 15, 2019 at 10:04:12AM +0200, Amir Goldstein wrote: > On Fri, Feb 15, 2019 at 4:23 AM Darrick J. Wong > wrote: > > > > From: Darrick J. Wong > > > > d_tmpfile was introduced to instantiate an inode in the dentry cache as > > a temporary file. This helper decrements the inode's nlink

Re: [f2fs-dev] [RFC PATCH 0/6] Allow setting file birth time with utimensat()

2019-02-15 Thread David Disseldorp via Linux-f2fs-devel
On Thu, 14 Feb 2019 22:59:47 -0800, Omar Sandoval wrote: > On Fri, Feb 15, 2019 at 11:16:57AM +1100, Dave Chinner wrote: > > On Thu, Feb 14, 2019 at 03:14:29PM -0800, Omar Sandoval wrote: > > > On Fri, Feb 15, 2019 at 09:06:26AM +1100, Dave Chinner wrote: ... > > > > Inode create time is foren

Re: [f2fs-dev] [PATCH] f2fs: do not use mutex lock in atomic context

2019-02-15 Thread Chao Yu
On 2019/2/15 12:28, Ritesh Harjani wrote: > > On 2/14/2019 9:40 PM, Chao Yu wrote: >> On 2019-2-14 15:46, Sahitya Tummala wrote: >>> On Wed, Feb 13, 2019 at 11:25:31AM +0800, Chao Yu wrote: On 2019/2/4 16:06, Sahitya Tummala wrote: > Fix below warning coming because of using mutex lock in

Re: [f2fs-dev] Big Endian mount/fsck failing

2019-02-15 Thread Rosen Penev
On Fri, Feb 15, 2019 at 12:36 AM Chao Yu wrote: > > On 2019/2/6 7:14, Rosen Penev wrote: > > It errors on > > > > [ASSERT] (build_curseg:1529) array > > > > looking at the surrounding code, it's a malloc of size 144 that fails. > > No idea why. > > Could gdb work on your platform, maybe we can deb

Re: [f2fs-dev] Big Endian mount/fsck failing

2019-02-15 Thread Chao Yu
On 2019/2/6 7:14, Rosen Penev wrote: > It errors on > > [ASSERT] (build_curseg:1529) array > > looking at the surrounding code, it's a malloc of size 144 that fails. > No idea why. Could gdb work on your platform, maybe we can debug into it, and to check the real size we allocate, if it is as we

[f2fs-dev] [Bug 202495] oops in fs/f2fs/checkpoint.c:150 f2fs_is_valid_blkaddr

2019-02-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202495 Chao Yu (c...@kernel.org) changed: What|Removed |Added CC||c...@kernel.org --- Comment #

Re: [f2fs-dev] [PATCH] vfs: don't decrement i_nlink in d_tmpfile

2019-02-15 Thread Amir Goldstein
On Fri, Feb 15, 2019 at 4:23 AM Darrick J. Wong wrote: > > From: Darrick J. Wong > > d_tmpfile was introduced to instantiate an inode in the dentry cache as > a temporary file. This helper decrements the inode's nlink count and > dirties the inode, presumably so that filesystems could call new_i