Re: [f2fs-dev] [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs

2019-06-29 Thread Jan Kara
On Fri 28-06-19 11:34:31, Darrick J. Wong wrote: > From: Darrick J. Wong > > The DAX flag only applies to files and directories, so don't let it get > set for other types of files. > > Signed-off-by: Darrick J. Wong Looks good to me. You can add: Reviewed-by: Jan Kara

Re: [f2fs-dev] [PATCH v2] f2fs: allocate blocks for pinned file

2019-06-29 Thread Chao Yu
On 2019/6/28 23:36, Jaegeuk Kim wrote: > This patch allows fallocate to allocate physical blocks for pinned file. > > Signed-off-by: Jaegeuk Kim Looks good to me now. Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH 4/4] vfs: don't allow most setxattr to immutable files

2019-06-29 Thread Amir Goldstein
On Fri, Jun 28, 2019 at 9:37 PM Darrick J. Wong wrote: > > From: Darrick J. Wong > > The chattr manpage has this to say about immutable files: > > "A file with the 'i' attribute cannot be modified: it cannot be deleted > or renamed, no link can be created to this file, most of the file's > metada