On 2019/7/26 11:45, Jia-Ju Bai wrote:
> In fill_super() and put_super(), f2fs_destroy_stats() is called
> in prior to f2fs_destroy_segment_manager(), so if current
> sbi can still be visited in global stat list, SM_I(sbi) should be
> released yet.
> For this reason, SM_I(sbi) does not need to be c
In fill_super() and put_super(), f2fs_destroy_stats() is called
in prior to f2fs_destroy_segment_manager(), so if current
sbi can still be visited in global stat list, SM_I(sbi) should be
released yet.
For this reason, SM_I(sbi) does not need to be checked in
update_general_status().
Thank Chao Yu
On 2019/7/26 11:19, Chao Yu wrote:
Hi Jiaju,
Thanks for the report, I checked the code, and found it doesn't need to check
SM_I(sbi) pointer, this is because in fill_super() and put_super(), we will call
f2fs_destroy_stats() in prior to f2fs_destroy_segment_manager(), so if current
sbi can st
Hi Jiaju,
Thanks for the report, I checked the code, and found it doesn't need to check
SM_I(sbi) pointer, this is because in fill_super() and put_super(), we will call
f2fs_destroy_stats() in prior to f2fs_destroy_segment_manager(), so if current
sbi can still be visited in global stat list, SM_I
Hi Jeff,
I checked the code, found one suspicious place as below:
- f2fs_build_node_manager
- init_node_manager
- __get_nat_bitmaps
- disable_nat_bits(, true)
disable_nat_bits(.., lock)
{
...
if (lock)
spin_lock_irqsave(&sbi->cp_lock, flags);
__clear_ckpt_fl
From: Chao Yu
Atomic write needs page cache to cache data of transaction,
direct IO should never be allowed in atomic write, detect
and deny it when open atomic write file.
Signed-off-by: Gao Xiang
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
In update_general_status(), there are two if statements to
check whether SM_I(sbi) is NULL:
LINE 70: if (SM_I(sbi) && SM_I(sbi)->fcc_info)
LINE 78: if (SM_I(sbi) && SM_I(sbi)->dcc_info)
When SM_I(sbi) is NULL, it is used at some places, such as:
LINE 88: reserved_segments(sbi)
With quota_ino feature on, generic/232 reports an inconsistence issue
on the image.
The root cause is that the testcase tries to:
- use quotactl to shutdown journalled quota based on sysfile;
- and then use quotactl to enable/turn on quota based on specific file
(aquota.user or aquota.group).
Eve
