Re: [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-07-30 Thread OGAWA Hirofumi
Deepa Dinamani writes: > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 1e08bd54c5fb..53bb7c6bf993 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct > timespec64 *now, int flags) > inode->i_atime = (struct

Re: [f2fs-dev] [PATCH] f2fs: Fix indefinite loop in f2fs_gc()

2019-07-30 Thread Chao Yu
Hi Sahitya, On 2019/7/30 12:36, Sahitya Tummala wrote: > Hi Chao, > > On Tue, Jul 30, 2019 at 12:00:45AM +0800, Chao Yu wrote: >> Hi Sahitya, >> >> On 2019-7-29 13:20, Sahitya Tummala wrote: >>> Policy - foreground GC, LFS mode and greedy GC mode. >>> >>> Under this policy, f2fs_gc() loops foreve

Re: [f2fs-dev] [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-07-30 Thread Deepa Dinamani
On Tue, Jul 30, 2019 at 1:27 AM OGAWA Hirofumi wrote: > > Deepa Dinamani writes: > > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > > index 1e08bd54c5fb..53bb7c6bf993 100644 > > --- a/fs/fat/misc.c > > +++ b/fs/fat/misc.c > > @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct

[GIT PULL] f2fs-for-5.4-rc3

2019-07-30 Thread Jaegeuk Kim
Hi Linus, Could you please merge this to address some fixes introduced in 5.4-rc1? Thanks, The following changes since commit 964a4eacef67503a1154f7e0a75f52fbdce52022: Merge tag 'dlm-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm (2019-07-12 17:37:53 -0700) are av

[f2fs-dev] [PATCH v12 2/5] Add flags option to get xattr method paired to __vfs_getxattr

2019-07-30 Thread Mark Salyzyn via Linux-f2fs-devel
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is set in the __vfs_getxattr path. This handles the case of a union filesystem driver that is being requested by the security layer to report back the data that is the target label

Re: [PATCH v2] f2fs: separate NOCoW and pinfile semantics

2019-07-30 Thread Jaegeuk Kim
On 07/29, Chao Yu wrote: > On 2019/7/29 13:57, Jaegeuk Kim wrote: > > On 07/23, Chao Yu wrote: > >> On 2019/7/23 10:36, Jaegeuk Kim wrote: > >>> On 07/19, Chao Yu wrote: > Pinning a file is heavy, because skipping pinned files make GC > running with heavy load or no effect. > >>> > >>> Pi

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-30 Thread Jaegeuk Kim
On 07/29, Ju Hyung Park wrote: > Hi Chao and Jaegeuk, > > I have no idea how that patch got merged. > > We(me and Yaro) were supposed to work on doing some finishing touches > to the patch before sending it to upstream. > > I'll personally check with Yaro. > > Jaegeuk, please remove the patch.

Re: [GIT PULL] f2fs-for-5.4-rc3

2019-07-30 Thread pr-tracker-bot
The pull request you sent on Tue, 30 Jul 2019 10:46:53 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-for-5.4-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0572d7668a58794059030b88945f78dfb94e3325 Thank you! -- Deet-doot-do

Re: [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-07-30 Thread Anton Altaparmakov
Hi Deepa, > On 30 Jul 2019, at 18:26, Deepa Dinamani wrote: > > On Tue, Jul 30, 2019 at 1:27 AM OGAWA Hirofumi > wrote: >> >> Deepa Dinamani writes: >> >>> diff --git a/fs/fat/misc.c b/fs/fat/misc.c >>> index 1e08bd54c5fb..53bb7c6bf993 100644 >>> --- a/fs/fat/misc.c >>> +++ b/fs/fat/misc.c >

Re: [PATCH v3 RESEND] f2fs: introduce sb.required_features to store incompatible features

2019-07-30 Thread Jaegeuk Kim
On 07/29, Chao Yu wrote: > From: Chao Yu > > Later after this patch was merged, all new incompatible feature's > bit should be added into sb.required_features field, and define new > feature function with F2FS_INCOMPAT_FEATURE_FUNCS() macro. > > Then during mount, we will do sanity check with en

Re: [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-07-30 Thread Deepa Dinamani
On Tue, Jul 30, 2019 at 3:28 PM Anton Altaparmakov wrote: > > Hi Deepa, > > > On 30 Jul 2019, at 18:26, Deepa Dinamani wrote: > > > > On Tue, Jul 30, 2019 at 1:27 AM OGAWA Hirofumi > > wrote: > >> > >> Deepa Dinamani writes: > >> > >>> diff --git a/fs/fat/misc.c b/fs/fat/misc.c > >>> index 1e08

[f2fs-dev] [PATCH] f2fs: fix memory leak in build_directory

2019-07-30 Thread Xiaojun Wang
This patch fix bug that variable dentries going out of scope leaks the storage it points to. Signed-off-by: Xiaojun Wang --- fsck/sload.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fsck/sload.c b/fsck/sload.c index f5a4651..e5de2e1 100644 --- a/fsck/sload.c +++ b/f

Re: [f2fs-dev] [PATCH] f2fs: Fix indefinite loop in f2fs_gc()

2019-07-30 Thread Sahitya Tummala
Hi Chao, On Tue, Jul 30, 2019 at 08:35:46PM +0800, Chao Yu wrote: > Hi Sahitya, > > On 2019/7/30 12:36, Sahitya Tummala wrote: > > Hi Chao, > > > > On Tue, Jul 30, 2019 at 12:00:45AM +0800, Chao Yu wrote: > >> Hi Sahitya, > >> > >> On 2019-7-29 13:20, Sahitya Tummala wrote: > >>> Policy - foregr