Re: [f2fs-dev] f2fs: dirty memory increasing during gc_urgent

2019-08-14 Thread Chao Yu
Hi Ju Hyung, On 2019/8/14 22:15, Ju Hyung Park wrote: > Hi. > > I'm reporting some strangeness with gc_urgent. > > When running gc_urgent, I can see that dirty memory written in > /proc/meminfo continuously getting increased until GC cannot find any > more segments to clean. > > I thought FG_GC

Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add VM disk files to hot data types

2019-08-14 Thread Chao Yu
Hi Ju Hyung, On 2019/8/14 17:22, Ju Hyung Park wrote: > Hi Chao, > > You're right and Android will never use those types. > > But then again, what's the point of separating the list? I'm just thinking to use extension list space more efficiently to avoid free slot exhaustion. And in android, l

Re: [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold data types

2019-08-14 Thread Chao Yu
Hi Ju Hyung, On 2019/8/14 22:10, Ju Hyung Park wrote: > Hi Chao, > > /data/log isn't even here. > I think it must be specific to EMUI. Alright, at least in EMUI, it looks not proper to me to set cold flag on zip file according to result of hot/cold separation investigation recently. IMO, it wil

Re: [f2fs-dev] [PATCH v8 00/20] fscrypt: key management improvements

2019-08-14 Thread Eric Biggers
On Mon, Aug 05, 2019 at 09:25:01AM -0700, Eric Biggers wrote: > Hello, > > [Note: I'd like to apply this for v5.4. Additional review is greatly > appreciated, especially of the API before it's set in stone. Thanks!] > > This patchset makes major improvements to how keys are added, removed, > a

Re: [f2fs-dev] [PATCH v8 10/20] fscrypt: add FS_IOC_REMOVE_ENCRYPTION_KEY ioctl

2019-08-14 Thread Eric Biggers
On Mon, Aug 12, 2019 at 08:06:44PM -0400, Theodore Y. Ts'o wrote: > > + /* Some inodes still reference this key; try to evict them. */ > > + if (try_to_lock_encrypted_files(sb, mk) != 0) > > + status_flags |= > > + FSCRYPT_KEY_REMOVAL_

[f2fs-dev] [PATCH v3] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-14 Thread Mark Salyzyn via Linux-f2fs-devel
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path. This handles the case of a union filesystem driver that is being requested by the security layer to report back the xattr data. Fo

[f2fs-dev] [PATCH v5 04/18] fs: compat_ioctl: move FITRIM emulation into file systems

2019-08-14 Thread Arnd Bergmann
Remove the special case for FITRIM, and make file systems handle that like all other ioctl commands with their own handlers. Signed-off-by: Arnd Bergmann --- fs/compat_ioctl.c | 2 -- fs/ecryptfs/file.c | 1 + fs/ext4/ioctl.c| 1 + fs/f2fs/file.c | 1 + fs/hpfs/dir.c | 1 + fs/hpfs

[f2fs-dev] [PATCH v5 00/18] compat_ioctl.c removal, part 2/3

2019-08-14 Thread Arnd Bergmann
This is a follow-up to part 1/3 that I posted after -rc2. I hope these are still largely uncontroversial changes, and I would like to get them into linux-5.4. Part 1 was in https://lore.kernel.org/lkml/capcyv4i_nhzv155rcgnaq189aq2lfd2g8pa1d5nbzqo9e_u...@mail.gmail.com/ Part 3 will be one kernel

Re: [f2fs-dev] [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-14 Thread Mark Salyzyn via Linux-f2fs-devel
On 8/14/19 4:00 AM, Jan Kara wrote: On Tue 13-08-19 07:55:06, Mark Salyzyn wrote: ... diff --git a/fs/xattr.c b/fs/xattr.c index 90dd78f0eb27..71f887518d6f 100644 --- a/fs/xattr.c +++ b/fs/xattr.c ... ssize_t __vfs_getxattr(struct dentry *dentry, struct inode *inode, const char *name, -

[f2fs-dev] f2fs: dirty memory increasing during gc_urgent

2019-08-14 Thread Ju Hyung Park
Hi. I'm reporting some strangeness with gc_urgent. When running gc_urgent, I can see that dirty memory written in /proc/meminfo continuously getting increased until GC cannot find any more segments to clean. I thought FG_GC are flushed. And after GC ends, if I do `sync` and run gc_urgent again,

Re: [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold data types

2019-08-14 Thread Ju Hyung Park
Hi Chao, /data/log isn't even here. I think it must be specific to EMUI. Thanks. On Wed, Aug 14, 2019 at 6:48 PM Chao Yu wrote: > > Hi Ju Hyung, > > On 2019/8/14 17:20, Ju Hyung Park wrote: > > Hi Chao, > > > > On Wed, Aug 14, 2019 at 10:47 AM Chao Yu wrote: > >> In android, as I see, most zip

Re: [f2fs-dev] [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-14 Thread Jan Kara
On Tue 13-08-19 07:55:06, Mark Salyzyn wrote: ... > diff --git a/fs/xattr.c b/fs/xattr.c > index 90dd78f0eb27..71f887518d6f 100644 > --- a/fs/xattr.c > +++ b/fs/xattr.c ... > ssize_t > __vfs_getxattr(struct dentry *dentry, struct inode *inode, const char *name, > -void *value, size_t

Re: [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold data types

2019-08-14 Thread Chao Yu
Hi Ju Hyung, On 2019/8/14 17:20, Ju Hyung Park wrote: > Hi Chao, > > On Wed, Aug 14, 2019 at 10:47 AM Chao Yu wrote: >> In android, as I see, most zip file is small-sized log type, and will be >> removed >> after a roll-back, such as: >> >> time1: create log1.zip >> time2: create log2.zip >> ti

Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add VM disk files to hot data types

2019-08-14 Thread Ju Hyung Park
Hi Chao, You're right and Android will never use those types. But then again, what's the point of separating the list? I haven't encountered an Android user or an OEM that wants to customize this list by passing an argument to mkfs.f2fs. If an OEM want to customize this list, directly modifying

Re: [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold data types

2019-08-14 Thread Ju Hyung Park
Hi Chao, On Wed, Aug 14, 2019 at 10:47 AM Chao Yu wrote: > In android, as I see, most zip file is small-sized log type, and will be > removed > after a roll-back, such as: > > time1: create log1.zip > time2: create log2.zip > time3: create log3.zip > time4: remove log1.zip, rename log2.zip -> lo

[PATCH] f2fs-tools: fix to skip block allocation for fsynced data

2019-08-14 Thread Chao Yu
Previously, we don't allow block allocation on unclean umounted image, result in failing to repair quota system file. In this patch, we port most recovery codes from kernel to userspace tools, so that on unclean image, during fsck initialization, we will record all data/node block address we may r

[f2fs-dev] [PATCH v2 1/4] fsck.f2fs: fix to recover out-of-border inline size

2019-08-14 Thread Chao Yu
It tries to let fsck be noticed wrong inline size, and do the fix. Signed-off-by: Chao Yu --- v2: - skip normal case if i_size equals to zero. fsck/fsck.c | 8 1 file changed, 8 insertions(+) diff --git a/fsck/fsck.c b/fsck/fsck.c index d53317c..baeca88 100644 --- a/fsck/fsck.c +++ b/f