Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

On Fri, Aug 23, 2019 at 01:20:37PM +0900, boojin.kim wrote: > > If yes, I think the following API needs to be added to skcipher: > - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO. > - _mergeable(): Block layer checks if two BIOs have the same cipher. > - _get(): Storage driver

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

On Wed, Aug 21, 2019 at 17:19:41PM +0900, Herbert Xu wrote: > On Wed, Aug 21, 2019 at 04:57:41PM +0900, boojin.kim wrote: > > > > Can you tell me which patch you mentioned? Is this? > > https://patches.linaro.org/project/linux-crypto/list/?series=22762 > > > > Yes this is the one. > > Cheers, I

Re: [f2fs-dev] [PATCH 1/2] f2fs: introduce {page, io}_is_mergeable() for readability

On 2019/7/12 16:55, Chao Yu wrote: > Wrap merge condition into function for readability, no logic change. > > Signed-off-by: Chao Yu > --- > v2: remove bio validation check in page_is_mergeable(). > fs/f2fs/data.c | 40 +--- > 1 file changed, 33

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

On Wed, Aug 21, 2019 at 5:10 AM Jens Axboe wrote: > > On 8/21/19 12:42 AM, boojin.kim wrote: > > This patch supports crypto information to be maintained via BIO > > and passed to the storage driver. > > > > To do this, 'bi_aux_private', 'REQ_CYPTE' and 'bi_dun' are added > > to the block layer. >

Re: [f2fs-dev] [PATCH v2] f2fs: fix to writeout dirty inode during node flush

On 2019/8/23 5:49, Eric Biggers wrote: > Thanks, the test passes for me with this patch applied. > > Tested-by: Eric Biggers > . Thanks for the test. Thanks,

Re: [f2fs-dev] f2fs_symlink bug

On 2019/8/23 3:49, Jaegeuk Kim wrote: > On 08/21, Chao Yu wrote: >> Ping, >> >> On 2019/8/12 20:01, Chao Yu wrote: >>> Hi Jaegeuk, >>> >>> In por_fsstress testcase, fsck reports below inconsistent status, I found >>> one >>> path can cause this case. >>> >>> [FIX] (fsck_chk_inode_blk:1002) -->

Re: [f2fs-dev] [PATCH v2] f2fs: allocate memory in batch in build_sit_info()

On 2019/8/23 1:47, Jaegeuk Kim wrote: > On 08/20, Jaegeuk Kim wrote: >> On 08/20, Chao Yu wrote: >>> On 2019/8/20 4:20, Jaegeuk Kim wrote: On 07/26, Chao Yu wrote: > build_sit_info() allocate all bitmaps for each segment one by one, > it's quite low efficiency, this pach changes to

Re: [f2fs-dev] [PATCH 1/9] crypt: Add diskcipher

On Wed, 22 Aug 2019 at 17:37, Krzysztof Kozlowski wrote: > > Your patch looks corrupted - wrapped by mailer. The easiest way > usually is to use git format-patch and git send-email - then you do > not have to worry about formatting etc. > > Best regards, > Krzysztof I'm using outlook instead of

Re: [f2fs-dev] [PATCH v2] f2fs: fix to writeout dirty inode during node flush

On Thu, Aug 22, 2019 at 08:17:56PM +0800, Chao Yu wrote: > As Eric reported: > > On xfstest generic/204 on f2fs, I'm getting a kernel BUG. > > allocate_segment_by_default+0x9d/0x100 [f2fs] > f2fs_allocate_data_block+0x3c0/0x5c0 [f2fs] > do_write_page+0x62/0x110 [f2fs] >

Re: [f2fs-dev] f2fs_symlink bug

On 08/21, Chao Yu wrote: > Ping, > > On 2019/8/12 20:01, Chao Yu wrote: > > Hi Jaegeuk, > > > > In por_fsstress testcase, fsck reports below inconsistent status, I found > > one > > path can cause this case. > > > > [FIX] (fsck_chk_inode_blk:1002) --> Symlink: recover 0x1425 with > >

Re: [f2fs-dev] [PATCH v2] f2fs: allocate memory in batch in build_sit_info()

On 08/20, Jaegeuk Kim wrote: > On 08/20, Chao Yu wrote: > > On 2019/8/20 4:20, Jaegeuk Kim wrote: > > > On 07/26, Chao Yu wrote: > > >> build_sit_info() allocate all bitmaps for each segment one by one, > > >> it's quite low efficiency, this pach changes to allocate large > > >> continuous memory

[PATCH v2] f2fs: fix to writeout dirty inode during node flush

As Eric reported: On xfstest generic/204 on f2fs, I'm getting a kernel BUG. allocate_segment_by_default+0x9d/0x100 [f2fs] f2fs_allocate_data_block+0x3c0/0x5c0 [f2fs] do_write_page+0x62/0x110 [f2fs] f2fs_do_write_node_page+0x2b/0xa0 [f2fs] __write_node_page+0x2ec/0x590 [f2fs]

Re: [f2fs-dev] kernel BUG at fs/f2fs/segment.c:2391 during xfstest generic/204

On 2019/8/22 16:29, Chao Yu wrote: > Hi Eric, > > I've figured out one patch for this issue, could you have a try? Could you only check 204? I just hit deadlock in 051, not sure it is caused by this patch. > > Thanks, > > On 2019/8/19 0:03, Eric Biggers wrote: >> On Fri, Aug 16, 2019 at

Re: [f2fs-dev] [PATCH 1/9] crypt: Add diskcipher

On Wed, 21 Aug 2019 at 08:42, boojin.kim wrote: > > Diskcipher supports cryptographic operations of inline crypto engines like > FMP. Inline crypto engine refers to hardware and solutions implemented > to encrypt data stored in storage device. > > When encrypting using the FMP, Additional control

Re: [f2fs-dev] kernel BUG at fs/f2fs/segment.c:2391 during xfstest generic/204

Hi Eric, I've figured out one patch for this issue, could you have a try? Thanks, On 2019/8/19 0:03, Eric Biggers wrote: > On Fri, Aug 16, 2019 at 04:37:35PM +0800, Chao Yu wrote: >> Hi Eric, >> >> Sorry for late reply... >> >> I only hit ENOSPC error: >> >> QA output created by 204 >> line 82:

[f2fs-dev] [PATCH] f2fs: fix to writeout dirty inode during node flush

As Eric reported: On xfstest generic/204 on f2fs, I'm getting a kernel BUG. allocate_segment_by_default+0x9d/0x100 [f2fs] f2fs_allocate_data_block+0x3c0/0x5c0 [f2fs] do_write_page+0x62/0x110 [f2fs] f2fs_do_write_node_page+0x2b/0xa0 [f2fs] __write_node_page+0x2ec/0x590 [f2fs]