Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread boojin.kim
On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Hi Boojin, > > I think the important thing to realize here is that there are a large > number of hardware devices for which the keyslot manager *is* needed. > And from the upstream kernel's perspective, supporting two different >

[f2fs-dev] [Bug 204137] F2FS: kernel BUG at fs/f2fs/segment.c:2375!

2019-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204137 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |ASSIGNED CC|

Re: [f2fs-dev] [PATCH] Check all the data segments against all node ones.

2019-08-27 Thread Chao Yu
Hi Surbhi, I guess this patch is okay, please wait Jaegeuk to merge it. On 2019/8/24 17:48, Chao Yu wrote: > On 2019-8-24 6:40, Surbhi Palande wrote: >> As a part of the sanity checking while mounting, distinct segment number >> assignment to data and node segments is verified. Fixing a small

Re: [f2fs-dev] [PATCH v4 5/8] scsi: ufs: UFS crypto API

2019-08-27 Thread Eric Biggers
On Wed, Aug 21, 2019 at 12:57:11AM -0700, Satya Tangirala wrote: > +static int ufshcd_crypto_cap_find(void *hba_p, > +enum blk_crypto_mode_num crypto_mode, > +unsigned int data_unit_size) > +{ > + struct ufs_hba *hba = hba_p; > + enum

Re: [f2fs-dev] [PATCH v4 3/8] block: blk-crypto for Inline Encryption

2019-08-27 Thread Eric Biggers
On Wed, Aug 21, 2019 at 12:57:09AM -0700, Satya Tangirala wrote: > diff --git a/block/blk-crypto.c b/block/blk-crypto.c > new file mode 100644 > index ..c8f06264a0f5 > --- /dev/null > +++ b/block/blk-crypto.c > @@ -0,0 +1,737 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + *

Re: [f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread Darrick J. Wong
On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: > Replace arguments for get and set xattr methods, and __vfs_getxattr > and __vfs_setaxtr functions with a reference to the following now > common argument structure: > > struct xattr_gs_args { > struct dentry *dentry; >

Re: [f2fs-dev] [PATCH v4 1/8] block: Keyslot Manager for Inline Encryption

2019-08-27 Thread Eric Biggers
Hi Satya, a few more minor comments: On Wed, Aug 21, 2019 at 12:57:07AM -0700, Satya Tangirala wrote: > +/** > + * keyslot_manager_create() - Create a keyslot manager > + * @num_slots: The number of key slots to manage. > + * @ksm_ll_ops: The struct keyslot_mgmt_ll_ops for the device that this >

Re: [f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread David Sterba
On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: > Replace arguments for get and set xattr methods, and __vfs_getxattr > and __vfs_setaxtr functions with a reference to the following now > common argument structure: > > struct xattr_gs_args { > struct dentry *dentry; >

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread Theodore Y. Ts'o
On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Dear Satya. > Keyslot manager is a good solution for ICE. And probably no issue for FMP. > But, I think it's complicated for FMP because FMP doesn't need > any keyslot control. Hi Boojin, I think the important thing to realize here

Re: [f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread Jeff Layton
On Tue, 2019-08-27 at 08:05 -0700, Mark Salyzyn wrote: > Replace arguments for get and set xattr methods, and __vfs_getxattr > and __vfs_setaxtr functions with a reference to the following now > common argument structure: > > struct xattr_gs_args { > struct dentry *dentry; > struct

[f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread Mark Salyzyn via Linux-f2fs-devel
Replace arguments for get and set xattr methods, and __vfs_getxattr and __vfs_setaxtr functions with a reference to the following now common argument structure: struct xattr_gs_args { struct dentry *dentry; struct inode *inode; const char *name; union {

Re: [f2fs-dev] [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread Mark Salyzyn via Linux-f2fs-devel
On 8/27/19 7:19 AM, Jan Kara wrote: On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking index 204dd3ea36bb..e2687f21c7d6 100644 --- a/Documentation/filesystems/Locking +++ b/Documentation/filesystems/Locking @@

Re: [f2fs-dev] [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread Jan Kara
On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: > diff --git a/Documentation/filesystems/Locking > b/Documentation/filesystems/Locking > index 204dd3ea36bb..e2687f21c7d6 100644 > --- a/Documentation/filesystems/Locking > +++ b/Documentation/filesystems/Locking > @@ -101,12 +101,10 @@ of the locking

[PATCH 1/2] f2fs: introduce get_available_block_count() for cleanup

2019-08-27 Thread Chao Yu
There are very similar codes in inc_valid_block_count() and inc_valid_node_count() which is used for available user block count calculation. This patch introduces a new helper get_available_block_count() to include those common codes, and used it instead for cleanup. Signed-off-by: Chao Yu ---

[PATCH 2/2] f2fs: fix to reserve space for IO align feature

2019-08-27 Thread Chao Yu
https://bugzilla.kernel.org/show_bug.cgi?id=204137 With below script, we will hit panic during new segment allocation: DISK=bingo.img MOUNT_DIR=/mnt/f2fs dd if=/dev/zero of=$DISK bs=1M count=105 mkfs.f2fe -a 1 -o 19 -t 1 -z 1 -f -q $DISK mount -t f2fs $DISK $MOUNT_DIR -o

[PATCH] f2fs: add missing documents of reserve_root/resuid/resgid

2019-08-27 Thread Chao Yu
Add missing documents. Fixes: 7e65be49ed94f ("f2fs: add reserved blocks for root user") Fixes: 7c2e59632b846 ("f2fs: add resgid and resuid to reserve root blocks") Signed-off-by: Chao Yu --- Documentation/filesystems/f2fs.txt | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread boojin.kim
On Wed, Aug 21, 2019 at 5:10 AM Satya Tangirala wrote: > > Hi Boojin, > > We're very keen to make sure that our approach to inline encryption can > work with diverse hardware, including Samsung's FMP hardware; if you > can see any issues with using our approach with your hardware please > let us