Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static

2019-08-30 Thread zhengbin (A)
On 2019/8/31 10:30, Chao Yu wrote: > Hi Zheng, > > Thanks for the patch, the original patch is still in dev branch, I suggest we > can merge it into original patch, do you mind that? Agree with it > > Thanks, > > On 2019/8/31 9:46, zhengbin wrote: >> Fix sparse warning: >> >> fs/f2fs/dir.c:142:6:

Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static

2019-08-30 Thread Chao Yu
Hi Zheng, Thanks for the patch, the original patch is still in dev branch, I suggest we can merge it into original patch, do you mind that? Thanks, On 2019/8/31 9:46, zhengbin wrote: > Fix sparse warning: > > fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not >

Re: [f2fs-dev] [PATCH] f2fs: convert inline_data in prior to i_size_write

2019-08-30 Thread Chao Yu
On 2019/8/30 23:34, Jaegeuk Kim wrote: > This can guarantee inline_data has smaller i_size. So I guess "f2fs: fix to avoid corruption during inline conversion" didn't fix such corruption right, I guess checkpoint & SPO before i_size recovery will cause this issue? err =

[f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static

2019-08-30 Thread zhengbin
Fix sparse warning: fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: zhengbin --- fs/f2fs/dir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/dir.c

Re: [f2fs-dev] [PATCH] f2fs: fix flushing node pages when checkpoint is disabled

2019-08-30 Thread Chao Yu
On 2019/8/30 0:50, Jaegeuk Kim wrote: > This patch fixes skipping node page writes when checkpoint is disabled. > In this period, we can't rely on checkpoint to flush node pages. > > Fixes: fd8c8caf7e7c ("f2fs: let checkpoint flush dnode page of regular") > Fixes: 4354994f097d ("f2fs: checkpoint

Re: [f2fs-dev] [GIT PULL RESEND] vfs: Add support for timestamp limits

2019-08-30 Thread Arnd Bergmann
On Fri, Aug 30, 2019 at 5:48 PM Deepa Dinamani wrote: > > [resending, rebased onto linux v5.3-rc6, and dropped orangefs patch from the > series] > > Hi Al, Arnd, > > This is a pull request for filling in min and max timestamps for filesystems. > I've added all the acks, and dropped the adfs

[f2fs-dev] [SPAM] ***SPAM*** Security Keeping Code of Your Package(ENS/0148/U)

2019-08-30 Thread Mrs . Elspeth Norman Scoular postmaster
My Dear, I am sure this mail would be coming to you as a surprise since we have never met before and you would also be asking why I have decided to chose you amongst the numerous internet users in the world, precisely I cannot say why I have chosen you but do not be worried for I come in

[f2fs-dev] [GIT PULL RESEND] vfs: Add support for timestamp limits

2019-08-30 Thread Deepa Dinamani
[resending, rebased onto linux v5.3-rc6, and dropped orangefs patch from the series] Hi Al, Arnd, This is a pull request for filling in min and max timestamps for filesystems. I've added all the acks, and dropped the adfs patch. That will be merged through Russell's tree. Dropped orangefs

[PATCH] f2fs: convert inline_data in prior to i_size_write

2019-08-30 Thread Jaegeuk Kim
This can guarantee inline_data has smaller i_size. Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 08caaead6f16..a43193dd27cb 100644 --- a/fs/f2fs/file.c +++

Re: [f2fs-dev] [GIT PULL] vfs: Add support for timestamp limits

2019-08-30 Thread Arnd Bergmann
On Fri, Aug 30, 2019 at 4:02 AM Deepa Dinamani wrote: > On Thu, Aug 29, 2019 at 6:20 PM Mike Marshall wrote: > > > > Hi Deepa... > > > > I installed this patch series on top of Linux 5.3-rc6 and ran xfstests > > on orangefs and got a regression... generic/258 failed > > with: "Timestamp

[f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-08-30 Thread Shin'ichiro Kawasaki
On sudden f2fs shutdown, zoned block device status and f2fs current segment positions in meta data can be inconsistent. When f2fs shutdown happens before write operations completes, write pointers of zoned block devices can go further but f2fs meta data keeps current segments at positions before

[f2fs-dev] [PATCH v4 0/2] fsck: Check write pointers of zoned block devices

2019-08-30 Thread Shin'ichiro Kawasaki
On sudden f2fs shutdown, zoned block device status and f2fs meta data can be inconsistent. When f2fs shutdown happens during write operations, write pointers on the device go forward but the f2fs meta data does not reflect write pointer progress. This inconsistency will eventually causes

[f2fs-dev] [PATCH v4 1/2] libf2fs_zoned: Introduce f2fs_report_zones() helper function

2019-08-30 Thread Shin'ichiro Kawasaki
To prepare for write pointer consistency check by fsck, add f2fs_report_zones() helper function which calls REPORT ZONE command to get write pointer status. The function is added to lib/libf2fs_zoned which gathers zoned block device related functions. To check write pointer consistency with f2fs

Re: [f2fs-dev] [PATCH v2 4/4] fsck.f2fs: Check write pointer consistency with valid blocks count

2019-08-30 Thread Shinichiro Kawasaki
On Aug 29, 2019 / 22:42, Chao Yu wrote: > On 2019-8-28 19:53, Shinichiro Kawasaki wrote: > > On Aug 27, 2019 / 10:25, Chao Yu wrote: > >> On 2019/8/21 12:48, Shin'ichiro Kawasaki wrote: > >>> When sudden f2fs shutdown happens on zoned block devices, write > >>> pointers can be inconsistent with

Re: [f2fs-dev] [PATCH v3 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-08-30 Thread Shinichiro Kawasaki
On Aug 29, 2019 / 22:49, Chao Yu wrote: > On 2019-8-29 14:35, Shin'ichiro Kawasaki wrote: > > On sudden f2fs shutdown, zoned block device status and f2fs current > > segment positions in meta data can be inconsistent. When f2fs shutdown > > happens before write operations completes, write pointers