Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Chao Yu
Hello, Thanks for the report, I've fixed this. Thanks, On 2019/11/2 22:17, kbuild test robot wrote: > Hi Chao, > > I love your patch! Yet something to improve: > > [auto build test ERROR on f2fs/dev-test] > [cannot apply to v5.4-rc5 next-20191031] > [if your patch is applied to the wrong git t

[f2fs-dev] fsstress with RENAME_EXCHANGE causing filesystem corruption

2019-11-04 Thread Eric Biggers
RENAME_EXCHANGE support was just added to fsstress in xfstests: commit 65dfd40a97b6bbbd2a22538977bab355c5bc0f06 Author: kaixuxia Date: Thu Oct 31 14:41:48 2019 +0800 fsstress: add EXCHANGE renameat2 support This is causing xfstest generic/579 to fail due to

[f2fs-dev] [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr

2019-11-04 Thread Mark Salyzyn via Linux-f2fs-devel
From: Mark Salyzyn Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path when called by security infrastructure. This handles the case of a union filesystem driver that is being reques

Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Jaegeuk Kim
On 11/01, Chao Yu wrote: > This reverts commit 5222595d093ebe80329d38d255d14316257afb3e. > > As discussed with Eric, as kvmalloc() will try kmalloc() first, so > when we need allocate large size memory, it'd better to use > f2fs_kvmalloc() directly rather than adding additional fallback > logic to

Re: [f2fs-dev] [PATCH v5 7/9] fscrypt: add inline encryption support

2019-11-04 Thread Christoph Hellwig
On Thu, Oct 31, 2019 at 03:25:03PM -0700, Eric Biggers wrote: > It's more important to clean up the IS_ENCRYPTED(inode) && > S_ISREG(inode->i_mode) checks that are duplicated in fs/{ext4,f2fs}/, so I've > been thinking of adding a helper: > > static inline bool fscrypt_needs_contents_encryption(co

Re: [f2fs-dev] [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

2019-11-04 Thread Christoph Hellwig
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote: > There's currently 6 filesystems that have the same #define. Move it > into errno.h so it's defined in just one place. And 4 out of 6 also define EFSBADCRC, so please lift that as well. ___

Re: [f2fs-dev] [PATCH v5 7/9] fscrypt: add inline encryption support

2019-11-04 Thread Eric Biggers
On Mon, Nov 04, 2019 at 04:15:54PM -0800, Christoph Hellwig wrote: > > I don't think combining these things is a good idea because it would > > restrict > > the use of inline encryption to filesystems that allow IV_INO_LBLK_64 > > encryption > > policies, i.e. filesystems that have stable inode n

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-11-04 Thread Eric Biggers
On Thu, Oct 31, 2019 at 02:22:34PM -0700, Christoph Hellwig wrote: > On Thu, Oct 31, 2019 at 04:50:45PM -0400, Theodore Y. Ts'o wrote: > > One of the reasons I really want this is so I (as an upstream > > maintainer of ext4 and fscrypt) can test the new code paths using > > xfstests on GCE, without

Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Chao Yu
On 2019/11/5 8:02, Jaegeuk Kim wrote: > On 11/01, Chao Yu wrote: >> This reverts commit 5222595d093ebe80329d38d255d14316257afb3e. >> >> As discussed with Eric, as kvmalloc() will try kmalloc() first, so >> when we need allocate large size memory, it'd better to use >> f2fs_kvmalloc() directly rathe

Re: [f2fs-dev] [PATCH] f2fs: avoid kernel panic on corruption test

2019-11-04 Thread Chao Yu
On 2019/11/2 0:36, Jaegeuk Kim wrote: > xfstests/generic/475 complains kernel warn/panic while testing corrupted disk. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.

Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Eric Biggers
On Tue, Nov 05, 2019 at 10:17:41AM +0800, Chao Yu wrote: > On 2019/11/5 8:02, Jaegeuk Kim wrote: > > On 11/01, Chao Yu wrote: > >> This reverts commit 5222595d093ebe80329d38d255d14316257afb3e. > >> > >> As discussed with Eric, as kvmalloc() will try kmalloc() first, so > >> when we need allocate la

[f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody

2019-11-04 Thread Valdis Kletnieks
Four filesystems have their own defines for this. Move it into errno.h so it's defined in just one place. Signed-off-by: Valdis Kletnieks --- fs/ext4/ext4.h | 2 -- fs/f2fs/f2fs.h | 2 -- fs/xfs/xfs_linux.h | 1 - include/linux/jbd2.h

Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Chao Yu
On 2019/11/5 10:38, Eric Biggers wrote: > On Tue, Nov 05, 2019 at 10:17:41AM +0800, Chao Yu wrote: >> On 2019/11/5 8:02, Jaegeuk Kim wrote: >>> On 11/01, Chao Yu wrote: This reverts commit 5222595d093ebe80329d38d255d14316257afb3e. As discussed with Eric, as kvmalloc() will try kmallo

Re: [f2fs-dev] [PATCH 3/3] Revert "f2fs: use kvmalloc, if kmalloc is failed"

2019-11-04 Thread Jaegeuk Kim
On 11/05, Chao Yu wrote: > On 2019/11/5 10:38, Eric Biggers wrote: > > On Tue, Nov 05, 2019 at 10:17:41AM +0800, Chao Yu wrote: > >> On 2019/11/5 8:02, Jaegeuk Kim wrote: > >>> On 11/01, Chao Yu wrote: > This reverts commit 5222595d093ebe80329d38d255d14316257afb3e. > > As discussed w

Re: [f2fs-dev] [PATCH v5 7/9] fscrypt: add inline encryption support

2019-11-04 Thread Eric Biggers
On Thu, Oct 31, 2019 at 02:21:03PM -0700, Christoph Hellwig wrote: > > > > > > Btw, I'm not happy about the 8-byte IV assumptions everywhere here. > > > That really should be a parameter, not hardcoded. > > > > To be clear, the 8-byte IV assumption doesn't really come from fs/crypto/, > > but >

Re: [f2fs-dev] [PATCH 1/2] f2fs: support aligned pinned file

2019-11-04 Thread Chao Yu
On 2019/10/31 23:29, Jaegeuk Kim wrote: > On 10/31, Chao Yu wrote: >> On 2019/10/31 0:09, Jaegeuk Kim wrote: >>> On 10/26, Chao Yu wrote: On 2019/10/26 2:18, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2019/10/23 1:16, Jaegeuk Kim wrote: >>> This p

Re: [f2fs-dev] [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

2019-11-04 Thread Chao Yu
On 2019/11/4 9:45, Valdis Kletnieks wrote: > There's currently 6 filesystems that have the same #define. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks > Acked-by: Darrick J. Wong > Reviewed-by: Jan Kara > Acked-by: Theodore Ts'o > fs/erofs/inte