Re: [f2fs-dev] [PATCH] f2fs: fix the panic in do_checkpoint()

2020-02-13 Thread Chao Yu
On 2020/2/14 15:16, Chao Yu wrote: > Hi Sahitya, > > On 2020/2/14 11:54, Sahitya Tummala wrote: >> Hi Chao, >> >> On Fri, Feb 14, 2020 at 10:26:18AM +0800, Chao Yu wrote: >>> Hi Sahitya, >>> >>> On 2020/2/12 18:34, Sahitya Tummala wrote: There could be a scenario where f2fs_sync_meta_pages()

Re: [f2fs-dev] [PATCH] f2fs: fix the panic in do_checkpoint()

2020-02-13 Thread Chao Yu
Hi Sahitya, On 2020/2/14 11:54, Sahitya Tummala wrote: > Hi Chao, > > On Fri, Feb 14, 2020 at 10:26:18AM +0800, Chao Yu wrote: >> Hi Sahitya, >> >> On 2020/2/12 18:34, Sahitya Tummala wrote: >>> There could be a scenario where f2fs_sync_meta_pages() will not >>> ensure that all F2FS_DIRTY_META pa

Re: [f2fs-dev] [PATCH v5 04/13] mm: Add readahead address space operation

2020-02-13 Thread John Hubbard
On 2/10/20 5:03 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This replaces ->readpages with a saner interface: > - Return void instead of an ignored error code. > - Pages are already in the page cache when ->readahead is called. > - Implementation looks up the pages in the p

Re: [f2fs-dev] [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead

2020-02-13 Thread John Hubbard
On 2/13/20 8:21 PM, Matthew Wilcox wrote: > On Thu, Feb 13, 2020 at 07:19:53PM -0800, John Hubbard wrote: >> On 2/10/20 5:03 PM, Matthew Wilcox wrote: >>> @@ -161,7 +161,7 @@ unsigned int __do_page_cache_readahead(struct >>> address_space *mapping, >>> unsigned long end_index;/* The la

Re: [f2fs-dev] [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead

2020-02-13 Thread Matthew Wilcox
On Thu, Feb 13, 2020 at 07:19:53PM -0800, John Hubbard wrote: > On 2/10/20 5:03 PM, Matthew Wilcox wrote: > > @@ -161,7 +161,7 @@ unsigned int __do_page_cache_readahead(struct > > address_space *mapping, > > unsigned long end_index;/* The last page we want to read */ > > LIST_HEAD(

Re: [f2fs-dev] [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead

2020-02-13 Thread John Hubbard
On 2/10/20 5:03 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > ra_submit() which is a wrapper around __do_page_cache_readahead() already > returns an unsigned long, and the 'nr_to_read' parameter is an unsigned > long, so fix __do_page_cache_readahead() to return an unsigned long

Re: [f2fs-dev] [PATCH v5 03/13] mm: Put readahead pages in cache earlier

2020-02-13 Thread John Hubbard
On 2/10/20 5:03 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > At allocation time, put the pages in the cache unless we're using > ->readpages. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/readahead.c | 66 -- > 1 file c

Re: [f2fs-dev] [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2020-02-13 Thread Chao Yu
Hi Jaegeuk, Is it time to consider this metadata chksum feature? Maybe for 5.7 version. Thanks, On 2018/1/27 17:43, Chao Yu wrote: > This patch adds to support {d,id,did,x}node checksum in kernel side. > > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 15 +++- > fs/f2fs/inode.c

Re: [f2fs-dev] [PATCH] f2fs: fix the panic in do_checkpoint()

2020-02-13 Thread Chao Yu
Hi Sahitya, On 2020/2/12 18:34, Sahitya Tummala wrote: > There could be a scenario where f2fs_sync_meta_pages() will not > ensure that all F2FS_DIRTY_META pages are submitted for IO. Thus, > resulting in the below panic in do_checkpoint() - > > f2fs_bug_on(sbi, get_pages(sbi, F2FS_DIRTY_META) &&

Re: [f2fs-dev] [PATCH v5 06/13] fs: Convert mpage_readpages to mpage_readahead

2020-02-13 Thread Junxiao Bi
On 2/10/20 5:03 PM, Matthew Wilcox wrote: From: "Matthew Wilcox (Oracle)" Implement the new readahead aop and convert all callers (block_dev, exfat, ext2, fat, gfs2, hpfs, isofs, jfs, nilfs2, ocfs2, omfs, qnx6, reiserfs & udf). The callers are all trivial except for GFS2 & OCFS2. Signed-off

Re: [f2fs-dev] [PATCH 00/12] Change readahead API

2020-02-13 Thread Matthew Wilcox
On Wed, Feb 12, 2020 at 08:38:52PM -0800, Andrew Morton wrote: > On Fri, 24 Jan 2020 17:35:41 -0800 Matthew Wilcox wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > This series adds a readahead address_space operation to eventually > > replace the readpages operation. The key difference is