Re: [f2fs-dev] Bug#955549: f2fs-tools: fsck.f2fs segfaults

2020-04-02 Thread Chao Yu
Thanks for forwarding, Ted. On 2020/4/3 10:45, Adam Borowski wrote: > On Thu, Apr 02, 2020 at 03:16:58PM -0400, Theodore Y. Ts'o wrote: >> On Thu, Apr 02, 2020 at 02:01:26PM +0200, Adam Borowski wrote: >>> >>> After a lot of output on a damaged filesystem (SD card copied to an image) >>> fsck.f2fs

Re: [f2fs-dev] Bug#955549: f2fs-tools: fsck.f2fs segfaults

2020-04-02 Thread Adam Borowski
On Thu, Apr 02, 2020 at 03:16:58PM -0400, Theodore Y. Ts'o wrote: > On Thu, Apr 02, 2020 at 02:01:26PM +0200, Adam Borowski wrote: > > > > After a lot of output on a damaged filesystem (SD card copied to an image) > > fsck.f2fs dies with: > > > > - File name : mkfs.ext3.dpkg-new > > - Fi

Re: [f2fs-dev] Bug#955549: f2fs-tools: fsck.f2fs segfaults

2020-04-02 Thread Theodore Y. Ts'o
On Thu, Apr 02, 2020 at 02:01:26PM +0200, Adam Borowski wrote: > > After a lot of output on a damaged filesystem (SD card copied to an image) > fsck.f2fs dies with: > > - File name : mkfs.ext3.dpkg-new > - File size : 6 (bytes) > > Program received signal SIGSEGV, Segmentation f

Re: [f2fs-dev] [PATCH v3] f2fs: fix long latency due to discard during umount

2020-04-02 Thread Chao Yu
On 2020/4/1 17:22, Sahitya Tummala wrote: > Hi Jaegeuk, > > On Tue, Mar 31, 2020 at 11:46:55AM -0700, Jaegeuk Kim wrote: >> On 03/30, Sahitya Tummala wrote: >>> F2FS already has a default timeout of 5 secs for discards that >>> can be issued during umount, but it can take more than the 5 sec >>> t

Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'

2020-04-02 Thread Jason Yan
Hi Chao, 在 2020/4/2 16:37, Chao Yu 写道: Hi Jason, On 2020/4/2 14:15, Jason Yan wrote: Fix the following gcc warning: fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable] ZSTD_parameters params; ^~ Reported-by: Hulk Robot

Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'

2020-04-02 Thread Chao Yu
Hi Jason, On 2020/4/2 14:15, Jason Yan wrote: > Fix the following gcc warning: > > fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used > [-Wunused-but-set-variable] > ZSTD_parameters params; > ^~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan