Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Naresh Kamboju
On Thu, 21 May 2020 at 08:10, Yafang Shao wrote: > > On Thu, May 21, 2020 at 2:00 AM Naresh Kamboju > wrote: > > > > On Wed, 20 May 2020 at 17:26, Naresh Kamboju > > wrote: > > > > > > > > > This issue is specific on 32-bit architectures i386 and arm on linux-next > > > tree. > > > As per the

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Naresh Kamboju
On Thu, 21 May 2020 at 00:39, Chris Down wrote: > > Hi Naresh, > > Naresh Kamboju writes: > >As a part of investigation on this issue LKFT teammate Anders Roxell > >git bisected the problem and found bad commit(s) which caused this problem. > > > >The following two patches have been reverted on ne

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Yafang Shao
On Thu, May 21, 2020 at 4:59 PM Naresh Kamboju wrote: > > On Thu, 21 May 2020 at 08:10, Yafang Shao wrote: > > > > On Thu, May 21, 2020 at 2:00 AM Naresh Kamboju > > wrote: > > > > > > On Wed, 20 May 2020 at 17:26, Naresh Kamboju > > > wrote: > > > > > > > > > > > > This issue is specific on 3

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Michal Hocko
On Wed 20-05-20 20:09:06, Chris Down wrote: > Hi Naresh, > > Naresh Kamboju writes: > > As a part of investigation on this issue LKFT teammate Anders Roxell > > git bisected the problem and found bad commit(s) which caused this problem. > > > > The following two patches have been reverted on next

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Arnd Bergmann
On Thu, May 21, 2020 at 11:22 AM Naresh Kamboju wrote: > On Thu, 21 May 2020 at 00:39, Chris Down wrote: > > Since you have i386 hardware available, and I don't, could you please apply > > only "avoid stale protection" again and check if it only happens with that > > commit, or requires both? Tha

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Naresh Kamboju
On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > Hi Naresh, > > > > Naresh Kamboju writes: > > > As a part of investigation on this issue LKFT teammate Anders Roxell > > > git bisected the problem and found bad commit(s) which caused this > > >

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Michal Hocko
On Thu 21-05-20 16:11:11, Naresh Kamboju wrote: > On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > > Hi Naresh, > > > > > > Naresh Kamboju writes: > > > > As a part of investigation on this issue LKFT teammate Anders Roxell > > > > git bisec

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Hugh Dickins via Linux-f2fs-devel
On Thu, 21 May 2020, Michal Hocko wrote: > On Thu 21-05-20 16:11:11, Naresh Kamboju wrote: > > On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > > > > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > > > Hi Naresh, > > > > > > > > Naresh Kamboju writes: > > > > > As a part of investigation on

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Michal Hocko
On Thu 21-05-20 05:24:27, Hugh Dickins wrote: > On Thu, 21 May 2020, Michal Hocko wrote: > > On Thu 21-05-20 16:11:11, Naresh Kamboju wrote: > > > On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > > > > > > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > > > > Hi Naresh, > > > > > > > > > >

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Michal Hocko
On Thu 21-05-20 11:55:16, Michal Hocko wrote: > On Wed 20-05-20 20:09:06, Chris Down wrote: > > Hi Naresh, > > > > Naresh Kamboju writes: > > > As a part of investigation on this issue LKFT teammate Anders Roxell > > > git bisected the problem and found bad commit(s) which caused this > > > probl

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Naresh Kamboju
On Thu, 21 May 2020 at 22:04, Michal Hocko wrote: > > On Thu 21-05-20 11:55:16, Michal Hocko wrote: > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > > Hi Naresh, > > > > > > Naresh Kamboju writes: > > > > As a part of investigation on this issue LKFT teammate Anders Roxell > > > > git bisected

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Johannes Weiner
On Thu, May 21, 2020 at 02:44:44PM +0200, Michal Hocko wrote: > On Thu 21-05-20 05:24:27, Hugh Dickins wrote: > > On Thu, 21 May 2020, Michal Hocko wrote: > > > On Thu 21-05-20 16:11:11, Naresh Kamboju wrote: > > > > On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > > > > > > > > > On Wed 20-0

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Hugh Dickins via Linux-f2fs-devel
On Thu, 21 May 2020, Johannes Weiner wrote: > > Very much appreciate you guys tracking it down so quickly. Sorry about > the breakage. > > I think mem_cgroup_disabled() checks are pretty good markers of public > entry points to the memcg API, so I'd prefer that even if a bit more > verbose. What

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Naresh Kamboju
My apology ! As per the test results history this problem started happening from Bad : next-20200430 (still reproducible on next-20200519) Good : next-20200429 The git tree / tag used for testing is from linux next-20200430 tag and reverted following three patches and oom-killer problem fixed. Re

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Johannes Weiner
On Thu, May 21, 2020 at 01:06:28PM -0700, Hugh Dickins wrote: > On Thu, 21 May 2020, Johannes Weiner wrote: > > do_memsw_account() used to be automatically false when the cgroup > > controller was disabled. Now that it's replaced by > > cgroup_memory_noswap, for which this isn't true, make the > >

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-21 Thread Hugh Dickins via Linux-f2fs-devel
On Thu, 21 May 2020, Johannes Weiner wrote: > On Thu, May 21, 2020 at 01:06:28PM -0700, Hugh Dickins wrote: > > On Thu, 21 May 2020, Johannes Weiner wrote: > > > do_memsw_account() used to be automatically false when the cgroup > > > controller was disabled. Now that it's replaced by > > > cgroup_m