On 2020/6/16 10:39, Wang Xiaojun wrote:
> The parameter compr is unused in the f2fs_cluster_blocks function
> so we no longer need to pass it as a parameter.
>
> Signed-off-by: Wang Xiaojun
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing
The parameter compr is unused in the f2fs_cluster_blocks function
so we no longer need to pass it as a parameter.
Signed-off-by: Wang Xiaojun
---
fs/f2fs/compress.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index df7b2d15eac
On Mon, Jun 15, 2020 at 08:47:20AM -0700, Eric Biggers wrote:
> On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote:
> > >
> > > Should I fold this change into the original patch? Or keep it as a
> > > separate patch when I send out the fscrypt/f2fs inline encryption
> > > patches?
> >
On Mon, Jun 15, 2020 at 04:51:32PM +0800, Jason Yan wrote:
> This is an effort to eliminate the uninitialized_var() macro[1].
>
> The use of this macro is the wrong solution because it forces off ANY
> analysis by the compiler for a given variable. It even masks "unused
> variable" warnings.
>
>
From: Rolf Eike Beer
Otherwise linking will fail if the library is in an uncommon location or has a
non-standard name.
Signed-off-by: Rolf Eike Beer
Signed-off-by: Jaegeuk Kim
---
mkfs/Makefile.am | 2 +-
tools/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Rolf Eike Beer
$ pkg-config --cflags blkid
-I/usr/include/blkid
The "blkid/" directory is actually part of the include path. This usually still
works because most people have the path one level up in their default include
path.
Signed-off-by: Rolf Eike Beer
Signed-off-by: Jaegeuk Kim
--
From: Rolf Eike Beer
$ pkg-config --cflags uuid
-I/usr/include/uuid
The "uuid/" directory is actually part of the include path. This usually still
works because most people have the path one level up in their default include
path.
Signed-off-by: Rolf Eike Beer
Signed-off-by: Jaegeuk Kim
---
From: Rolf Eike Beer
Otherwise the paths to uuid and blkid headers extracted from pkg-config are not
respected.
Signed-off-by: Rolf Eike Beer
Signed-off-by: Jaegeuk Kim
---
mkfs/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
index 42c8d31..a
On 06/09, Eric Biggers wrote:
> On Wed, Jun 10, 2020 at 01:14:46AM +0300, Denis Efremov wrote:
> > Use kfree() instead of kvfree() to free super in read_raw_super_block()
> > because the memory is allocated with kzalloc() in the function.
> > Use kfree() instead of kvfree() to free sbi, raw_super i
On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote:
> >
> > Should I fold this change into the original patch? Or keep it as a
> > separate patch when I send out the fscrypt/f2fs inline encryption
> > patches?
>
> It may be good to keep it seperate as we already have the base FBE pat
There could be a potential race between these two paths below,
leading to use-after-free when accessing bio->bi_crypt_context.
f2fs_write_cache_pages
->f2fs_do_write_data_page on page#1
->f2fs_inplace_write_data
->f2fs_merge_page_bio
->add_bio_entry
->f2fs_do_write_data_page on page#2
There could be a potential race between these two paths below,
leading to use-after-free when accessing bio->bi_crypt_context.
f2fs_write_cache_pages
->f2fs_do_write_data_page on page#1
->f2fs_inplace_write_data
->f2fs_merge_page_bio
->add_bio_entry
->f2fs_do_write_data_page on page#2
Hi Satya,
On Mon, Jun 15, 2020 at 06:16:33AM +, Satya Tangirala wrote:
> On Sun, Jun 14, 2020 at 10:00:19PM -0700, Eric Biggers wrote:
> > On Mon, Jun 15, 2020 at 09:29:48AM +0530, Sahitya Tummala wrote:
> > > There could be a potential race between these two paths below,
> > > leading to use-
Hi Eric,
On Sun, Jun 14, 2020 at 10:00:19PM -0700, Eric Biggers wrote:
> On Mon, Jun 15, 2020 at 09:29:48AM +0530, Sahitya Tummala wrote:
> > There could be a potential race between these two paths below,
> > leading to use-after-free when accessing bio->bi_crypt_context.
> >
> > f2fs_write_cache
On 2020/6/15 16:51, Jason Yan wrote:
> This is an effort to eliminate the uninitialized_var() macro[1].
>
> The use of this macro is the wrong solution because it forces off ANY
> analysis by the compiler for a given variable. It even masks "unused
> variable" warnings.
>
> Quoted from Linus[2]:
This is an effort to eliminate the uninitialized_var() macro[1].
The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even masks "unused
variable" warnings.
Quoted from Linus[2]:
"It's a horrible thing to use, in that it adds ext
在 2020/6/15 16:26, Chao Yu 写道:
On 2020/6/15 12:02, Jason Yan wrote:
This is an effort to eliminate the uninitialized_var() macro[1].
The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even masks "unused
variable" warnings.
Q
On 2020/6/15 12:02, Jason Yan wrote:
> This is an effort to eliminate the uninitialized_var() macro[1].
>
> The use of this macro is the wrong solution because it forces off ANY
> analysis by the compiler for a given variable. It even masks "unused
> variable" warnings.
>
> Quoted from Linus[2]:
On 2020/6/15 16:11, Wei Fang wrote:
> Since offset < new_size, no need to do truncate_pagecache() again
> with new_size.
>
> Signed-off-by: Wei Fang
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.n
Since offset < new_size, no need to do truncate_pagecache() again
with new_size.
Signed-off-by: Wei Fang
---
v2: remove the lock coverage change
fs/f2fs/file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 3268f8dd59bb..98721f9bef25 100644
--- a/fs/f
On 2020/6/15 9:42, Chao Yu wrote:
> Hi Wei Fang,
>
> On 2020/6/13 12:25, Wei Fang wrote:
>> Since offset < new_size, no need to do truncate_pagecache() again
>> with new_size.
>>
>> Signed-off-by: Wei Fang
>> ---
>> fs/f2fs/file.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
21 matches
Mail list logo
