[f2fs-dev] [PATCH v9 2/4] fs: Add standard casefolding support

2020-06-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds general supporting functions for filesystems that use utf8 casefolding. It provides standard dentry_operations and adds the necessary structures in struct super_block to allow this standardization. Ext4 and F2fs will switch to these common implementations. Signed-off-by: Daniel Rosenber

Re: [f2fs-dev] [PATCH v9 4/4] ext4: Use generic casefolding support

2020-06-23 Thread Eric Biggers
On Tue, Jun 23, 2020 at 09:33:41PM -0700, Daniel Rosenberg wrote: > This switches ext4 over to the generic support provided in > commit 5f829feca774 ("fs: Add standard casefolding support") Commit IDs aren't determined until the patches are applied. It's possible for the person applying the patch

Re: [f2fs-dev] [PATCH v9 2/4] fs: Add standard casefolding support

2020-06-23 Thread Eric Biggers
On Tue, Jun 23, 2020 at 09:33:39PM -0700, Daniel Rosenberg wrote: > This adds general supporting functions for filesystems that use > utf8 casefolding. It provides standard dentry_operations and adds the > necessary structures in struct super_block to allow this standardization. > > Ext4 and F2fs

Re: [f2fs-dev] [PATCH v9 4/4] ext4: Use generic casefolding support

2020-06-23 Thread Gabriel Krisman Bertazi
Daniel Rosenberg writes: > - > const struct dentry_operations ext4_dentry_ops = { > - .d_hash = ext4_d_hash, > - .d_compare = ext4_d_compare, > + .d_hash = generic_ci_d_hash, > + .d_compare = generic_ci_d_compare, > }; > #endif Can you make the structure generic since it is th

Re: [f2fs-dev] [PATCH v9 2/4] fs: Add standard casefolding support

2020-06-23 Thread Eric Biggers
On Tue, Jun 23, 2020 at 09:33:39PM -0700, Daniel Rosenberg wrote: > This adds general supporting functions for filesystems that use > utf8 casefolding. It provides standard dentry_operations and adds the > necessary structures in struct super_block to allow this standardization. > > Ext4 and F2fs

Re: [f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash

2020-06-23 Thread Eric Biggers
On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. It would be helpful to add a few more details in this commit message. Somewhat along the lines of:

Re: [f2fs-dev] [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches

2020-06-23 Thread Eric Biggers
On Tue, Jun 23, 2020 at 09:33:37PM -0700, Daniel Rosenberg wrote: > This lays the ground work for enabling casefolding and encryption at the > same time for ext4 and f2fs. A future set of patches will enable that > functionality. These unify the highly similar dentry_operations that ext4 > and f2fs

Re: [f2fs-dev] [PATCH v9 2/4] fs: Add standard casefolding support

2020-06-23 Thread Gabriel Krisman Bertazi
Daniel Rosenberg writes: > This adds general supporting functions for filesystems that use > utf8 casefolding. It provides standard dentry_operations and adds the > necessary structures in struct super_block to allow this standardization. > > Ext4 and F2fs will switch to these common implementati

[f2fs-dev] [PATCH v9 3/4] f2fs: Use generic casefolding support

2020-06-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This switches f2fs over to the generic support provided in commit 5f829feca774 ("fs: Add standard casefolding support") Signed-off-by: Daniel Rosenberg --- fs/f2fs/dir.c | 84 + fs/f2fs/f2fs.h | 4 -- fs/f2fs/super.c | 10 ++---

Re: [f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash

2020-06-23 Thread Gabriel Krisman Bertazi
Daniel Rosenberg writes: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. > > Signed-off-by: Daniel Rosenberg > --- > fs/unicode/utf8-core.c | 23 ++- > include/linux/unicode.h | 3 +++ > 2

[f2fs-dev] [PATCH v9 4/4] ext4: Use generic casefolding support

2020-06-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This switches ext4 over to the generic support provided in commit 5f829feca774 ("fs: Add standard casefolding support") Signed-off-by: Daniel Rosenberg --- fs/ext4/dir.c | 64 ++--- fs/ext4/ext4.h | 12 -- fs/ext4/hash.c | 2 +- fs/ext4/na

[f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash

2020-06-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds a case insensitive hash function to allow taking the hash without needing to allocate a casefolded copy of the string. Signed-off-by: Daniel Rosenberg --- fs/unicode/utf8-core.c | 23 ++- include/linux/unicode.h | 3 +++ 2 files changed, 25 insertions(+), 1 deleti

[f2fs-dev] [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches

2020-06-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This lays the ground work for enabling casefolding and encryption at the same time for ext4 and f2fs. A future set of patches will enable that functionality. These unify the highly similar dentry_operations that ext4 and f2fs both use for casefolding. Daniel Rosenberg (4): unicode: Add utf8_case

Re: [f2fs-dev] [PATCH v1] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-23 Thread Chao Yu
On 2020/6/23 22:34, Qilong Zhang wrote: > When f2fs_ioc_gc_range performs multiple segments gc ops, the return > value of f2fs_ioc_gc_range is determined by the last segment gc ops. > If its ops failed, the f2fs_ioc_gc_range will be considered to be failed > despite some of previous segments gc ops

[f2fs-dev] [PATCH] f2fs: avoid readahead race condition

2020-06-23 Thread Jaegeuk Kim
If two readahead threads having same offset enter in readpages, every read IOs are split and issued to the disk which giving lower bandwidth. This patch tries to avoid redundant readahead calls. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 15 +++ fs/f2fs/f2fs.h | 1 + fs/f2fs

Re: [f2fs-dev] [PATCH 1/4] fs: introduce SB_INLINECRYPT

2020-06-23 Thread Dave Chinner
On Mon, Jun 22, 2020 at 06:50:17PM -0700, Eric Biggers wrote: > On Tue, Jun 23, 2020 at 10:46:36AM +1000, Dave Chinner wrote: > > On Wed, Jun 17, 2020 at 08:19:35PM -0700, Eric Biggers wrote: > > > Are you objecting to the use of a SB_* flag, or just to showing the flag > > > in > > > show_sb_opts

[f2fs-dev] [PATCH v1] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-23 Thread Qilong Zhang
When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops succeeded. Therefore, so we fix: only all of se

Re: [f2fs-dev] [PATCH -next] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-23 Thread Chao Yu
On 2020/6/23 15:14, z00520423 wrote: > From: Qilong Zhang > > When f2fs_ioc_gc_range performs multiple segments gc ops, the return > value of f2fs_ioc_gc_range is determined by the last segment gc ops. > If its ops failed, the f2fs_ioc_gc_range will be considered to be failed > despite some of pr

[f2fs-dev] [PATCH -next] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-23 Thread z00520423
From: Qilong Zhang When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops succeeded. Therefore, so w