[f2fs-dev] [PATCH v4] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-27 Thread Qilong Zhang
When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops succeeded. Therefore, so we fix: Redefine the r

[f2fs-dev] [PATCH v2 5/5] f2fs: show more debug info for per-temperature log

2020-06-27 Thread Chao Yu
- Add to account and show per-log dirty_seg, full_seg and valid_blocks in debugfs. - reformat printed info. TYPEsegnosecno zoneno dirty_seg full_seg valid_blk - COLD data: 1523 1523 1523 1 0399 - WARM data: 769 769

[f2fs-dev] [PATCH v2 1/5] f2fs: fix to wait page writeback before update

2020-06-27 Thread Chao Yu
Filesystem including f2fs should support stable page for special device like software raid, however there is one missing path that page could be updated while it is writeback state as below, fix this. - gc_node_segment - f2fs_move_node_page - __write_node_page - set_page_writeback - do_read

Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary judgments in __insert_free_nid()

2020-06-27 Thread Chao Yu
On 2020/6/26 22:39, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > The value of state must be equal to FREE_NID, so the if > condition judgment can be removed. > > Signed-off-by: Liu Song > --- > fs/f2fs/node.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --gi

Re: [f2fs-dev] [PATCH] f2fs: fix typo in comment of f2fs_do_add_link

2020-06-27 Thread Chao Yu
On 2020/6/25 20:40, Liu Song via Linux-f2fs-devel wrote: > stakable/stackable > > Signed-off-by: Liu Song Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/list

Re: [f2fs-dev] [PATCH] f2fs: avoid readahead race condition

2020-06-27 Thread Chao Yu
On 2020/6/24 9:21, Jaegeuk Kim wrote: > If two readahead threads having same offset enter in readpages, every read > IOs are split and issued to the disk which giving lower bandwidth. > > This patch tries to avoid redundant readahead calls. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c

Re: [f2fs-dev] [PATCH 5/5] f2fs: show more debug info for per-temperature log

2020-06-27 Thread Chao Yu
On 2020/6/25 6:31, Jaegeuk Kim wrote: > On 06/18, Chao Yu wrote: >> - Add to account and show per-log dirty_seg, full_seg and valid_blocks >> in debugfs. >> - reformat printed info. >> >> TYPEsegnosecno zoneno dirty_seg full_seg valid_blk >> - COLD data: 1523 1

Re: [f2fs-dev] [PATCH v3] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-27 Thread Chao Yu
On 2020/6/24 17:40, Qilong Zhang wrote: > When f2fs_ioc_gc_range performs multiple segments gc ops, the return > value of f2fs_ioc_gc_range is determined by the last segment gc ops. > If its ops failed, the f2fs_ioc_gc_range will be considered to be failed > despite some of previous segments gc ops

Re: [f2fs-dev] [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-27 Thread Chao Yu
On 2020/6/24 23:55, Jaegeuk Kim wrote: > On 06/22, Chao Yu wrote: >> On 2020/6/22 0:38, Jaegeuk Kim wrote: >>> On 06/20, Chao Yu wrote: On 2020/6/20 6:47, Jaegeuk Kim wrote: > On 06/19, Chao Yu wrote: >> On 2020/6/19 13:49, Jaegeuk Kim wrote: >>> On 06/19, Chao Yu wrote: H

[f2fs-dev] [PATCH 2/4] media: atomisp: Replace trace_printk by pr_info

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code, replace it call with pr_info. Signed-off-by: Nicolas Boichat --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/

[f2fs-dev] [PATCH v2 4/4] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-27 Thread Nicolas Boichat
trace_printk is meant as a debugging tool, and should not be compiled into production code without specific debug Kconfig options enabled, or source code changes, as indicated by the warning that shows up on boot if any trace_printk is called: ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE

[f2fs-dev] [PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code. Since tracing interrupts is presumably latency sensitive, pr_dbg is not appropriate, so guard the call with a preprocessor symbol that can be defined for debugging purpose. Signed-off-by: Nicolas Boichat --- drivers/media/platform/qcom/camss/c

[f2fs-dev] [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code, replace it call with dev_dbg. Signed-off-by: Nicolas Boichat --- Unclear why a trace_printk was used in the first place, it's possible that some rate-limiting is necessary here. drivers/usb/cdns3/gadget.c | 2 +- 1 file changed, 1 insertion(

[f2fs-dev] [PATCH 0/4] Detect and remove trace_printk

2020-06-27 Thread Nicolas Boichat
trace_printk is meant as a debugging tool, and should not be compiled into production code without specific debug Kconfig options enabled or source code changes. Patches 1 to 3 remove/disable trace_printk that should not be enabled by default. Patch 4 adds a config option that can be used to dete