Re: [f2fs-dev] [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback

2020-06-29 Thread Christoph Hellwig
On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote: > f2fs and xfs have both added support for cgroup writeback: > > 578c647 f2fs: implement cgroup writeback support > adfb5fb xfs: implement cgroup aware writeback > > so add them to the supported list in the docs. > > Signed-off-by: Er

[f2fs-dev] [PATCH] f2fs: remove unused parameter in f2fs_get_read_data_page()

2020-06-29 Thread Jia Yang
The parameter "op_flags" is not used in f2fs_get_read_data_page(), so it can be removed. Signed-off-by: Jia Yang --- fs/f2fs/data.c | 6 +++--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/gc.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 326c6

Re: [f2fs-dev] [PATCH] f2fs: fix typo in comment of f2fs_do_add_link

2020-06-29 Thread Chao Yu
Jaegeuk, It looks we merge this patch with below wrong author, better to fix this Liu Song via Linux-f2fs-devel On 2020/6/25 20:40, Liu Song via Linux-f2fs-devel wrote: > stakable/stackable > > Signed-off-by: Liu Song > --- > fs/f2fs/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [f2fs-dev] [PATCH 1/2] f2fs: split f2fs_allocate_new_segments()

2020-06-29 Thread Chao Yu
On 2020/6/30 4:19, Jaegeuk Kim wrote: > On 06/22, Chao Yu wrote: >> to two independent functions: >> - f2fs_allocate_new_segment() for specified type segment allocation >> - f2fs_allocate_new_segments() for all data type segments allocation >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/f2fs.h

Re: [f2fs-dev] [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback

2020-06-29 Thread Chao Yu
On 2020/6/30 3:08, Eric Sandeen wrote: > f2fs and xfs have both added support for cgroup writeback: > > 578c647 f2fs: implement cgroup writeback support > adfb5fb xfs: implement cgroup aware writeback > > so add them to the supported list in the docs. Thanks for the fix. > > Signed-off-by: Eri

[f2fs-dev] [PATCH] f2fs: add symbolic link to kobject in sysfs

2020-06-29 Thread Daeho Jeong
From: Daeho Jeong Added a symbolic link to directory of sysfs. It will create a symbolic link such as "mount_0" and "mount_1" to each f2fs mount in the order of mounting filesystem. It will provide easy access to sysfs node even if not knowing the specific device node name like sda19 and dm-3. S

[f2fs-dev] [PATCH] f2fs: add GC_URGENT_LOW mode in gc_urgent

2020-06-29 Thread Daeho Jeong
From: Daeho Jeong Added a new gc_urgent mode, GC_URGENT_LOW, in which mode F2FS will lower the bar of checking idle in order to process outstanding discard commands and GC a little bit aggressively. Signed-off-by: Daeho Jeong --- Documentation/ABI/testing/sysfs-fs-f2fs | 4 +++- fs/f2fs/f2fs.

Re: [f2fs-dev] [PATCH v3] f2fs: avoid readahead race condition

2020-06-29 Thread Jaegeuk Kim
If two readahead threads having same offset enter in readpages, every read IOs are split and issued to the disk which giving lower bandwidth. This patch tries to avoid redundant readahead calls. Signed-off-by: Jaegeuk Kim --- v3: - use READ|WRITE_ONCE v2: - add missing code to bypass read

Re: [f2fs-dev] [PATCH 1/2] f2fs: split f2fs_allocate_new_segments()

2020-06-29 Thread Jaegeuk Kim
On 06/22, Chao Yu wrote: > to two independent functions: > - f2fs_allocate_new_segment() for specified type segment allocation > - f2fs_allocate_new_segments() for all data type segments allocation > > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 3 ++- > fs/f2fs/file.c | 2 +- > fs

[f2fs-dev] [PATCH] doc: cgroup: add f2fs and xfs to supported list for writeback

2020-06-29 Thread Eric Sandeen
f2fs and xfs have both added support for cgroup writeback: 578c647 f2fs: implement cgroup writeback support adfb5fb xfs: implement cgroup aware writeback so add them to the supported list in the docs. Signed-off-by: Eric Sandeen --- TBH I wonder about the wisdom of having this detail in the do

Re: [f2fs-dev] [PATCH v2 3/4] f2fs: add inline encryption support

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 12:04:04PM +, Satya Tangirala via Linux-f2fs-devel wrote: > Wire up f2fs to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted fi

Re: [f2fs-dev] [PATCH v2 4/4] ext4: add inline encryption support

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 12:04:05PM +, Satya Tangirala via Linux-f2fs-devel wrote: > From: Eric Biggers > > Wire up ext4 to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encry

Re: [f2fs-dev] [PATCH v2] f2fs: avoid readahead race condition

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 11:24:14AM -0700, Jaegeuk Kim wrote: > On 06/29, Eric Biggers wrote: > > On Mon, Jun 29, 2020 at 08:03:23AM -0700, Jaegeuk Kim wrote: > > > If two readahead threads having same offset enter in readpages, every read > > > IOs are split and issued to the disk which giving lowe

Re: [f2fs-dev] [PATCH v2] f2fs: avoid readahead race condition

2020-06-29 Thread Jaegeuk Kim
On 06/29, Eric Biggers wrote: > On Mon, Jun 29, 2020 at 08:03:23AM -0700, Jaegeuk Kim wrote: > > If two readahead threads having same offset enter in readpages, every read > > IOs are split and issued to the disk which giving lower bandwidth. > > > > This patch tries to avoid redundant readahead c

Re: [f2fs-dev] [PATCH v2 1/4] fs: introduce SB_INLINECRYPT

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 12:04:02PM +, Satya Tangirala via Linux-f2fs-devel wrote: > Introduce SB_INLINECRYPT, which is set by filesystems that wish to use > blk-crypto for file content en/decryption. This flag maps to the > '-o inlinecrypt' mount option which multiple filesystems will implemen

Re: [f2fs-dev] [PATCH v2 2/4] fscrypt: add inline encryption support

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 12:04:03PM +, Satya Tangirala via Linux-f2fs-devel wrote: > diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c > index 4fa18fff9c4e..1ea9369a7688 100644 > --- a/fs/crypto/bio.c > +++ b/fs/crypto/bio.c > @@ -41,6 +41,52 @@ void fscrypt_decrypt_bio(struct bio *bio) > } > EX

Re: [f2fs-dev] [PATCH v2] f2fs: avoid readahead race condition

2020-06-29 Thread Eric Biggers
On Mon, Jun 29, 2020 at 08:03:23AM -0700, Jaegeuk Kim wrote: > If two readahead threads having same offset enter in readpages, every read > IOs are split and issued to the disk which giving lower bandwidth. > > This patch tries to avoid redundant readahead calls. > > Signed-off-by: Jaegeuk Kim >

Re: [f2fs-dev] [PATCH v2] f2fs: avoid readahead race condition

2020-06-29 Thread Jaegeuk Kim
If two readahead threads having same offset enter in readpages, every read IOs are split and issued to the disk which giving lower bandwidth. This patch tries to avoid redundant readahead calls. Signed-off-by: Jaegeuk Kim --- v2: - add missing code to bypass read fs/f2fs/data.c | 18

[f2fs-dev] [PATCH v2 3/4] f2fs: add inline encryption support

2020-06-29 Thread Satya Tangirala via Linux-f2fs-devel
Wire up f2fs to support inline encryption via the helper functions which fs/crypto/ now provides. This includes: - Adding a mount option 'inlinecrypt' which enables inline encryption on encrypted files where it can be used. - Setting the bio_crypt_ctx on bios that will be submitted to an inl

[f2fs-dev] [PATCH v2 0/4] Inline Encryption Support for fscrypt

2020-06-29 Thread Satya Tangirala via Linux-f2fs-devel
This patch series adds support for Inline Encryption to fscrypt, f2fs and ext4. It builds on the inline encryption support now present in the block layer, and has been rebased on v5.8-rc3. This patch series previously went though a number of iterations as part of the "Inline Encryption Support" pa

[f2fs-dev] [PATCH v2 2/3] f2fs: support to trace f2fs_bmap()

2020-06-29 Thread Chao Yu
to show f2fs_bmap()'s result as below: f2fs_bmap: dev = (251,0), ino = 7, lblock:0, pblock:396800 Signed-off-by: Chao Yu --- v2: - use show_dev_ino() to avoid compile warning. fs/f2fs/data.c | 14 +++--- include/trace/events/f2fs.h | 26 ++ 2 files c

[f2fs-dev] [PATCH v2 3/3] f2fs: support to trace f2fs_fiemap()

2020-06-29 Thread Chao Yu
to show f2fs_fiemap()'s result as below: f2fs_fiemap: dev = (251,0), ino = 7, lblock:0, pblock:1625292800, len:2097152, flags:0, ret:0 Signed-off-by: Chao Yu --- v2: - use show_dev_ino() to avoid compile warning. fs/f2fs/data.c | 6 +- fs/f2fs/inline.c| 2 ++ inc

[f2fs-dev] [PATCH v2 4/4] ext4: add inline encryption support

2020-06-29 Thread Satya Tangirala via Linux-f2fs-devel
From: Eric Biggers Wire up ext4 to support inline encryption via the helper functions which fs/crypto/ now provides. This includes: - Adding a mount option 'inlinecrypt' which enables inline encryption on encrypted files where it can be used. - Setting the bio_crypt_ctx on bios that will be

[f2fs-dev] [PATCH v2 1/4] fs: introduce SB_INLINECRYPT

2020-06-29 Thread Satya Tangirala via Linux-f2fs-devel
Introduce SB_INLINECRYPT, which is set by filesystems that wish to use blk-crypto for file content en/decryption. This flag maps to the '-o inlinecrypt' mount option which multiple filesystems will implement, and code in fs/crypto/ needs to be able to check for this mount option in a filesystem-ind

[f2fs-dev] [PATCH v2 2/4] fscrypt: add inline encryption support

2020-06-29 Thread Satya Tangirala via Linux-f2fs-devel
Add support for inline encryption to fs/crypto/. With "inline encryption", the block layer handles the decryption/encryption as part of the bio, instead of the filesystem doing the crypto itself via Linux's crypto API. This model is needed in order to take advantage of the inline encryption hardwa

Re: [f2fs-dev] possible circular locking dependency detected

2020-06-29 Thread Ilya Averyanov
Thanks. After applying this patch and some early, a deadlock was fixed. вс, 28 июн. 2020 г. в 10:11, Chao Yu : > > Hi, > > Could you please check that whether below commit has been merged? > > dd973007bfef ("f2fs: set GFP_NOFS when moving inline dentries") > > On 2020/6/26 21:56, Ilya Averyanov wr

Re: [f2fs-dev] [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-06-29 Thread Peter Chen
On 20-06-27 15:03:04, Nicolas Boichat wrote: > trace_printk should not be used in production code, replace it > call with dev_dbg. > > Signed-off-by: Nicolas Boichat > > --- > > Unclear why a trace_printk was used in the first place, it's > possible that some rate-limiting is necessary here. >

Re: [f2fs-dev] [PATCH] f2fs: remove useless parameter of __insert_free_nid()

2020-06-29 Thread Chao Yu
On 2020/6/28 21:48, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > In current version, @state will only be FREE_NID. This parameter > has no real effect so remove it to keep clean. > > Signed-off-by: Liu Song Reviewed-by: Chao Yu Thanks, _