Re: [f2fs-dev] f2fs kernel page allocation failures w/zstd compression (kernel 5.8.3)

2020-08-31 Thread Chao Yu
I think one way to solve this issue is adding an extra mount option, e.g. compress_mempool, once user specify this option, we can allocate and reserve memory for one single workspace of compression algorithm, during compress/decompress, once we can not grab any more memory from system, we can let

[f2fs-dev] [PATCH] f2fs_io: change fibmap to fiemap

2020-08-31 Thread Daeho Jeong
From: Daeho Jeong Currently we support fiemap command using fibmap. It's simple and easy to use, but we cannot use this for compressed file. To support more different types of files, we need to change this to use fiemap. Signed-off-by: Daeho Jeong --- tools/f2fs_io/f2fs_io.c | 56 +

Re: [f2fs-dev] f2fs kernel page allocation failures w/zstd compression (kernel 5.8.3)

2020-08-31 Thread 5kft
Thanks for the patch - I applied it against 5.9-rc2, and it seems to help...: The test I am using for this is to copy the entire rootfs tree to a zstd-compressed f2fs partition. Previously, even a vm.min_free_kbytes of 32768 wasn't enough to avoid the allocation traps for the copy; with this p

Re: [f2fs-dev] [PATCH v2 5/5] f2fs: support age threshold based garbage collection

2020-08-31 Thread Chao Yu
Jaegeuk, I missed one ')' in this diff, thanks for fixing in upstream. Thanks, On 2020/9/1 2:01, Jaegeuk Kim wrote: Hi Chao, Applied. Thanks. On 08/31, Chao Yu wrote: Hi Jaegeuk, I've changed code a bit to fix some bugs, including: - gc_idle = 3 (GC_IDLE_AT) description - disallow set gc_i

Re: [f2fs-dev] f2fs kernel page allocation failures w/zstd compression (kernel 5.8.3)

2020-08-31 Thread Chao Yu
Hi, We should align max compress window size of zstd to cluster size of current inode, by default, cluster size is 16KB (log size is 2), so it can reduce size of allocated memory significantly. So, could you please try below patch first? From c4bf178e5133525027d817a2ac542db6f5621c4f Mon Sep 1

Re: [f2fs-dev] f2fs kernel page allocation failures w/zstd compression (kernel 5.8.3)

2020-08-31 Thread 5kft
Sounds good :-) Perhaps it's simply that zstd needs a lot of memory to operate, however it's unfortunate that it doesn't work on smaller platforms "out of the box" like lz4 does. Should there a be note or guidance of some sort regarding this for smaller embedded platforms? On Mon, Aug 31, 202

Re: [f2fs-dev] f2fs kernel page allocation failures w/zstd compression (kernel 5.8.3)

2020-08-31 Thread Jaegeuk Kim
Let me add more f2fs folks. :) On 08/27, 5kft wrote: > (Note that for testing this I backported f2fs from 5.9-rc2 into 5.8.5, as I > don't have 5.9 working on these boards yet.) > > On Thu, Aug 27, 2020, at 7:39 AM, 5kft wrote: > > Quick update - I encounter the problem with f2fs zstd compressio

Re: [f2fs-dev] [PATCH v2 5/5] f2fs: support age threshold based garbage collection

2020-08-31 Thread Jaegeuk Kim
Hi Chao, Applied. Thanks. On 08/31, Chao Yu wrote: > Hi Jaegeuk, > > I've changed code a bit to fix some bugs, including: > - gc_idle = 3 (GC_IDLE_AT) description > - disallow set gc_idle to 3 if atgc is off > - keep compatibility with checkpoint disabling > > Could you please check and merge b

Re: [f2fs-dev] Questions about using f2fs to format the root partition during Slint installation.

2020-08-31 Thread Jaegeuk Kim
Hi, On 08/23, Didier Spaier wrote: > Hi, > > thanks for your answer, which leads to more questions and a request. > > I will quote only the relevant parts of this answer below. > > Le 25/06/2020 à 02:35, Jaegeuk Kim a écrit : > > On 06/25, Didier Spaier wrote: > > >> this email is a follow-up

Re: [f2fs-dev] [PATCH v2 5/5] f2fs: support age threshold based garbage collection

2020-08-31 Thread Chao Yu
Hi Jaegeuk, I've changed code a bit to fix some bugs, including: - gc_idle = 3 (GC_IDLE_AT) description - disallow set gc_idle to 3 if atgc is off - keep compatibility with checkpoint disabling Could you please check and merge below diff? From: Chao Yu Signed-off-by: Chao Yu --- Documentati