Re: [f2fs-dev] [PATCH 2/9] f2fs: remove f2fs_dir_open()

2020-11-25 Thread Chao Yu
On 2020/11/25 8:23, Eric Biggers wrote: From: Eric Biggers Since encrypted directories can be opened without their encryption key being available, and each readdir tries to set up the key, trying to set readdir -> readdir/lookup? up the key in ->open() too isn't really useful. Just remove

Re: [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE

2020-11-25 Thread Chao Yu
Daeho, On 2020/11/26 14:35, Daeho Jeong wrote: Chao, A little bit wired, why not failing cluster_may_compress() for user mode, and let writepages write cluster as raw blocks, in-where we can update i_compr_blocks and global compr block stats correctly. For decompression ioctl, I've made f2f

Re: [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE

2020-11-25 Thread Daeho Jeong
Chao, > A little bit wired, why not failing cluster_may_compress() for user mode, and > let writepages write cluster as raw blocks, in-where we can update > i_compr_blocks > and global compr block stats correctly. For decompression ioctl, I've made f2fs_need_compress_data() return "false" to pre

Re: [f2fs-dev] [PATCH v4 2/3] fscrypt: Have filesystems handle their d_ops

2020-11-25 Thread Daniel Rosenberg via Linux-f2fs-devel
> > This change has the side-effect of removing the capability of the root > directory from being case-insensitive. It is not a backward > incompatible change because there is no way to make the root directory > CI at the moment (it is never empty). But this restriction seems > artificial. Is ther

Re: [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE

2020-11-25 Thread Daeho Jeong
Eric, do_page_cache_ra() is defined in mm/internal.h for internal use between in mm, so we cannot use this one right now. So, I think we could use page_cache_ra_unbounded(), because we already check i_size boundary on our own. What do you think? 2020년 11월 24일 (화) 오후 12:05, Chao Yu 님이 작성: > > On 2

Re: [f2fs-dev] [PATCH v7 1/8] block: ensure bios are not split in middle of crypto data unit

2020-11-25 Thread Eric Biggers
On Tue, Nov 17, 2020 at 02:07:01PM +, Satya Tangirala wrote: > @@ -275,11 +331,24 @@ static struct bio *blk_bio_segment_split(struct > request_queue *q, > bvprvp = &bvprv; > } > > + /* > + * The input bio's number of sectors is assumed to be aligned to > + *

Re: [f2fs-dev] [PATCH v7 1/8] block: ensure bios are not split in middle of crypto data unit

2020-11-25 Thread Eric Biggers
On Wed, Nov 18, 2020 at 12:38:15AM +, Satya Tangirala wrote: > > > +/** > > > + * update_aligned_sectors_and_segs() - Ensures that *@aligned_sectors is > > > aligned > > > + * to @bio_sectors_alignment, and > > > that > > > + *

Re: [f2fs-dev] [PATCH] f2fs: change to use rwsem for cp_mutex

2020-11-25 Thread Sahitya Tummala
Hi David, On Tue, Nov 24, 2020 at 09:12:12AM +, David Laight wrote: > From: Chao Yu > > Sent: 24 November 2020 03:12 > > > > On 2020/11/24 1:05, David Laight wrote: > > > From: Sahitya Tummala > > >> Sent: 23 November 2020 05:29 > > >> > > >> Use rwsem to ensure serialization of the callers a