Re: [f2fs-dev] [PATCH] f2fs: expose # of overprivision segments

2021-03-03 Thread Chao Yu
On 2021/3/3 2:44, Jaegeuk Kim wrote: On 03/02, Jaegeuk Kim wrote: On 03/02, Chao Yu wrote: On 2021/3/2 13:42, Jaegeuk Kim wrote: This is useful when checking conditions during checkpoint=disable in Android. This sysfs entry is readonly, how about putting this at /sys/fs/f2fs//stat/? Urg..

Re: [f2fs-dev] f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Jaegeuk Kim
On 03/03, Colin Ian King wrote: > On 03/03/2021 19:44, Jaegeuk Kim wrote: > > On 03/02, Colin Ian King wrote: > >> Hi, > >> > >> Static analysis on linux-next detected a potential uninitialized > >> variable dn.node_changed that does not get set when a call to > >> f2fs_get_node_page() fails. This

Re: [f2fs-dev] f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Colin Ian King
On 03/03/2021 19:44, Jaegeuk Kim wrote: > On 03/02, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next detected a potential uninitialized >> variable dn.node_changed that does not get set when a call to >> f2fs_get_node_page() fails. This uninitialized value gets used in the >> call

Re: [f2fs-dev] f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Jaegeuk Kim
On 03/02, Colin Ian King wrote: > Hi, > > Static analysis on linux-next detected a potential uninitialized > variable dn.node_changed that does not get set when a call to > f2fs_get_node_page() fails. This uninitialized value gets used in the > call to f2fs_balance_fs() that may or not may not ba

Re: [f2fs-dev] [PATCH v2] f2fs: expose # of overprivision segments

2021-03-03 Thread Jaegeuk Kim
This is useful when checking conditions during checkpoint=disable in Android. Signed-off-by: Jaegeuk Kim --- Documentation/ABI/testing/sysfs-fs-f2fs | 5 + fs/f2fs/sysfs.c | 9 + 2 files changed, 14 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-f