[f2fs-dev] [PATCH 1/2] f2fs: don't start checkpoint thread in readonly mountpoint

2021-03-17 Thread Chao Yu
In readonly mountpoint, there should be no write IOs include checkpoint IO, so that it's not needed to create kernel checkpoint thread. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c inde

[f2fs-dev] [PATCH 2/2] f2fs: fix error path of f2fs_remount()

2021-03-17 Thread Chao Yu
In error path of f2fs_remount(), it missed to restart/stop kernel thread or enable/disable checkpoint, then mount option status may not be consistent with real condition of filesystem, so let's reorder remount flow a bit as below and do recovery correctly in error path: 1) handle gc thread 2) hand

[f2fs-dev] [PATCH v2] f2fs: do not use AT_SSR mode in FG_GC & high urgent BG_GC

2021-03-17 Thread Weichao Guo via Linux-f2fs-devel
AT_SSR mode is introduced by age threshold based GC for better hot/cold data seperation and avoiding free segment cost. However, LFS write mode is preferred in the scenario of foreground or high urgent GC, which should be finished ASAP. Let's only use AT_SSR in background GC and not high urgent GC

Re: [f2fs-dev] [PATCH] f2fs: do not use AT_SSR mode in FG_GC & high urgent BG_GC

2021-03-17 Thread Chao Yu
On 2021/3/17 16:28, Weichao Guo via Linux-f2fs-devel wrote: AT_SSR mode is introduced by age threshold based GC for better hot/cold data seperation and avoiding free segment cost. However, LFS write mode is preferred in the scenario of foreground or high urgent GC, which should be finished ASAP.

[f2fs-dev] [PATCH] f2fs: do not use AT_SSR mode in FG_GC & high urgent BG_GC

2021-03-17 Thread Weichao Guo via Linux-f2fs-devel
AT_SSR mode is introduced by age threshold based GC for better hot/cold data seperation and avoiding free segment cost. However, LFS write mode is preferred in the scenario of foreground or high urgent GC, which should be finished ASAP. Let's only use AT_SSR in background GC and not high urgent GC

Re: [f2fs-dev] [RFC PATCH] f2fs: do not use CURSEG_ALL_DATA_ATGC in foreground or urgent GC

2021-03-17 Thread Chao Yu
On 2021/3/17 15:01, Weichao Guo wrote: On 2021/3/17 14:41, Chao Yu wrote: On 2021/3/17 11:44, Weichao Guo wrote: On 2021/3/17 10:40, Chao Yu wrote: On 2021/3/16 21:15, Weichao Guo via Linux-f2fs-devel wrote: CURSEG_ALL_DATA_ATGC is introduced by age threshold based GC for better hot/cold da

Re: [f2fs-dev] [RFC PATCH] f2fs: do not use CURSEG_ALL_DATA_ATGC in foreground or urgent GC

2021-03-17 Thread Weichao Guo via Linux-f2fs-devel
On 2021/3/17 14:41, Chao Yu wrote: On 2021/3/17 11:44, Weichao Guo wrote: On 2021/3/17 10:40, Chao Yu wrote: On 2021/3/16 21:15, Weichao Guo via Linux-f2fs-devel wrote: CURSEG_ALL_DATA_ATGC is introduced by age threshold based GC for better hot/cold data seperation and avoiding free segmen