[f2fs-dev] [PATCH -next] f2fs: fix a typo in inode.c

2021-03-24 Thread Ruiqi Gong
Do a trivial typo fix. s/runing/running Reported-by: Hulk Robot Signed-off-by: Ruiqi Gong --- fs/f2fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 349d9cb933ee..5d2253d53f17 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c

Re: [f2fs-dev] [PATCH] Revert "f2fs: give a warning only for readonly partition"

2021-03-24 Thread Chao Yu
On 2021/3/25 6:44, Jaegeuk Kim wrote: On 03/24, Chao Yu wrote: On 2021/3/24 12:22, Jaegeuk Kim wrote: On 03/24, Chao Yu wrote: On 2021/3/24 2:39, Jaegeuk Kim wrote: On 03/23, Chao Yu wrote: This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789. Because that commit fails generic/050 t

Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid touching checkpointed data in get_victim()

2021-03-24 Thread Jaegeuk Kim
On 03/25, Chao Yu wrote: > On 2021/3/25 7:49, Jaegeuk Kim wrote: > > On 03/24, Chao Yu wrote: > > > In CP disabling mode, there are two issues when using LFS or SSR | AT_SSR > > > mode to select victim: > > > > > > 1. LFS is set to find source section during GC, the victim should have > > > no che

Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid touching checkpointed data in get_victim()

2021-03-24 Thread Chao Yu
On 2021/3/25 7:49, Jaegeuk Kim wrote: On 03/24, Chao Yu wrote: In CP disabling mode, there are two issues when using LFS or SSR | AT_SSR mode to select victim: 1. LFS is set to find source section during GC, the victim should have no checkpointed data, since after GC, section could not be set f

[f2fs-dev] [PATCH v4 1/5] fs: unicode: Use strscpy() instead of strncpy()

2021-03-24 Thread Shreeya Patel
Following warning was reported by Kernel Test Robot. In function 'utf8_parse_version', inlined from 'utf8_load' at fs/unicode/utf8mod.c:195:7: >> fs/unicode/utf8mod.c:175:2: warning: 'strncpy' specified bound 12 equals destination size [-Wstringop-truncation] 175 | strncpy(version_string, version

[f2fs-dev] [PATCH v4 0/5] Make UTF-8 encoding loadable

2021-03-24 Thread Shreeya Patel
utf8data.h_shipped has a large database table which is an auto-generated decodification trie for the unicode normalization functions and it is not necessary to carry this large table in the kernel. Goal is to make UTF-8 encoding loadable by converting it into a module and adding a layer between the

[f2fs-dev] [PATCH v4 3/5] fs: unicode: Rename function names from utf8 to unicode

2021-03-24 Thread Shreeya Patel
Rename the function names from utf8 to unicode for taking the first step towards the transformation of utf8-core file into the unicode subsystem layer file. Reviewed-by: Gabriel Krisman Bertazi Signed-off-by: Shreeya Patel --- fs/ext4/hash.c | 2 +- fs/ext4/namei.c| 12

[f2fs-dev] [PATCH v4 5/5] fs: unicode: Add utf8 module and a unicode layer

2021-03-24 Thread Shreeya Patel
utf8data.h_shipped has a large database table which is an auto-generated decodification trie for the unicode normalization functions. It is not necessary to load this large table in the kernel if no file system is using it, hence make UTF-8 encoding loadable by converting it into a module. Modify t

[f2fs-dev] [PATCH v4 4/5] fs: unicode: Rename utf8-core file to unicode-core

2021-03-24 Thread Shreeya Patel
Rename the file name from utf8-core to unicode-core for transformation of utf8-core file into the unicode subsystem layer file and also for better understanding. Acked-by: Gabriel Krisman Bertazi Signed-off-by: Shreeya Patel --- fs/unicode/Makefile| 2 +- fs/unicode/{utf

[f2fs-dev] [PATCH v4 2/5] fs: Check if utf8 encoding is loaded before calling utf8_unload()

2021-03-24 Thread Shreeya Patel
utf8_unload is being called if CONFIG_UNICODE is enabled. The ifdef block doesn't check if utf8 encoding has been loaded or not before calling the utf8_unload() function. This is not the expected behavior since it would sometimes lead to unloading utf8 even before loading it. Hence, add a condition

Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid touching checkpointed data in get_victim()

2021-03-24 Thread Jaegeuk Kim
On 03/24, Chao Yu wrote: > In CP disabling mode, there are two issues when using LFS or SSR | AT_SSR > mode to select victim: > > 1. LFS is set to find source section during GC, the victim should have > no checkpointed data, since after GC, section could not be set free for > reuse. > > Previousl

Re: [f2fs-dev] [PATCH] Revert "f2fs: give a warning only for readonly partition"

2021-03-24 Thread Jaegeuk Kim
On 03/24, Chao Yu wrote: > On 2021/3/24 12:22, Jaegeuk Kim wrote: > > On 03/24, Chao Yu wrote: > > > On 2021/3/24 2:39, Jaegeuk Kim wrote: > > > > On 03/23, Chao Yu wrote: > > > > > This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789. > > > > > > > > > > Because that commit fails generic/

Re: [f2fs-dev] [PATCH] Revert "f2fs: give a warning only for readonly partition"

2021-03-24 Thread Chao Yu
On 2021/3/24 12:22, Jaegeuk Kim wrote: On 03/24, Chao Yu wrote: On 2021/3/24 2:39, Jaegeuk Kim wrote: On 03/23, Chao Yu wrote: This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789. Because that commit fails generic/050 testcase which expect failure during mount a recoverable readonly