Re: [f2fs-dev] [PATCH v2] f2fs: compress: add nocompress extensions support

2021-05-04 Thread fengnan chang
when compress_extension = "*" and nocompress_extension = "abc", the most straightforward meaning to understand is compress all files except .abc files. And in some cases, it can provide more finer control to specifie which file need compressed and which file not needed. The words "Don't allow the

Re: [f2fs-dev] [GIT PULL] f2fs update for 5.13-rc1

2021-05-04 Thread pr-tracker-bot
The pull request you sent on Mon, 3 May 2021 16:24:57 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-for-5.13-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d0195c7d7af6a456c37f4b4b2df5528f10714482 Thank you! -- Deet-doot-do

Re: [f2fs-dev] [PATCH v2] f2fs: compress: add nocompress extensions support

2021-05-04 Thread Jaegeuk Kim
Hi Fengnan, On 04/28, Fengnan Chang wrote: > When we create a directory with enable compression, all file write into > directory will try to compress.But sometimes we may know, new file > cannot meet compression ratio requirements. > We need a nocompress extension to skip those files to avoid unne

Re: [f2fs-dev] [PATCH v2] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite

2021-05-04 Thread Jaegeuk Kim
On 04/28, Fengnan Chang wrote: > when write compressed file with O_TRUNC, there will be a lot of > unnecessary check valid blocks in f2fs_prepare_compress_overwrite, > especially when written in page size, remove it. > > Signed-off-by: Fengnan Chang > --- > fs/f2fs/data.c | 6 ++ > 1 file ch

Re: [f2fs-dev] [PATCH] f2fs: refactoring nat and sit functions

2021-05-04 Thread Jaegeuk Kim
On 04/29, Daejun Park wrote: > This patch separates the APIs for nat and sit. > > f2fs_lookup_journal_in_cursum -> f2fs_lookup_journal_{nats|sits}_in_cursum > __has_cursum_space -> __has_{nats|sits}_in_cursum_space I don't get why we need this? > > Signed-off-by: Daejun Park > --- > fs/f2fs/f

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneed check condition

2021-05-04 Thread Jaegeuk Kim
Hi Chao, I split this into two patches along with upstreamed change. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test Thanks, On 04/27, Chao Yu wrote: > This patch changes as below: > - remove unneeded check condition in __cluster_may_compress() > - rename __clus

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-04 Thread Jaegeuk Kim
On 04/27, Chao Yu wrote: > On 2021/4/27 1:09, Jaegeuk Kim wrote: > > On 04/25, Chao Yu wrote: > > > We may trigger high frequent checkpoint for below case: > > > 1. mkdir /mnt/dir1; set dir1 encrypted > > > 2. touch /mnt/file1; fsync /mnt/file1 > > > 3. mkdir /mnt/dir2; set dir2 encrypted > > > 4.