Re: [f2fs-dev] [PATCH v2] f2fs: avoid swapon failure by giving a warning first

2021-05-11 Thread Jaegeuk Kim
The final solution can be migrating blocks to form a section-aligned file internally. Meanwhile, let's ask users to do that when preparing the swap file initially like: 1) create() 2) ioctl(F2FS_IOC_SET_PIN_FILE) 3) fallocate() Reported-by: kernel test robot Fixes: 36e4d95891ed ("f2fs: check if

Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first

2021-05-11 Thread Chao Yu
On 2021/5/12 9:28, Chao Yu wrote: On 2021/5/12 5:43, Jaegeuk Kim wrote: The final solution can be migrating blocks to form a section-aligned file internally. Meanwhile, let's ask users to do that when preparing the swap file initially like: 1) create() 2) ioctl(F2FS_IOC_SET_PIN_FILE) 3)

[f2fs-dev] [PATCH v2 2/2] f2fs: atgc: export entries for better tunability via sysfs

2021-05-11 Thread Chao Yu
This patch export below sysfs entries for better ATGC tunability. /sys/fs/f2fs//atgc_candidate_ratio /sys/fs/f2fs//atgc_candidate_count /sys/fs/f2fs//atgc_age_weight /sys/fs/f2fs//atgc_age_threshold Signed-off-by: Chao Yu --- v2: - limit value range of candidate_ratio and candidate_ratio in

Re: [f2fs-dev] 答复: [PATCH v4] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite

2021-05-11 Thread Chao Yu
On 2021/5/12 5:50, Jaegeuk Kim wrote: On 05/11, changfeng...@vivo.com wrote: Hi Jaegeuk: If there're existing clusters beyond i_size, may cause data corruption, but will this happen in normal? maybe some error can cause this, if i_size is error the data beyond size still can't handle properly.

Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first

2021-05-11 Thread Chao Yu
On 2021/5/12 5:43, Jaegeuk Kim wrote: The final solution can be migrating blocks to form a section-aligned file internally. Meanwhile, let's ask users to do that when preparing the swap file initially like: 1) create() 2) ioctl(F2FS_IOC_SET_PIN_FILE) 3) fallocate() Let me take a look how to

Re: [f2fs-dev] 答复: [PATCH v4] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite

2021-05-11 Thread Gao Xiang
On Tue, May 11, 2021 at 02:50:54PM -0700, Jaegeuk Kim wrote: > On 05/11, changfeng...@vivo.com wrote: > > Hi Jaegeuk: > > > > If there're existing clusters beyond i_size, may cause data corruption, but > > will this happen in normal? maybe some error can cause this, if i_size is > > error the

Re: [f2fs-dev] [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10

2021-05-11 Thread Nick Terrell via Linux-f2fs-devel
> On Apr 29, 2021, at 6:31 PM, Nick Terrell wrote: > > From: Nick Terrell > > Please pull from > > g...@github.com:terrelln/linux.git tags/v11-zstd-1.4.10 > > to get these changes. Alternatively the patchset is included. Hi all, Pinging this series. Is there anything I should do to

Re: [f2fs-dev] 答复: [PATCH v4] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite

2021-05-11 Thread Jaegeuk Kim
On 05/11, changfeng...@vivo.com wrote: > Hi Jaegeuk: > > If there're existing clusters beyond i_size, may cause data corruption, but > will this happen in normal? maybe some error can cause this, if i_size is > error the data beyond size still can't handle properly. Is there normal > case can

Re: [f2fs-dev] [PATCH] f2fs: set file as cold when file defragmentation

2021-05-11 Thread Jaegeuk Kim
On 05/11, Chao Yu wrote: > On 2021/5/11 14:41, Daejun Park wrote: > > > On 2021/5/11 13:09, Jaegeuk Kim wrote: > > > > On 05/11, Chao Yu wrote: > > > > > On 2021/5/10 22:47, Jaegeuk Kim wrote: > > > > > > On 05/06, Chao Yu wrote: > > > > > > > On 2021/5/6 12:46, Jaegeuk Kim wrote: > > > > > > > >

[f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first

2021-05-11 Thread Jaegeuk Kim
The final solution can be migrating blocks to form a section-aligned file internally. Meanwhile, let's ask users to do that when preparing the swap file initially like: 1) create() 2) ioctl(F2FS_IOC_SET_PIN_FILE) 3) fallocate() Reported-by: kernel test robot Fixes: 36e4d95891ed ("f2fs: check if

[f2fs-dev] 答复: [PATCH v4] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite

2021-05-11 Thread changfengnan
Hi Jaegeuk: If there're existing clusters beyond i_size, may cause data corruption, but will this happen in normal? maybe some error can cause this, if i_size is error the data beyond size still can't handle properly. Is there normal case can casue existing clusters beyond i_size? Thanks.

[f2fs-dev] [PATCH 2/2] f2fs: atgc: export entries for better tunability via sysfs

2021-05-11 Thread Chao Yu
This patch export below sysfs entries for better ATGC tunability. /sys/fs/f2fs//atgc_candidate_ratio /sys/fs/f2fs//atgc_candidate_count /sys/fs/f2fs//atgc_age_weight /sys/fs/f2fs//atgc_age_threshold Signed-off-by: Chao Yu --- Documentation/ABI/testing/sysfs-fs-f2fs | 28

[f2fs-dev] [PATCH 1/2] f2fs: atgc: fix to set default age threshold

2021-05-11 Thread Chao Yu
Default age threshold value is missed to set, fix it. Fixes: 093749e296e2 ("f2fs: support age threshold based garbage collection") Reported-by: Sahitya Tummala Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index

Re: [f2fs-dev] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-11 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 15:22:02 -0400 "Theodore Ts'o" escreveu: > On Mon, May 10, 2021 at 02:49:44PM +0100, David Woodhouse wrote: > > On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > > > This patch series is doing conversion only when using ASCII makes > > > more sense than

Re: [f2fs-dev] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-11 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 14:49:44 +0100 David Woodhouse escreveu: > On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > > This patch series is doing conversion only when using ASCII makes > > more sense than using UTF-8. > > > > See, a number of converted documents ended with weird

Re: [f2fs-dev] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-11 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 15:33:47 +0100 Edward Cree escreveu: > On 10/05/2021 14:59, Matthew Wilcox wrote: > > Most of these > > UTF-8 characters come from latex conversions and really aren't > > necessary (and are being used incorrectly). > I fully agree with fixing those. > The cover-letter,

Re: [f2fs-dev] [PATCH] f2fs: set file as cold when file defragmentation

2021-05-11 Thread Chao Yu
On 2021/5/11 14:41, Daejun Park wrote: On 2021/5/11 13:09, Jaegeuk Kim wrote: On 05/11, Chao Yu wrote: On 2021/5/10 22:47, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/5/6 12:46, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/4/29 14:20, Daejun Park wrote: In file

Re: [f2fs-dev] [f2fs:dev-test 12/12] fs/f2fs/super.c:4194:31: error: implicit declaration of function 'COMPRESS_MAPPING'

2021-05-11 Thread Chao Yu
compress_inode to cache compressed blocks config: x86_64-randconfig-a003-20210511 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a0fed635fe1701470062495a6ffee1c608f3f1bc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp

Re: [f2fs-dev] [PATCH] f2fs: set file as cold when file defragmentation

2021-05-11 Thread Daejun Park
>On 2021/5/11 13:09, Jaegeuk Kim wrote: >> On 05/11, Chao Yu wrote: >>> On 2021/5/10 22:47, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: > On 2021/5/6 12:46, Jaegeuk Kim wrote: >> On 05/06, Chao Yu wrote: >>> On 2021/4/29 14:20, Daejun Park wrote: In file defragmentation

Re: [f2fs-dev] [PATCH] f2fs: set file as cold when file defragmentation

2021-05-11 Thread Chao Yu
On 2021/5/11 13:09, Jaegeuk Kim wrote: On 05/11, Chao Yu wrote: On 2021/5/10 22:47, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/5/6 12:46, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/4/29 14:20, Daejun Park wrote: In file defragmentation by ioctl, all data blocks in the

Re: [f2fs-dev] [PATCH] f2fs: avoid null pointer access when handling IPU error

2021-05-11 Thread Chao Yu
On 2021/5/11 13:07, Jaegeuk Kim wrote: On 05/11, Chao Yu wrote: On 2021/5/10 22:28, Jaegeuk Kim wrote: Unable to handle kernel NULL pointer dereference at virtual address 001a pc : f2fs_inplace_write_data+0x144/0x208 lr : f2fs_inplace_write_data+0x134/0x208 Call trace: