Re: [f2fs-dev] [PATCH 1/2] f2fs: compress: fix to disallow wildcard extension for hot/cold file

2021-05-19 Thread Chao Yu
On 2021/5/20 10:21, Jaegeuk Kim wrote: On 05/18, Chao Yu wrote: If all files are hot or cold, hot/cold separation is not needed anymore, so let's disallow configure wildcard extension. We need to be able to set hot/cold on the fly? I got your concern, so do you prefer to keep "*" extension c

Re: [f2fs-dev] [PATCH 1/2] f2fs: compress: fix to disallow wildcard extension for hot/cold file

2021-05-19 Thread Jaegeuk Kim
On 05/18, Chao Yu wrote: > If all files are hot or cold, hot/cold separation is not needed anymore, > so let's disallow configure wildcard extension. We need to be able to set hot/cold on the fly? > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Signed-off-by: Chao Yu > --- > fs/f2

Re: [f2fs-dev] [PATCH 03/11] mm: Protect operations adding pages to page cache with invalidate_lock

2021-05-19 Thread Jan Kara
On Wed 19-05-21 08:36:37, Dave Chinner wrote: > On Fri, May 14, 2021 at 09:17:30AM -0700, Darrick J. Wong wrote: > > On Fri, May 14, 2021 at 09:19:45AM +1000, Dave Chinner wrote: > > > On Thu, May 13, 2021 at 11:52:52AM -0700, Darrick J. Wong wrote: > > > > On Thu, May 13, 2021 at 07:44:59PM +0200,

Re: [f2fs-dev] 答复: 答复: [PATCH v4] f2fs: compress: add nocompress extensions support

2021-05-19 Thread Chao Yu
FYI, https://www.mail-archive.com/linux-f2fs-devel@lists.sourceforge.net/msg19644.html On 2021/5/19 16:03, changfeng...@vivo.com wrote: Ok, thanks. -邮件原件- 发件人: Chao Yu 发送时间: 2021年5月19日 15:58 收件人: changfeng...@vivo.com; jaeg...@kernel.org; c...@kernel.org; linux-f2fs-devel@lists.source

[f2fs-dev] [PATCH v5] f2fs: compress: add nocompress extensions support

2021-05-19 Thread Fengnan Chang
When we create a directory with enable compression, all file write into directory will try to compress.But sometimes we may know, new file cannot meet compression ratio requirements. We need a nocompress extension to skip those files to avoid unnecessary compress page test. After add nocompress_ex

[f2fs-dev] 答复: 答复: [PATCH v4] f2fs: compress: add nocompress extensions support

2021-05-19 Thread changfengnan
Ok, thanks. -邮件原件- 发件人: Chao Yu 发送时间: 2021年5月19日 15:58 收件人: changfeng...@vivo.com; jaeg...@kernel.org; c...@kernel.org; linux-f2fs-devel@lists.sourceforge.net 主题: Re: 答复: [f2fs-dev] [PATCH v4] f2fs: compress: add nocompress extensions support On 2021/5/19 15:47, changfeng...@vivo.com wr

Re: [f2fs-dev] 答复: [PATCH v4] f2fs: compress: add nocompress extensions support

2021-05-19 Thread Chao Yu
On 2021/5/19 15:47, changfeng...@vivo.com wrote: Do you mean the case of don't allow use '*' to specifie all file in nocompress extension? It's handled by f2fs_test_compress_extension. Or other case? I've pointed out in below thread: https://lore.kernel.org/linux-f2fs-devel/c7ee799d-a8de-4671-

[f2fs-dev] 答复: [PATCH v4] f2fs: compress: add nocompress extensions support

2021-05-19 Thread changfengnan
Do you mean the case of don't allow use '*' to specifie all file in nocompress extension? It's handled by f2fs_test_compress_extension. Or other case? -邮件原件- 发件人: Chao Yu 发送时间: 2021年5月19日 15:01 收件人: Fengnan Chang ; jaeg...@kernel.org; c...@kernel.org; linux-f2fs-devel@lists.sourceforge.n

Re: [f2fs-dev] [PATCH v4] f2fs: compress: add nocompress extensions support

2021-05-19 Thread Chao Yu
On 2021/5/18 20:07, Fengnan Chang wrote: When we create a directory with enable compression, all file write into directory will try to compress.But sometimes we may know, new file cannot meet compression ratio requirements. We need a nocompress extension to skip those files to avoid unnecessary c