Re: [f2fs-dev] [PATCH v2] fscrypt: fix derivation of SipHash keys on big endian CPUs

2021-06-10 Thread Eric Biggers
On Sat, Jun 05, 2021 at 12:50:33AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Typically, the cryptographic APIs that fscrypt uses take keys as byte > arrays, which avoids endianness issues. However, siphash_key_t is an > exception. It is defined as 'u64 key[2];', i.e. the 128-bit key i

[f2fs-dev] [PATCH v3] f2fs: introduce f2fs_casefolded_name slab cache

2021-06-10 Thread Chao Yu
From: Chao Yu Add a slab cache: "f2fs_casefolded_name" for memory allocation of casefold name. Reviewed-by: Eric Biggers Signed-off-by: Chao Yu --- v3: - change "f2fs_casefold_name" to "f2fs_casefolded_name" in commit title and message. fs/f2fs/dir.c | 17 +++-- fs/f2fs/recov

Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: clean up /sys/fs/f2fs//features

2021-06-10 Thread Eric Biggers
On Sat, Jun 05, 2021 at 10:36:10PM -0700, Jaegeuk Kim wrote: > Let's create /sys/fs/f2fs//feature_list/ to meet sysfs rule. > > Note that there are three feature list entries: > 1) /sys/fs/f2fs/features > : shows runtime features supported by in-kernel f2fs along with Kconfig. > - ref. F2FS_

Re: [f2fs-dev] [PATCH v2] f2fs: introduce f2fs_casefold_name slab cache

2021-06-10 Thread Eric Biggers
On Tue, Jun 08, 2021 at 08:00:22AM +0800, Chao Yu wrote: > From: Chao Yu > > Add a slab cache: "f2fs_casefold_name" for memory allocation > of casefold name. Commit message should say "f2fs_casefolded_name", not "f2fs_casefold_name". > Signed-off-by: Chao Yu > --- > v2: > - change slab cache n

Re: [f2fs-dev] [PATCH] sload.f2fs: use F2FS_COMPRESS_RELEASED instead of IMMUTABLE bit

2021-06-10 Thread Jaegeuk Kim
On 06/10, Chao Yu wrote: > On 2021/6/10 2:42, Jaegeuk Kim wrote: > > On 06/08, Chao Yu wrote: > > > On 2021/6/8 0:52, Jaegeuk Kim wrote: > > > > On 06/06, Chao Yu wrote: > > > > > On 2021/5/26 4:51, Jaegeuk Kim wrote: > > > > > > Let's use F2FS_COMPRESS_RELEASED to disallow writes only. > > > > > >

Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit

2021-06-10 Thread Chao Yu
On 2021/6/10 2:43, Jaegeuk Kim wrote: On 06/08, Chao Yu wrote: On 2021/6/8 0:56, Jaegeuk Kim wrote: On 06/06, Chao Yu wrote: On 2021/5/26 4:49, Jaegeuk Kim wrote: Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned out it disallows every fs operations which we don't

Re: [f2fs-dev] [PATCH] sload.f2fs: use F2FS_COMPRESS_RELEASED instead of IMMUTABLE bit

2021-06-10 Thread Chao Yu
On 2021/6/10 2:42, Jaegeuk Kim wrote: On 06/08, Chao Yu wrote: On 2021/6/8 0:52, Jaegeuk Kim wrote: On 06/06, Chao Yu wrote: On 2021/5/26 4:51, Jaegeuk Kim wrote: Let's use F2FS_COMPRESS_RELEASED to disallow writes only. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Too late, as I pu

Re: [f2fs-dev] [PATCH 12/14] fuse: Convert to using invalidate_lock

2021-06-10 Thread Miklos Szeredi
On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache content

Re: [f2fs-dev] [PATCH 01/14] mm: Fix comments mentioning i_mutex

2021-06-10 Thread Jan Kara
On Thu 10-06-21 17:06:41, Ming Lei wrote: > On Mon, Jun 07, 2021 at 04:52:11PM +0200, Jan Kara wrote: > > inode->i_mutex has been replaced with inode->i_rwsem long ago. Fix > > comments still mentioning i_mutex. > > > > Reviewed-by: Christoph Hellwig > > Acked-by: Hugh Dickins > > Signed-off-by:

Re: [f2fs-dev] [PATCH 01/14] mm: Fix comments mentioning i_mutex

2021-06-10 Thread Ming Lei
On Mon, Jun 07, 2021 at 04:52:11PM +0200, Jan Kara wrote: > inode->i_mutex has been replaced with inode->i_rwsem long ago. Fix > comments still mentioning i_mutex. > > Reviewed-by: Christoph Hellwig > Acked-by: Hugh Dickins > Signed-off-by: Jan Kara > --- ... > diff --git a/mm/rmap.c b/mm/rma