[f2fs-dev] [PATCH v3] f2fs: add sysfs nodes to get GC info for each GC mode

2021-07-09 Thread Daeho Jeong
From: Daeho Jeong Added gc_reclaimed_segments and gc_segment_mode sysfs nodes. 1) "gc_reclaimed_segments" shows how many segments have been reclaimed by GC during a specific GC mode. 2) "gc_segment_mode" is used to control for which gc mode the "gc_reclaimed_segments" node shows. Signed-off-by:

Re: [f2fs-dev] [PATCH v2] f2fs: add sysfs nodes to get GC info for each GC mode

2021-07-09 Thread Daeho Jeong
On Fri, Jul 9, 2021 at 5:17 PM Chao Yu wrote: > > On 2021/7/10 4:44, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Added gc_dirty_segs and gc_dirty_segs_mode sysfs nodes. > > 1) "gc_dirty_segs" shows how many dirty segments have been > > reclaimed by GC during a specific GC mode. > > 2) "gc_di

[f2fs-dev] [PATCH] f2fs: compress: fix to set zstd compress level correctly

2021-07-09 Thread Chao Yu
As 5kft reported in [1]: set_compress_context() should set compress level into .i_compress_flag for zstd as well as lz4hc, otherwise, zstd compressor will still use default zstd compress level during compression, fix it. [1] https://lore.kernel.org/linux-f2fs-devel/8e29f52b-6b0d-45ec-9520-e63eb2

Re: [f2fs-dev] f2fs compression level not actually set when using zstd compression?

2021-07-09 Thread Chao Yu
Hello, On 2021/7/10 0:52, 5kft wrote: It appears that the logic in "set_compress_context" (in https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/tree/fs/f2fs/f2fs.h, line 4021) does not actually set the compression level in the inode for zstd compression - it only sets it for lz

Re: [f2fs-dev] [PATCH v2] f2fs: avoid to create an empty string as the extension_list

2021-07-09 Thread Chao Yu
On 2021/7/9 16:34, Wang Xiaojun wrote: When creating a file, we need to set the temperature based on extension_list. If the empty string is a valid extension_list, the is_extension_exist will always returns true, which affects the separation of hot and cold. Signed-off-by: Wang Xiaojun Review

Re: [f2fs-dev] [PATCH v2] f2fs: add sysfs nodes to get GC info for each GC mode

2021-07-09 Thread Chao Yu
On 2021/7/10 4:44, Daeho Jeong wrote: From: Daeho Jeong Added gc_dirty_segs and gc_dirty_segs_mode sysfs nodes. 1) "gc_dirty_segs" shows how many dirty segments have been reclaimed by GC during a specific GC mode. 2) "gc_dirty_segs_mode" is used to control for which gc mode the "gc_dirty_segs"

[f2fs-dev] [PATCH v2] f2fs: add sysfs nodes to get GC info for each GC mode

2021-07-09 Thread Daeho Jeong
From: Daeho Jeong Added gc_dirty_segs and gc_dirty_segs_mode sysfs nodes. 1) "gc_dirty_segs" shows how many dirty segments have been reclaimed by GC during a specific GC mode. 2) "gc_dirty_segs_mode" is used to control for which gc mode the "gc_dirty_segs" node shows. Signed-off-by: Daeho Jeong

Re: [f2fs-dev] [GIT PULL] f2fs for 5.14-rc1

2021-07-09 Thread pr-tracker-bot
The pull request you sent on Wed, 7 Jul 2021 12:58:50 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-for-5.14-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/227c4d507c71acb7bece298a98d83e5b44433f62 Thank you! -- Deet-doot-do

[f2fs-dev] f2fs compression level not actually set when using zstd compression?

2021-07-09 Thread 5kft
It appears that the logic in "set_compress_context" (in https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/tree/fs/f2fs/f2fs.h, line 4021) does not actually set the compression level in the inode for zstd compression - it only sets it for lz4: if (F2FS_I(inode)->i_compress_alg

[f2fs-dev] [PATCH v2] f2fs: avoid to create an empty string as the extension_list

2021-07-09 Thread Wang Xiaojun
When creating a file, we need to set the temperature based on extension_list. If the empty string is a valid extension_list, the is_extension_exist will always returns true, which affects the separation of hot and cold. Signed-off-by: Wang Xiaojun --- v1->v2:let the caller do the check on @name -