[f2fs-dev] [syzbot] BUG: unable to handle kernel NULL pointer dereference in f2fs_update_meta_page

2021-07-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6498f6151825 Merge tag 'riscv-for-linus-5.14-rc3' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14bbce4630 kernel config: https://syzkaller.appspot.com/x/.config?x=5dc0e3202ae2f574 das

[f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk

2021-07-25 Thread Daeho Jeong
From: Daeho Jeong When we print out a discontinuous compression chunk, it shows like a continuous chunk now. To show it more correctly, I've changed the way of printing fiemap info like below. Plus, eliminated NEW_ADDR(-1) in fiemap info, since it is not in fiemap user api manual. Let's assume 1

Re: [f2fs-dev] [PATCH 0/5] fscrypt: report correct st_size for encrypted symlinks

2021-07-25 Thread Eric Biggers
On Thu, Jul 01, 2021 at 11:53:45PM -0700, Eric Biggers wrote: > This series makes the stat() family of syscalls start reporting the > correct size for encrypted symlinks. > > See patch 1 for a detailed explanation of the problem and solution. > > Patch 1 adds a helper function that computes the c

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-25 Thread Eric Biggers
On Sun, Jul 25, 2021 at 08:47:51AM -0700, Jaegeuk Kim wrote: > On 07/25, Jaegeuk Kim wrote: > > Note that, this patch is failing generic/250. > > correction: it's failing in 4.14 and 4.19 after simple cherry-pick, but > giving no failure on 5.4, 5.10, and mainline. > For me, generic/250 fails on

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-25 Thread Eric Biggers
On Sun, Jul 25, 2021 at 06:50:51PM +0800, Chao Yu wrote: > On 2021/7/16 22:39, Eric Biggers wrote: > > From: Eric Biggers > > > > f2fs_write_begin() assumes that all blocks were preallocated by > > default unless FI_NO_PREALLOC is explicitly set. This invites data > > corruption, as there are ca

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-25 Thread Jaegeuk Kim
On 07/25, Jaegeuk Kim wrote: > Note that, this patch is failing generic/250. correction: it's failing in 4.14 and 4.19 after simple cherry-pick, but giving no failure on 5.4, 5.10, and mainline. > > On 07/16, Eric Biggers wrote: > > From: Eric Biggers > > > > f2fs_write_begin() assumes that al

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-25 Thread Jaegeuk Kim
Note that, this patch is failing generic/250. On 07/16, Eric Biggers wrote: > From: Eric Biggers > > f2fs_write_begin() assumes that all blocks were preallocated by > default unless FI_NO_PREALLOC is explicitly set. This invites data > corruption, as there are cases in which not all blocks are

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-25 Thread Chao Yu
On 2021/7/16 22:39, Eric Biggers wrote: From: Eric Biggers f2fs_write_begin() assumes that all blocks were preallocated by default unless FI_NO_PREALLOC is explicitly set. This invites data corruption, as there are cases in which not all blocks are preallocated. Commit 47501f87c61a ("f2fs: pre

Re: [f2fs-dev] [PATCH 1/9] f2fs: make f2fs_write_failed() take struct inode

2021-07-25 Thread Chao Yu
On 2021/7/16 22:39, Eric Biggers wrote: From: Eric Biggers Make f2fs_write_failed() take a 'struct inode' directly rather than a 'struct address_space', as this simplifies it slightly. Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, _