[f2fs-dev] [PATCH -next] f2fs: fix min_seq_blocks can not make sense in some scenes.

2021-07-30 Thread Laibin Qiu
F2FS have dirty page count control for batched sequential write in writepages, and get the value of min_seq_blocks by blocks_per_seg * segs_per_sec(segs_per_sec defaults to 1). But in some scenes we set a lager section size, Min_seq_blocks will become too large to achieve the expected effect(eg. 4t

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Theodore Ts'o
On Fri, Jul 30, 2021 at 12:17:26PM -0700, Eric Biggers wrote: > > Currently, non-overwrite DIO writes are fundamentally unsafe on f2fs as > > they require preallocating blocks, but f2fs doesn't support unwritten > > blocks and therefore has to preallocate the blocks as regular blocks. > > f2fs has

[f2fs-dev] [PATCH] f2fs: introduce discard_unit mount option

2021-07-30 Thread Chao Yu
As James Z reported in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213877 [1.] One-line summary of the problem: Mount multiple SMR block devices exceed certain number cause system non-response [2.] Full description of the problem/report: Created some F2FS on SMR devices (mkfs.f2fs -m),

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Eric Biggers
On Fri, Jul 30, 2021 at 06:05:59PM -0700, Jaegeuk Kim wrote: > On 07/30, Eric Biggers wrote: > > On Fri, Jul 30, 2021 at 03:12:15PM -0700, Jaegeuk Kim wrote: > > > On 07/30, Eric Biggers wrote: > > > > On Tue, Jul 27, 2021 at 06:51:54PM -0700, Eric Biggers wrote: > > > > > From: Eric Biggers > > >

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Jaegeuk Kim
On 07/30, Eric Biggers wrote: > On Fri, Jul 30, 2021 at 03:12:15PM -0700, Jaegeuk Kim wrote: > > On 07/30, Eric Biggers wrote: > > > On Tue, Jul 27, 2021 at 06:51:54PM -0700, Eric Biggers wrote: > > > > From: Eric Biggers > > > > > > > > Currently, non-overwrite DIO writes are fundamentally unsaf

Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Chao Yu
On 2021/7/31 8:42, Jaegeuk Kim wrote: On 07/31, Chao Yu wrote: On 2021/7/31 7:41, Chao Yu wrote: On 2021/7/31 2:28, Jaegeuk Kim wrote: how about adding "discard_gran=[small|segment|section]", and keeping discard_map in the small case only? And, I think we should set the section mode for zoned

Re: [f2fs-dev] [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

2021-07-30 Thread Jaegeuk Kim
On 07/31, Chao Yu wrote: > On 2021/7/31 3:09, Jaegeuk Kim wrote: > > We need to get sbi->s_flag to understand the current f2fs status as well. > > One example is SBI_NEED_FSCK. > > Typo in patch title: "f2f/sstatus". > > Please note that there is a sysfs entry /sys/fs/f2fs/ > > > > Signed-off-b

Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Jaegeuk Kim
On 07/31, Chao Yu wrote: > On 2021/7/31 7:41, Chao Yu wrote: > > On 2021/7/31 2:28, Jaegeuk Kim wrote: > > > how about adding "discard_gran=[small|segment|section]", and keeping > > > discard_map > > > in the small case only? And, I think we should set the section mode for > > > zoned > > > devic

Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Chao Yu
On 2021/7/31 7:41, Chao Yu wrote: On 2021/7/31 2:28, Jaegeuk Kim wrote: how about adding "discard_gran=[small|segment|section]", and keeping discard_map in the small case only? And, I think we should set the section mode for zoned device automatically. Yup, better, About the naming, it look d

Re: [f2fs-dev] [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

2021-07-30 Thread Chao Yu
On 2021/7/31 3:09, Jaegeuk Kim wrote: We need to get sbi->s_flag to understand the current f2fs status as well. One example is SBI_NEED_FSCK. Typo in patch title: "f2f/sstatus". Please note that there is a sysfs entry /sys/fs/f2fs/ Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Chao Yu
On 2021/7/31 2:28, Jaegeuk Kim wrote: how about adding "discard_gran=[small|segment|section]", and keeping discard_map in the small case only? And, I think we should set the section mode for zoned device automatically. Yup, better, About the naming, it look discard_gran is not clear here, sinc

Re: [f2fs-dev] [PATCH v3] f2fs: fix to force keeping write barrier for strict fsync mode

2021-07-30 Thread Jaegeuk Kim
On 07/29, Chao Yu wrote: > Ping, Added. Thanks. > > On 2021/7/20 9:19, Chao Yu wrote: > > On 2021/7/20 9:15, Jaegeuk Kim wrote: > > > Wasn't it supposed to be v1? > > > > I skip IPU case for v1, and resend it as v3, is it fine to you? > > > > Thanks, > > > > > > > > On 07/20, Chao Yu wrote:

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Eric Biggers
On Fri, Jul 30, 2021 at 03:12:15PM -0700, Jaegeuk Kim wrote: > On 07/30, Eric Biggers wrote: > > On Tue, Jul 27, 2021 at 06:51:54PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > Currently, non-overwrite DIO writes are fundamentally unsafe on f2fs as > > > they require preallocat

Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail

2021-07-30 Thread Jaegeuk Kim
On 07/20, Chao Yu wrote: > On 2021/7/20 2:25, Jaegeuk Kim wrote: > > On 07/19, Chao Yu wrote: > > > On 2021/4/27 20:37, Chao Yu wrote: > > > > I think just reverting dirty/free bitmap is not enough if checkpoint > > > > fails, > > > > due to we have updated sbi->cur_cp_pack and nat/sit bitmap, nex

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Jaegeuk Kim
On 07/30, Eric Biggers wrote: > On Tue, Jul 27, 2021 at 06:51:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Currently, non-overwrite DIO writes are fundamentally unsafe on f2fs as > > they require preallocating blocks, but f2fs doesn't support unwritten > > blocks and therefore h

Re: [f2fs-dev] [RFC NO MERGE] f2fs: extent cache: support unaligned extent

2021-07-30 Thread Jaegeuk Kim
On 07/07, Chao Yu wrote: > Compressed inode may suffer read performance issue due to it can not > use extent cache, so I propose to add this unaligned extent support > to improve it. > > Currently, it only works in readonly format f2fs image. > > Unaligned extent: in one compressed cluster, physi

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-07-30 Thread Eric Biggers
On Tue, Jul 27, 2021 at 06:51:54PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Currently, non-overwrite DIO writes are fundamentally unsafe on f2fs as > they require preallocating blocks, but f2fs doesn't support unwritten > blocks and therefore has to preallocate the blocks as regular bl

[f2fs-dev] [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

2021-07-30 Thread Jaegeuk Kim
We need to get sbi->s_flag to understand the current f2fs status as well. One example is SBI_NEED_FSCK. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index 53ed1e9191f0..473ad04d1891 10064

Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Jaegeuk Kim
On 07/30, Chao Yu wrote: > As James Z reported in bugzilla: > > https://bugzilla.kernel.org/show_bug.cgi?id=213877 > > [1.] One-line summary of the problem: > Mount multiple SMR block devices exceed certain number cause system > non-response > > [2.] Full description of the problem/report: > Cr

[f2fs-dev] [PATCH] fs: unicode: Add utf8-data module

2021-07-30 Thread Shreeya Patel
utf8data.h_shipped has a large database table which is an auto-generated decodification trie for the unicode normalization functions. We can avoid carrying this large table in the kernel unless it is required by the filesystem during boot process. Hence, add utf8-data module which will be loaded o

[f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option

2021-07-30 Thread Chao Yu
As James Z reported in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213877 [1.] One-line summary of the problem: Mount multiple SMR block devices exceed certain number cause system non-response [2.] Full description of the problem/report: Created some F2FS on SMR devices (mkfs.f2fs -m),

[f2fs-dev] [Bug 213877] Mount multiple SMR block devices exceed certain number cause system non-response

2021-07-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213877 --- Comment #4 from Chao Yu (c...@kernel.org) --- Sorry, I've fixed that case: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=misc&id=527a7d6a3e0307ad1b4bcc7811cc2920b2af45c5 -- You may reply to this email to add a com