Re: [f2fs-dev] [PATCH] f2fs: fix missing inplace count in overwrite with direct io

2021-08-17 Thread Fengnan Chang
On 2021/8/13 9:36, Chao Yu wrote: On 2021/8/13 5:15, Jaegeuk Kim wrote: On 08/06, Chao Yu wrote: On 2021/7/29 20:25, Fengnan Chang wrote: For now, overwrite file with direct io use inplace policy, but not counted, fix it. IMO, LFS/SSR/IPU stats in debugfs was for buffered write, maybe we n

[f2fs-dev] [PATCH v3] f2fs: introduce periodic iostat io latency traces

2021-08-17 Thread Daeho Jeong
From: Daeho Jeong Whenever we notice some sluggish issues on our machines, we are always curious about how well all types of I/O in the f2fs filesystem are handled. But, it's hard to get this kind of real data. First of all, we need to reproduce the issue while turning on the profiling tool like

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-08-17 Thread Eric Biggers
On Tue, Aug 17, 2021 at 02:33:01PM -0700, Jaegeuk Kim wrote: > On 08/17, Eric Biggers wrote: > > On Tue, Aug 17, 2021 at 11:57:46AM -0700, Jaegeuk Kim wrote: > > > On 08/17, Christoph Hellwig wrote: > > > > On Mon, Aug 16, 2021 at 07:03:21PM -0700, Eric Biggers wrote: > > > > > Freeing preallocated

[f2fs-dev] [PATCHi v2] fs: unicode: Add utf8-data module

2021-08-17 Thread Shreeya Patel
utf8data.h_shipped has a large database table which is an auto-generated decodification trie for the unicode normalization functions. We can avoid carrying this large table in the kernel unless it is required by the filesystem during boot process. Hence, add utf8-data module which will be loaded o

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-08-17 Thread Jaegeuk Kim
On 08/17, Eric Biggers wrote: > On Tue, Aug 17, 2021 at 11:57:46AM -0700, Jaegeuk Kim wrote: > > On 08/17, Christoph Hellwig wrote: > > > On Mon, Aug 16, 2021 at 07:03:21PM -0700, Eric Biggers wrote: > > > > Freeing preallocated blocks on error would be better than nothing, > > > > although note >

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-08-17 Thread Eric Biggers
On Tue, Aug 17, 2021 at 11:57:46AM -0700, Jaegeuk Kim wrote: > On 08/17, Christoph Hellwig wrote: > > On Mon, Aug 16, 2021 at 07:03:21PM -0700, Eric Biggers wrote: > > > Freeing preallocated blocks on error would be better than nothing, > > > although note > > > that the preallocated blocks may ha

Re: [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

2021-08-17 Thread Jaegeuk Kim
On 08/16, Nathan Chancellor wrote: > On 8/16/2021 5:33 PM, Jaegeuk Kim wrote: > > Hi Nathan, > > > > On 08/16, Nathan Chancellor wrote: > > > Without this, there is a warning in nearly every fs/f2fs/ file when > > > F2FS_FS_COMPRESSION is not set: > > > > > > In file included from fs/f2fs/super.c

Re: [f2fs-dev] [PATCH] f2fs: remove broken support for allocating DIO writes

2021-08-17 Thread Jaegeuk Kim
On 08/17, Christoph Hellwig wrote: > On Mon, Aug 16, 2021 at 07:03:21PM -0700, Eric Biggers wrote: > > Freeing preallocated blocks on error would be better than nothing, although > > note > > that the preallocated blocks may have filled an arbitrary sequence of holes > > -- > > so simply truncati