Re: [f2fs-dev] [PATCH 02/11] f2fs: simplify f2fs_sb_read_encoding

2021-08-23 Thread Chao Yu
On 2021/8/18 22:06, Christoph Hellwig wrote: Return the encoding table as the return value instead of as an argument, and don't bother with the encoding flags as the caller can handle that trivially. Signed-off-by: Christoph Hellwig Reviewed-by: Chao Yu Thanks, ___

Re: [f2fs-dev] [PATCH] f2fs: fix missing inplace count in overwrite with direct io

2021-08-23 Thread Fengnan Chang
On 2021/8/24 8:09, Chao Yu wrote: On 2021/8/23 20:07, Fengnan Chang wrote: On 2021/8/20 17:41, Chao Yu wrote: On 2021/8/18 11:49, Fengnan Chang wrote: On 2021/8/13 9:36, Chao Yu wrote: On 2021/8/13 5:15, Jaegeuk Kim wrote: On 08/06, Chao Yu wrote: On 2021/7/29 20:25, Fengnan Chang wro

Re: [f2fs-dev] [PATCH] f2fs: fix wrong option name printed by parse_options()

2021-08-23 Thread Chao Yu
On 2021/8/24 9:19, Chao Yu wrote: It prints below kernel message during mounting w/ checkpoint=disable option: "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable" Oops, this message should have been removed by "f2fs: rename checkpoint=merge mount option to checkpoint_me

[f2fs-dev] [PATCH] f2fs: fix wrong option name printed by parse_options()

2021-08-23 Thread Chao Yu
It prints below kernel message during mounting w/ checkpoint=disable option: "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable" Fix typo "checkpoint=merge" w/ "checkpoint_merge" Signed-off-by: Chao Yu --- fs/f2fs/super.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [f2fs-dev] [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable

2021-08-23 Thread Chao Yu
On 2021/8/24 1:01, Jaegeuk Kim wrote: We must flush dirty pages when calling fsync() during checkpoint=disable. Returning zero makes inode being clear, which fails to flush them when enabling checkpoint back even by sync_inodes_sb(). Without this patch, file can be persisted via checkpoint=enab

[f2fs-dev] [PATCH] f2fs: fix to account missing .skipped_gc_rwsem

2021-08-23 Thread Chao Yu
There is a missing place we forgot to account .skipped_gc_rwsem, fix it. Fixes: 6f8d4455060d ("f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc") Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 2c18

[f2fs-dev] [PATCH] f2fs: adjust unlock order for cleanup

2021-08-23 Thread Chao Yu
This patch adjusts unlock order of .i_mmap_sem and .i_gc_rwsem for cleanup. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 1323cd0f445a..3330efb41f22 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: fix missing inplace count in overwrite with direct io

2021-08-23 Thread Chao Yu
On 2021/8/23 20:07, Fengnan Chang wrote: On 2021/8/20 17:41, Chao Yu wrote: On 2021/8/18 11:49, Fengnan Chang wrote: On 2021/8/13 9:36, Chao Yu wrote: On 2021/8/13 5:15, Jaegeuk Kim wrote: On 08/06, Chao Yu wrote: On 2021/7/29 20:25, Fengnan Chang wrote: For now, overwrite file with dir

[f2fs-dev] [PATCH] f2fs_io: add rename w/ fsync option

2021-08-23 Thread Jaegeuk Kim
From: Jaegeuk Kim e.g., f2fs_io rename source dest 1 1. open(source) 2. rename(source, dest) 3. fsync(source) 4. close(source) Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 36 1 file changed, 36 insertions(+) diff --git

Re: [f2fs-dev] [PATCH v4 1/2] f2fs: separate out iostat feature

2021-08-23 Thread Jaegeuk Kim
On 08/19, Daeho Jeong wrote: > From: Daeho Jeong > > Added F2FS_IOSTAT config option to support getting IO statistics through > sysfs and printing out periodic IO statistics tracepoint events and > moved I/O statistics related codes into separate files for better > maintenance. > > Signed-off-by

[f2fs-dev] [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable

2021-08-23 Thread Jaegeuk Kim
We must flush dirty pages when calling fsync() during checkpoint=disable. Returning zero makes inode being clear, which fails to flush them when enabling checkpoint back even by sync_inodes_sb(). Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

Re: [f2fs-dev] [PATCH 05/11] unicode: pass a UNICODE_AGE() tripple to utf8_load

2021-08-23 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > Don't bother with pointless string parsing when the caller can just pass > the version in the format that the core expects. Also remove the > fallback to the latest version that none of the callers actually uses. > > Signed-off-by: Christoph Hellwig > --- > fs/ext4/

Re: [f2fs-dev] [PATCH 04/11] unicode: mark the version field in struct unicode_map unsigned

2021-08-23 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > unicode version tripplets are always unsigned. > > Signed-off-by: Christoph Hellwig Reviewed-by: Gabriel Krisman Bertazi Thanks, > --- > include/linux/unicode.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/unicode.h b/inc

Re: [f2fs-dev] [PATCH 03/11] unicode: remove the charset field from struct unicode_map

2021-08-23 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > It is hardcoded and only used for a f2fs sysfs file where it can be > hardcoded just as easily. > > Signed-off-by: Christoph Hellwig Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi ___ Linux-f2fs-devel

Re: [f2fs-dev] [PATCH 02/11] f2fs: simplify f2fs_sb_read_encoding

2021-08-23 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Looks good: Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisma

Re: [f2fs-dev] [PATCH 01/11] ext4: simplify ext4_sb_read_encoding

2021-08-23 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Looks good to me. Feel free to add Reviewed-by: Gabriel Krisman Berta

Re: [f2fs-dev] [PATCH] f2fs: fix missing inplace count in overwrite with direct io

2021-08-23 Thread Fengnan Chang
On 2021/8/20 17:41, Chao Yu wrote: On 2021/8/18 11:49, Fengnan Chang wrote: On 2021/8/13 9:36, Chao Yu wrote: On 2021/8/13 5:15, Jaegeuk Kim wrote: On 08/06, Chao Yu wrote: On 2021/7/29 20:25, Fengnan Chang wrote: For now, overwrite file with direct io use inplace policy, but not counted