Re: [f2fs-dev] [PATCH] f2fs: fix wrong option name printed by parse_options()

2021-08-24 Thread Chao Yu
On 2021/8/25 1:26, Jaegeuk Kim wrote: On 08/24, Chao Yu wrote: It prints below kernel message during mounting w/ checkpoint=disable option: "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable" Fix typo "checkpoint=merge" w/ "checkpoint_merge" Signed-off-by: Chao Yu ---

Re: [f2fs-dev] [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable

2021-08-24 Thread Chao Yu
On 2021/8/25 1:09, Jaegeuk Kim wrote: On 08/24, Chao Yu wrote: On 2021/8/24 1:01, Jaegeuk Kim wrote: We must flush dirty pages when calling fsync() during checkpoint=disable. Returning zero makes inode being clear, which fails to flush them when enabling checkpoint back even by sync_inodes_sb()

Re: [f2fs-dev] [PATCH] f2fs: fix wrong option name printed by parse_options()

2021-08-24 Thread Jaegeuk Kim
On 08/24, Chao Yu wrote: > It prints below kernel message during mounting w/ checkpoint=disable > option: > > "F2FS-fs (pmem0): checkpoint=merge cannot be used with checkpoint=disable" > > Fix typo "checkpoint=merge" w/ "checkpoint_merge" > > Signed-off-by: Chao Yu > --- > fs/f2fs/super.c | 6

Re: [f2fs-dev] [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable

2021-08-24 Thread Jaegeuk Kim
On 08/24, Chao Yu wrote: > On 2021/8/24 1:01, Jaegeuk Kim wrote: > > We must flush dirty pages when calling fsync() during checkpoint=disable. > > Returning zero makes inode being clear, which fails to flush them when > > enabling checkpoint back even by sync_inodes_sb(). > > Without this patch, f

Re: [f2fs-dev] [PATCH 05/11] unicode: pass a UNICODE_AGE() tripple to utf8_load

2021-08-24 Thread Christoph Hellwig
On Mon, Aug 23, 2021 at 11:02:52AM -0400, Gabriel Krisman Bertazi wrote: > I remember this fallback was specifically requested during a review or > in a discussion, but I honestly cannot remember the reason. > > One advantage I can think is if we have a filesystem that requires a > newer unicode v