Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option

2021-09-03 Thread Chao Yu
On 2021/9/4 12:40, Daeho Jeong wrote: As a per curseg field. Maybe, we run into the same race condition issue you told before for fragment_remained_chunk. Could you clarify this more? e.g. F2FS_OPTION(sbi).fs_mode = FS_MODE_FRAGMENT_FIXED_BLK fragment_chunk_size = 384 fragment_hole_size = 38

Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option

2021-09-03 Thread Daeho Jeong
> As a per curseg field. > > > Maybe, we run into the same race condition issue you told before for > > fragment_remained_chunk. > > Could you clarify this more? > > e.g. > > F2FS_OPTION(sbi).fs_mode = FS_MODE_FRAGMENT_FIXED_BLK > fragment_chunk_size = 384 > fragment_hole_size = 384 > > When creati

Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option

2021-09-03 Thread Chao Yu
On 2021/9/4 4:33, Daeho Jeong wrote: if (f2fs_need_seq_seg(sbi)) return 0; static inline bool f2fs_need_seq_seg(struct f2fs_sb_info *sbi) { return F2FS_OPTION(sbi).fs_mode == FS_MODE_FRAGMENT_FIXED_BLK; } Do you need this in select_policy(), either? IMO, f

Re: [f2fs-dev] [PATCH v2] f2fs: avoid attaching SB_ACTIVE flag during mount

2021-09-03 Thread Chao Yu
On 2021/9/4 8:17, Jaegeuk Kim wrote: I remember this gave a regression before? I have removed changes which bothers checkpoint disabling path, how about testing this in dev-test branch for a while? BTW, any plan to porting checkpoint disabling testcases from android into xfstest suit? Thanks,

[f2fs-dev] [GIT PULL] f2fs update for 5.15-rc1

2021-09-03 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thanks, The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3: Linux 5.14-rc1 (2021-07-11 15:07:40 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git ta

Re: [f2fs-dev] [PATCH v2] f2fs: avoid attaching SB_ACTIVE flag during mount

2021-09-03 Thread Jaegeuk Kim
I remember this gave a regression before? On 09/01, Chao Yu wrote: > Quoted from [1] > > "I do remember that I've added this code back then because otherwise > orphan cleanup was losing updates to quota files. But you're right > that now I don't see how that could be happening and it would be nic

Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option

2021-09-03 Thread Daeho Jeong
> if (f2fs_need_seq_seg(sbi)) > return 0; > > static inline bool f2fs_need_seq_seg(struct f2fs_sb_info *sbi) > { > return F2FS_OPTION(sbi).fs_mode == FS_MODE_FRAGMENT_FIXED_BLK; > } > Do you need this in select_policy(), either? Like, if (f2fs_need_rand_seg(

Re: [f2fs-dev] [PATCH 5.4 0/4] backport fscrypt symlink fixes to 5.4

2021-09-03 Thread Greg KH
On Wed, Sep 01, 2021 at 09:40:37AM -0700, Eric Biggers wrote: > This series backports some patches that failed to apply to 5.4-stable > due to the prototype of inode_operations::getattr having changed in > v5.12, as well several other conflicts. Please apply to 5.4-stable. > > Eric Biggers (4): >

[f2fs-dev] Patch "ubifs: report correct st_size for encrypted symlinks" has been added to the 5.4-stable tree

2021-09-03 Thread gregkh
This is a note to let you know that I've just added the patch titled ubifs: report correct st_size for encrypted symlinks to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ub

[f2fs-dev] Patch "f2fs: report correct st_size for encrypted symlinks" has been added to the 5.4-stable tree

2021-09-03 Thread gregkh
This is a note to let you know that I've just added the patch titled f2fs: report correct st_size for encrypted symlinks to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2f

[f2fs-dev] Patch "ext4: report correct st_size for encrypted symlinks" has been added to the 5.4-stable tree

2021-09-03 Thread gregkh
This is a note to let you know that I've just added the patch titled ext4: report correct st_size for encrypted symlinks to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ext

[f2fs-dev] Patch "fscrypt: add fscrypt_symlink_getattr() for computing st_size" has been added to the 5.4-stable tree

2021-09-03 Thread gregkh
This is a note to let you know that I've just added the patch titled fscrypt: add fscrypt_symlink_getattr() for computing st_size to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: