[f2fs-dev] [PATCH] f2fs: fix f2fs.rst build warning

2021-10-22 Thread Fengnan Chang
fix f2fs.rst build warning. Fixes: 151b1982be5d (f2fs: compress: add nocompress extensions support) Signed-off-by: Fengnan Chang --- Documentation/filesystems/f2fs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesyst

[f2fs-dev] [PATCH v3] f2fs: compress: fix overwrite may reduce compress ratio unproperly

2021-10-22 Thread Fengnan Chang
when overwrite only first block of cluster, since cluster is not full, it will call f2fs_write_raw_pages when f2fs_write_multi_pages, and cause the whole cluster become uncompressed eventhough data can be compressed. this may will make random write bench score reduce a lot. root# dd if=/dev/zero o

Re: [f2fs-dev] [PATCH v2] f2fs: compress: fix overwrite may reduce compress ratio unproperly

2021-10-22 Thread Chao Yu
On 2021/10/22 11:53, 常凤楠 wrote: -Original Message- From: changfeng...@vivo.com On Behalf Of Chao Yu Sent: Thursday, October 21, 2021 10:34 PM To: 常凤楠 ; jaeg...@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2] f2fs: compress: fix overwrite may reduce compre

Re: [f2fs-dev] [PATCH] f2fs: remove circular locking between sb_internal and fs_reclaim

2021-10-22 Thread Chao Yu
On 2021/10/22 0:44, Daeho Jeong wrote: There is a deadlock between sb_internal lock (sb_start_intwrite()) and dquot related lock. It's because we call f2fs_truncate(), which eventually calls dquot_initialize(), while holding sb_internal lock. So, I called dquot_initialize() in advance to make the

Re: [f2fs-dev] [PATCH] f2fs: include non-compressed blocks in compr_written_block

2021-10-22 Thread Chao Yu
On 2021/10/22 5:18, Jaegeuk Kim wrote: On 10/21, Daeho Jeong wrote: Okay, shouldn't we Cc stable mailing list for this patch? otherwise userspace tool may get different stat number with the same compressed file in different kernel? Oh, could you let me know what the address of the "stable" ma