Re: [f2fs-dev] [PATCH v2] f2fs: compress: reduce one page array alloc and free when write compressed page

2021-11-09 Thread Chao Yu
On 2021/11/10 10:34, 常凤楠 wrote: -Original Message- From: changfeng...@vivo.com On Behalf Of Chao Yu Sent: Tuesday, November 9, 2021 10:11 PM To: 常凤楠 ; jaeg...@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2] f2fs: compress: reduce one page array alloc and

[f2fs-dev] [PATCH v3] f2fs: compress: reduce one page array alloc and free when write compressed page

2021-11-09 Thread Fengnan Chang
Don't alloc new page pointers array to replace old, just use old, introduce valid_nr_cpages to indicate valid number of page pointers in array, try to reduce one page array alloc and free when write compress page. Signed-off-by: Fengnan Chang --- fs/f2fs/compress.c | 32 ++---

Re: [f2fs-dev] [PATCH v2] f2fs: compress: reduce one page array alloc and free when write compressed page

2021-11-09 Thread 常凤楠
> -Original Message- > From: changfeng...@vivo.com On Behalf Of > Chao Yu > Sent: Tuesday, November 9, 2021 10:11 PM > To: 常凤楠 ; jaeg...@kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [PATCH v2] f2fs: compress: reduce one page array alloc and > free when write com

Re: [f2fs-dev] Do we need serial io for compress file?

2021-11-09 Thread 常凤楠
> -Original Message- > From: changfeng...@vivo.com On Behalf Of > Chao Yu > Sent: Tuesday, November 9, 2021 9:41 PM > To: 常凤楠 ; jaeg...@kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Subject: Re: Do we need serial io for compress file? > > On 2021/11/9 9:59, 常凤楠 wrote: > > >

Re: [f2fs-dev] Do we need serial io for compress file?

2021-11-09 Thread 常凤楠
> -Original Message- > From: changfeng...@vivo.com On Behalf Of > Chao Yu > Sent: Tuesday, November 9, 2021 9:46 PM > To: 常凤楠 ; jaeg...@kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Subject: Re: Do we need serial io for compress file? > > On 2021/11/9 11:18, 常凤楠 wrote: > > > >

Re: [f2fs-dev] [PATCH] f2fs: provide a way to attach HIPRI for Direct IO

2021-11-09 Thread Jens Axboe
On 11/9/21 9:39 AM, Christoph Hellwig wrote: > On Mon, Nov 08, 2021 at 06:13:36PM -0800, Jaegeuk Kim wrote: >> This patch adds a way to attach HIPRI by expanding the existing sysfs's >> data_io_flag. User can measure IO performance by enabling it. > > NAK. This flag should only be used when expli

Re: [f2fs-dev] [PATCH] f2fs: provide a way to attach HIPRI for Direct IO

2021-11-09 Thread Christoph Hellwig
On Mon, Nov 08, 2021 at 06:13:36PM -0800, Jaegeuk Kim wrote: > This patch adds a way to attach HIPRI by expanding the existing sysfs's > data_io_flag. User can measure IO performance by enabling it. NAK. This flag should only be used when explicitly specified by the submitter of the I/O. > > Si

Re: [f2fs-dev] [PATCH] f2fs: provide a way to attach HIPRI for Direct IO

2021-11-09 Thread Chao Yu
On 2021/11/9 10:13, Jaegeuk Kim wrote: This patch adds a way to attach HIPRI by expanding the existing sysfs's data_io_flag. User can measure IO performance by enabling it. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-d

Re: [f2fs-dev] [PATCH v2] f2fs: compress: reduce one page array alloc and free when write compressed page

2021-11-09 Thread Chao Yu
On 2021/11/9 11:54, Fengnan Chang wrote: Don't alloc new page pointers array to replace old, just use old, introduce valid_nr_cpages to indicate valid number of page pointers in array, try to reduce one page array alloc and free when write compress page. Signed-off-by: Fengnan Chang --- fs/f2

Re: [f2fs-dev] Do we need serial io for compress file?

2021-11-09 Thread Chao Yu
On 2021/11/9 11:18, 常凤楠 wrote: -Original Message- From: changfeng...@vivo.com On Behalf Of Chao Yu Sent: Monday, November 8, 2021 10:30 PM To: 常凤楠 ; jaeg...@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Subject: Re: Do we need serial io for compress file? On 2021/11/8 16:56,

Re: [f2fs-dev] Do we need serial io for compress file?

2021-11-09 Thread Chao Yu
On 2021/11/9 9:59, 常凤楠 wrote: -Original Message- From: changfeng...@vivo.com On Behalf Of Chao Yu Sent: Monday, November 8, 2021 10:21 PM To: 常凤楠 ; jaeg...@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Subject: Re: Do we need serial io for compress file? On 2021/11/8 11:54, F