Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Chao Yu
On 2021/12/3 5:28, Jaegeuk Kim wrote: On 12/02, Jaegeuk Kim wrote: On 12/02, Eric Biggers wrote: On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: On 12/02, Jaegeuk Kim wrote: On 12/02, Eric Biggers wrote: On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: On 2021/12/2 12:1

Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-02 Thread Chao Yu
On 2021/12/3 2:15, Jaegeuk Kim wrote: On 12/02, Chao Yu wrote: On 2021/12/2 6:20, Jaegeuk Kim wrote: On 11/20, Chao Yu wrote: On 2021/11/18 14:46, Chao Yu wrote: On 2021/11/18 0:56, Jaegeuk Kim wrote: On 11/09, niuzhigu...@gmail.com wrote: From: Zhiguo Niu There could be a scenario as fol

Re: [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO

2021-12-02 Thread Chao Yu
On 2021/12/3 2:13, Jaegeuk Kim wrote: On 12/02, Chao Yu wrote: On 2021/11/17 5:45, Jaegeuk Kim wrote: DIO preallocates physical blocks before writing data, but if an error occurrs or power-cut happens, we can see block contents from the disk. This patch tries to fix it by 1) turning to buffered

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Jaegeuk Kim
On 12/02, Jaegeuk Kim wrote: > On 12/02, Eric Biggers wrote: > > On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > > > On 12/02, Jaegeuk Kim wrote: > > > > On 12/02, Eric Biggers wrote: > > > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > > > On 2021/12/2 12:15, E

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Jaegeuk Kim
On 12/02, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > > On 12/02, Jaegeuk Kim wrote: > > > On 12/02, Eric Biggers wrote: > > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > > > On Thu, De

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Eric Biggers
On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > On 12/02, Jaegeuk Kim wrote: > > On 12/02, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wr

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Jaegeuk Kim
On 12/02, Jaegeuk Kim wrote: > On 12/02, Eric Biggers wrote: > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > > Why not relocating this check before f2fs_map_blocks()?

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Jaegeuk Kim
On 12/02, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > On 2021/12/2 12:15, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > Why not relocating this check before f2fs_map_blocks()? > > > > Wait, it supports DIO in multi

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Eric Biggers
On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > On 2021/12/2 12:15, Eric Biggers wrote: > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > Why not relocating this check before f2fs_map_blocks()? > > Wait, it supports DIO in multi-device image after commit 71f2c82062

Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-02 Thread Jaegeuk Kim
On 12/02, Chao Yu wrote: > On 2021/12/2 6:20, Jaegeuk Kim wrote: > > On 11/20, Chao Yu wrote: > > > On 2021/11/18 14:46, Chao Yu wrote: > > > > On 2021/11/18 0:56, Jaegeuk Kim wrote: > > > > > On 11/09, niuzhigu...@gmail.com wrote: > > > > > > From: Zhiguo Niu > > > > > > > > > > > > There could

Re: [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO

2021-12-02 Thread Jaegeuk Kim
On 12/02, Chao Yu wrote: > On 2021/11/17 5:45, Jaegeuk Kim wrote: > > DIO preallocates physical blocks before writing data, but if an error > > occurrs > > or power-cut happens, we can see block contents from the disk. This patch > > tries > > to fix it by 1) turning to buffered writes for DIO in

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-02 Thread Chao Yu
On 2021/12/2 12:15, Eric Biggers wrote: On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: Why not relocating this check before f2fs_map_blocks()? Wait, it supports DIO in multi-device image after commit 71f2c8206202 ("f2fs: multidevice: support direct IO"), how about checking with f2

[f2fs-dev] f2fs_invalidate_compress_pages sometime take long time to finish

2021-12-02 Thread Fengnan Chang
When enable compress_cache option, in my test envrionment, sometime f2fs_invalidate_compress_pages will take long time to finish, find_get_pages_range take most time, is there anyone encounter this problem too? In my test, I have 8 files, each file size was 64MB, do some seq and random read or wr